You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ntavares <gi...@git.apache.org> on 2016/03/02 11:12:42 UTC
[GitHub] cloudstack pull request: ADD be explicit about the underlying limi...
GitHub user ntavares opened a pull request:
https://github.com/apache/cloudstack/pull/1426
ADD be explicit about the underlying limitation - OpenSwan
According to:
http://linux.die.net/man/5/ipsec.secrets
A preshared secret is most conveniently represented as a sequence of characters, delimited by the double-quote character ("). The sequence cannot contain a newline or double-quote.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ntavares/cloudstack ipsec-psk-rules
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1426.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1426
----
commit 783aac8268398a68dd73d282893a4b517fce5666
Author: Nuno Tavares <n....@tech.leaseweb.com>
Date: 2016-03-02T10:11:34Z
ADD be explicit about the underlying limitation - OpenSwan
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ADD be explicit about the underlying limi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ADD be explicit about the underlying limi...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1426#issuecomment-194622098
merging giving that it is a change only in a description of an enum and that we already have 2+ LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ADD be explicit about the underlying limi...
Posted by kiwiflyer <gi...@git.apache.org>.
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1426#issuecomment-193861558
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ADD be explicit about the underlying limi...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1426#issuecomment-192720921
It seems a fair update.
LGTM due to the lack of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ADD be explicit about the underlying limi...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1426#issuecomment-192865339
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---