[GitHub] [iceberg] kbendick commented on a diff in pull request #5135: Core: Fix CreateTableRequest so serialized keys align with spec and ensure field name tests are for serialized JSON values per spec

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5135:
URL: https://github.com/apache/iceberg/pull/5135#discussion_r908112829


##########
core/src/test/java/org/apache/iceberg/rest/requests/TestCreateTableRequest.java:
##########
@@ -257,7 +255,7 @@ public void testBuilderDoesNotBuildInvalidRequests() {
 
   @Override
   public String[] allFieldsFromSpec() {
-    return new String[] {"name", "location", "schema", "spec", "order", "properties", "stageCreate"};
+    return new String[] {"name", "location", "schema", "spec", "order", "stage-create", "properties"};

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org