You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/29 12:54:40 UTC

[GitHub] [hadoop-ozone] elek opened a new pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

elek opened a new pull request #1453:
URL: https://github.com/apache/hadoop-ozone/pull/1453


   ## What changes were proposed in this pull request?
   
   The registration of the already implemented insight-point seems to be missing.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4290
   
   ## How was this patch tested?
   
   ```
   ozone insight logs -v scm.protocol.heartbeat
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1453:
URL: https://github.com/apache/hadoop-ozone/pull/1453#issuecomment-702728136


   Thanks @elek for noticing and fixing this.  It seems this was lost while resolving merge conflicts ([PR](https://github.com/elek/hadoop/commit/9abe926302f912c6fe09f1601c0818c67538de59#diff-9fb36f3970cc9c45d680c9008bcdb737R93) vs [commit](https://github.com/apache/hadoop-ozone/commit/cf69043794815a749016e7f3592302de3addc7d1#diff-9fb36f3970cc9c45d680c9008bcdb737R92)).
   
   Thanks @amaliujia for the review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1453:
URL: https://github.com/apache/hadoop-ozone/pull/1453


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] amaliujia commented on pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1453:
URL: https://github.com/apache/hadoop-ozone/pull/1453#issuecomment-700941359


   +1!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai edited a comment on pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

Posted by GitBox <gi...@apache.org>.
adoroszlai edited a comment on pull request #1453:
URL: https://github.com/apache/hadoop-ozone/pull/1453#issuecomment-702728136


   Thanks @elek for noticing and fixing this.  It seems this was lost while resolving merge conflicts of another Insight improvement ([PR](https://github.com/elek/hadoop/commit/9abe926302f912c6fe09f1601c0818c67538de59#diff-9fb36f3970cc9c45d680c9008bcdb737R93) vs [commit](https://github.com/apache/hadoop-ozone/commit/cf69043794815a749016e7f3592302de3addc7d1#diff-9fb36f3970cc9c45d680c9008bcdb737R92)).
   
   Thanks @amaliujia for the review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org