You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by shen guoquan <gu...@intel.com> on 2014/09/29 10:44:37 UTC
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/
-----------------------------------------------------------
(Updated 九月 29, 2014, 8:44 a.m.)
Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Sun Dapeng, Prasad Mujumdar, and Sravya Tirukkovalur.
Summary (updated)
-----------------
SENTRY-404:Extending Sentry thrift interface and adding a processor for generic authorization model
Bugs: sentry-404
https://issues.apache.org/jira/browse/sentry-404
Repository: sentry
Description
-------
The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestNotificationHandlerInvoker.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
Diff: https://reviews.apache.org/r/26131/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by shen guoquan <gu...@intel.com>.
> On 十二月 2, 2014, 11:57 p.m., Arun Suresh wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandler.java, line 22
> > <https://reviews.apache.org/r/26131/diff/1/?file=708103#file708103line22>
> >
> > Do you think it is possible to reuse the Existing NotificationHandler ?
The generic model use a new thrift API, becuase it doesn't want to affect the origin functionality. The arguments for the origin notificationHandler is different, so it has some diffculties to reuse the exsiting source code.
> On 十二月 2, 2014, 11:57 p.m., Arun Suresh wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandlerInvoker.java, line 2
> > <https://reviews.apache.org/r/26131/diff/1/?file=708104#file708104line2>
> >
> > Do you think it is possible to reuse the Existing NotificationHandlerInvoker ?
The generic model use a new thrift API, becuase it doesn't want to affect the origin functionality. The arguments for the origin notificationHandler is different, so it has some diffculties to reuse the exsiting source code.
> On 十二月 2, 2014, 11:57 p.m., Arun Suresh wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericServiceClient.java, line 73
> > <https://reviews.apache.org/r/26131/diff/1/?file=708107#file708107line73>
> >
> > Maybe refactor this... so that it can be shared with SentryHDFSServiceClient and SentryPolicyServiceCLient..
Hi, Arun. Thanks for your comment. I think you give me a good direction about refactor the patch. Moving all operations that involve just role or group to a separate class, the operations related the generic privileges to another class. I think it is a brilliant idea. But I recommend that the main part of generic model should be refactor is the generic sentry store(SENTRY-405). This SENTRY-404 patch hasn't a lot of code repetition, it just receive the request and redirect to the sentry store for processing.In that SENTRY-405 patch, I accept your advice, let the operations that involve role or group parts to reuse the existing code, then write a new privilege operator to process the other requests. I have already update that pacth, please help me review it and feel free give your comments. Thanks a lot
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/#review63607
-----------------------------------------------------------
On 十二月 5, 2014, 2:18 p.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26131/
> -----------------------------------------------------------
>
> (Updated 十二月 5, 2014, 2:18 p.m.)
>
>
> Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: sentry-404
> https://issues.apache.org/jira/browse/sentry-404
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 06aaacd
> sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
> sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/#review63607
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandler.java
<https://reviews.apache.org/r/26131/#comment105878>
Do you think it is possible to reuse the Existing NotificationHandler ?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandlerInvoker.java
<https://reviews.apache.org/r/26131/#comment105879>
Do you think it is possible to reuse the Existing NotificationHandlerInvoker ?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java
<https://reviews.apache.org/r/26131/#comment105882>
Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java
<https://reviews.apache.org/r/26131/#comment105883>
Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java
<https://reviews.apache.org/r/26131/#comment105884>
Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java
<https://reviews.apache.org/r/26131/#comment105885>
Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java
<https://reviews.apache.org/r/26131/#comment105886>
Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericServiceClient.java
<https://reviews.apache.org/r/26131/#comment105888>
Maybe refactor this... so that it can be shared with SentryHDFSServiceClient and SentryPolicyServiceCLient..
- Arun Suresh
On Sept. 29, 2014, 8:44 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26131/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 8:44 a.m.)
>
>
> Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: sentry-404
> https://issues.apache.org/jira/browse/sentry-404
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandler.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericServiceClient.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
> sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
> sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestNotificationHandlerInvoker.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/
-----------------------------------------------------------
(Updated 十二月 5, 2014, 2:18 p.m.)
Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
Bugs: sentry-404
https://issues.apache.org/jira/browse/sentry-404
Repository: sentry
Description
-------
The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 06aaacd
sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
Diff: https://reviews.apache.org/r/26131/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by shen guoquan <gu...@intel.com>.
> On 十二月 15, 2014, 12:17 a.m., Arun Suresh wrote:
> > Thank you for refactoring this guoquan,
> >
> > The code looks better now.. I understand that we had made the decision to have a separate Processor/Service/Client for the generic model.. so dont think there is any further refactoring that can be done.... but I am of the opinion that we should maybe reconsider it... for the sake of code maintainability atleast
Hi, Arun. I'm agree with you about making the code maintenace easily. I try my best to reuse the existing source code. The generic model design uses a seperate processor is determined in order to not interfer with the origin hive/impala processor. There is no a seperate service, because the multiplexing thrift service can register multiple processors, one for hive/impala request, the other for generic model request. there exactly uses a seperate client because of the new interface thrift file, the new interface is used for the generic model. I know indeed that there exists two client and make the maintenace difficultly. but I am of the opinion that the client/service/processor for hive/impala will be deprecated and instead of the generic model. So I insist using a separate client and the code maintenace will become easily in the future. The new reviwe request has not contain the refactor about Processor/Service/Client for the generic model.
Thanks for your review.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/#review65065
-----------------------------------------------------------
On 十二月 17, 2014, 8:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26131/
> -----------------------------------------------------------
>
> (Updated 十二月 17, 2014, 8:38 a.m.)
>
>
> Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: sentry-404
> https://issues.apache.org/jira/browse/sentry-404
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 56e0ce4
> sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
> sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/#review65065
-----------------------------------------------------------
Thank you for refactoring this guoquan,
The code looks better now.. I understand that we had made the decision to have a separate Processor/Service/Client for the generic model.. so dont think there is any further refactoring that can be done.... but I am of the opinion that we should maybe reconsider it... for the sake of code maintainability atleast
- Arun Suresh
On Dec. 5, 2014, 2:18 p.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26131/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 2:18 p.m.)
>
>
> Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: sentry-404
> https://issues.apache.org/jira/browse/sentry-404
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 06aaacd
> sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
> sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/
-----------------------------------------------------------
(Updated 十二月 17, 2014, 8:38 a.m.)
Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
Bugs: sentry-404
https://issues.apache.org/jira/browse/sentry-404
Repository: sentry
Description
-------
The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 56e0ce4
sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
Diff: https://reviews.apache.org/r/26131/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/
-----------------------------------------------------------
(Updated 十二月 17, 2014, 8:38 a.m.)
Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
Bugs: sentry-404
https://issues.apache.org/jira/browse/sentry-404
Repository: sentry
Description
-------
The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 56e0ce4
sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
Diff: https://reviews.apache.org/r/26131/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 26131: SENTRY-404:Extending Sentry thrift
interface and adding a processor for generic authorization model
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26131/
-----------------------------------------------------------
(Updated 十二月 5, 2014, 2:18 p.m.)
Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, Prasad Mujumdar, and Sravya Tirukkovalur.
Bugs: sentry-404
https://issues.apache.org/jira/browse/sentry-404
Repository: sentry
Description
-------
The previous thrift interface is not general and mainly fit for database authorization model,like hive/impala. If the sentry want to binding the other no-database authorization model such as Solr/ElasticSearch, the current sentry service can't handle this requirement. So there is a requirement to extend the sentry thrift interface to adapt the generic authorization model and add a new processor to handle thrift requests.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java 34bec93
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 06aaacd
sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift 9456274
sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java PRE-CREATION
Diff: https://reviews.apache.org/r/26131/diff/
Testing
-------
Thanks,
shen guoquan