You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by me...@apache.org on 2016/05/26 07:59:32 UTC

mesos git commit: Sorted values of the enums authorization::Action and ACLs.

Repository: mesos
Updated Branches:
  refs/heads/master 391b8dce4 -> 6ce476461


Sorted values of the enums authorization::Action and ACLs.

Unsorted entries in an enum could cause confusion for developers
writing code agains the enum and/or when introducing new values.

Review: https://reviews.apache.org/r/47865/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/6ce47646
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/6ce47646
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/6ce47646

Branch: refs/heads/master
Commit: 6ce476461f0fedfb4ed4e40c15f25bb79a39b0f3
Parents: 391b8dc
Author: Alexander Rojas <al...@mesosphere.io>
Authored: Thu May 26 00:57:37 2016 -0700
Committer: Adam B <ad...@mesosphere.io>
Committed: Thu May 26 00:57:37 2016 -0700

----------------------------------------------------------------------
 include/mesos/authorizer/acls.proto       | 4 ++--
 include/mesos/authorizer/authorizer.proto | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/6ce47646/include/mesos/authorizer/acls.proto
----------------------------------------------------------------------
diff --git a/include/mesos/authorizer/acls.proto b/include/mesos/authorizer/acls.proto
index f5ad5a3..ace9b69 100644
--- a/include/mesos/authorizer/acls.proto
+++ b/include/mesos/authorizer/acls.proto
@@ -245,8 +245,6 @@ message ACLs {
   repeated ACL.UnreserveResources unreserve_resources = 6;
   repeated ACL.CreateVolume create_volumes = 7;
   repeated ACL.DestroyVolume destroy_volumes = 8;
-  repeated ACL.GetQuota get_quotas = 14;
-  repeated ACL.UpdateQuota update_quotas = 15;
 
   // TODO(zhitao): Remove the following two fields at the end
   // of the deprecation cycle which started with 0.29.
@@ -256,6 +254,8 @@ message ACLs {
   repeated ACL.TeardownFramework teardown_frameworks = 11;
   repeated ACL.UpdateWeights update_weights = 12;
   repeated ACL.GetEndpoint get_endpoints = 13;
+  repeated ACL.GetQuota get_quotas = 14;
+  repeated ACL.UpdateQuota update_quotas = 15;
   repeated ACL.ViewFramework view_frameworks = 16;
   repeated ACL.ViewTask view_tasks = 17;
   repeated ACL.ViewExecutor view_executors = 18;

http://git-wip-us.apache.org/repos/asf/mesos/blob/6ce47646/include/mesos/authorizer/authorizer.proto
----------------------------------------------------------------------
diff --git a/include/mesos/authorizer/authorizer.proto b/include/mesos/authorizer/authorizer.proto
index 7c83eca..02d1a01 100644
--- a/include/mesos/authorizer/authorizer.proto
+++ b/include/mesos/authorizer/authorizer.proto
@@ -59,8 +59,6 @@ enum Action {
   UNRESERVE_RESOURCES_WITH_PRINCIPAL = 5;
   CREATE_VOLUME_WITH_ROLE = 6;
   DESTROY_VOLUME_WITH_PRINCIPAL = 7;
-  GET_QUOTA_WITH_ROLE = 12;
-  UPDATE_QUOTA_WITH_ROLE = 13;
 
   // TODO(zhitao): Remove the following two actions at the end of
   // the deprecation cycle which started with 0.29. They will be
@@ -70,6 +68,8 @@ enum Action {
 
   UPDATE_WEIGHTS_WITH_ROLE = 10;
   GET_ENDPOINT_WITH_PATH = 11;
+  GET_QUOTA_WITH_ROLE = 12;
+  UPDATE_QUOTA_WITH_ROLE = 13;
 
   // `VIEW_FRAMEWORK` will have an object with a `FrameworkInfo` set.
   VIEW_FRAMEWORK = 14;