[GitHub] [calcite] jinxing64 commented on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.

[GitBox <gi...@apache.org>]

jinxing64 commented on issue #1310: [CALCITE-3113] Equivalent MutableAggregates with different row types should match with each other.
URL: https://github.com/apache/calcite/pull/1310#issuecomment-509975425
 
 
   @julianhyde @danny0405 THX a lot for review !
   In this change, when `targetDescendant==target`, I add a compensation `Project`, thus the final replaced has exactly the same row-type as before. 
   When `targetDescendant != target`, I take two nodes with same digest but different row-types as equivalent, thus to achieve the matching, but this mismatch of row-types will not be visible in the final result.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services