You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/21 09:09:54 UTC
[GitHub] [druid] frnidito opened a new pull request #9387: Improves on the
fix for 8918
frnidito opened a new pull request #9387: Improves on the fix for 8918
URL: https://github.com/apache/druid/pull/9387
Improves on the fixes for #8918
### Description
It just changes the `ITRetryUtil.retryUntilTrue` with a `ITRetryUtil.retryUntil` in order to increase the amount of retries — a little change on top of https://github.com/apache/druid/pull/8999
<hr>
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] frnidito commented on issue #9387: Improves on the fix for
8918
Posted by GitBox <gi...@apache.org>.
frnidito commented on issue #9387: Improves on the fix for 8918
URL: https://github.com/apache/druid/pull/9387#issuecomment-590820077
@clintropolis — I added another retry, can you please re-run travis, or explain me how o do it, to check if it is now better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on issue #9387: Improves on the fix
for 8918
Posted by GitBox <gi...@apache.org>.
clintropolis commented on issue #9387: Improves on the fix for 8918
URL: https://github.com/apache/druid/pull/9387#issuecomment-590825669
>@clintropolis — I added another retry, can you please re-run travis, or explain me how o do it, to check if it is now better?
I can keep retries going, only committers can restart travis jobs. I've been running it over the last couple of days and so far so good; thanks for looking into this :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9387: Improves on the fix
for 8918
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9387: Improves on the fix for 8918
URL: https://github.com/apache/druid/pull/9387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org