You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/13 12:54:43 UTC

[GitHub] junrushao1994 commented on a change in pull request #13419: [MXNET-1233] Enable dynamic shape in CachedOp

junrushao1994 commented on a change in pull request #13419: [MXNET-1233] Enable dynamic shape in CachedOp
URL: https://github.com/apache/incubator-mxnet/pull/13419#discussion_r241388532
 
 

 ##########
 File path: src/imperative/cached_op.cc
 ##########
 @@ -262,6 +262,29 @@ std::vector<nnvm::NodeEntry> CachedOp::Gradient(
   return ret;
 }
 
+bool CachedOp::CheckDynamicShapeExists(const Context& default_ctx,
+                                       const std::vector<NDArray*>& inputs) {
 
 Review comment:
   Per our discussion last time, I think our solution should be naive implementation first, and then do graph partitioning to speed stuff up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services