You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/27 12:55:05 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9661: feat: Add geospatial post processing operations
villebro opened a new pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [x] Add tests
- [ ] Build / Development Environment
- [x] Documentation
### SUMMARY
Add geospatial post processing operations to new chart data endpoint.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #9187
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-620471977
@ktmud The change will require a slightly bigger refactor. I'll do this as a separate PR later to keep this PR simple. In the meantime you can do the select and rename by applying two consecutive selects; first renaming, next selecting. This will only cause negligible overhead, hence it might even be a better idea to split out all operations from `select` into separate operations to keep things simple: `select_columns`, `drop_columns` and `rename_columns`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#discussion_r416671611
##########
File path: superset/charts/schemas.py
##########
@@ -265,15 +265,23 @@ class ChartDataSelectOptionsSchema(ChartDataPostProcessingOperationOptionsSchema
columns = fields.List(
fields.String(),
description="Columns which to select from the input data, in the desired "
- "order. If columns are renamed, the old column name should be "
+ "order. If columns are renamed, the original column name should be "
"referenced here.",
example=["country", "gender", "age"],
+ required=False,
+ )
+ drop = fields.List(
Review comment:
Done. I was originally going to use `exclude`, but seems I forgot and ended up using `drop` as pandas uses that name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.54%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.57% +6.54%
==========================================
Files 532 182 -350
Lines 28897 17803 -11094
Branches 2758 0 -2758
==========================================
- Hits 18503 12564 -5939
+ Misses 10211 5239 -4972
+ Partials 183 0 -183
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `70.57% <88.23%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <83.78%> (-1.98%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `87.74% <0.00%> (-0.77%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | | |
| [...board/components/gridComponents/new/NewDivider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEaXZpZGVyLmpzeA==) | | |
| [superset-frontend/src/utils/parseCookie.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3BhcnNlQ29va2llLnRz) | | |
| ... and [349 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...186a1b2](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `1.67%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 65.70% +1.67%
==========================================
Files 532 581 +49
Lines 28897 30262 +1365
Branches 2758 3071 +313
==========================================
+ Hits 18503 19883 +1380
+ Misses 10211 10198 -13
+ Partials 183 181 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.74% <ø> (?)` | |
| #python | `70.57% <63.63%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `80.45% <48.38%> (-9.85%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [271 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...91de731](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.31%`.
> The diff coverage is `77.02%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.35% +6.31%
==========================================
Files 532 182 -350
Lines 28897 17798 -11099
Branches 2758 0 -2758
==========================================
- Hits 18503 12521 -5982
+ Misses 10211 5277 -4934
+ Partials 183 0 -183
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `70.35% <77.02%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `80.45% <48.38%> (-9.85%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <90.00%> (-1.10%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.33% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| ... and [355 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...91de731](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#discussion_r416621439
##########
File path: superset/charts/schemas.py
##########
@@ -265,15 +265,23 @@ class ChartDataSelectOptionsSchema(ChartDataPostProcessingOperationOptionsSchema
columns = fields.List(
fields.String(),
description="Columns which to select from the input data, in the desired "
- "order. If columns are renamed, the old column name should be "
+ "order. If columns are renamed, the original column name should be "
"referenced here.",
example=["country", "gender", "age"],
+ required=False,
+ )
+ drop = fields.List(
Review comment:
Just an opinion but I personally prefer `exclude`. Btw, If columns are not provided will it select all columns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#discussion_r416672053
##########
File path: tests/pandas_postprocessing_tests.py
##########
@@ -288,3 +316,83 @@ def test_cum(self):
columns={"y": "y"},
operator="abc",
)
+
+ def test_geohash_decode(self):
+ # decode lon/lat from geohash
+ post_df = proc.geohash_decode(
+ df=lonlat_df[["city", "geohash"]],
+ geohash="geohash",
+ latitude="latitude",
+ longitude="longitude",
+ )
+ self.assertListEqual(
+ sorted(post_df.columns.tolist()),
+ sorted(["city", "geohash", "latitude", "longitude"]),
+ )
+ self.assertListEqual(
+ round_floats(series_to_list(post_df["longitude"]), 6),
+ round_floats(series_to_list(lonlat_df["longitude"]), 6),
+ )
+ self.assertListEqual(
+ round_floats(series_to_list(post_df["latitude"]), 6),
+ round_floats(series_to_list(lonlat_df["latitude"]), 6),
+ )
+
+ def test_geohash_encode(self):
+ # encode lon/lat into geohash
+ post_df = proc.geohash_encode(
+ df=lonlat_df[["city", "latitude", "longitude"]],
+ latitude="latitude",
+ longitude="longitude",
+ geohash="geohash",
+ )
+ self.assertListEqual(
+ sorted(post_df.columns.tolist()),
+ sorted(["city", "geohash", "latitude", "longitude"]),
+ )
+ self.assertListEqual(
+ series_to_list(post_df["geohash"]), series_to_list(lonlat_df["geohash"]),
+ )
+
+ def geodetic_parse(self):
Review comment:
Good catch!
##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -325,23 +324,32 @@ def rolling( # pylint: disable=too-many-arguments
@validate_column_args("columns", "rename")
def select(
- df: DataFrame, columns: List[str], rename: Optional[Dict[str, str]] = None
+ df: DataFrame,
+ columns: Optional[List[str]] = None,
+ drop: Optional[List[str]] = None,
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.32%`.
> The diff coverage is `68.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.35% +6.32%
==========================================
Files 532 182 -350
Lines 28897 17803 -11094
Branches 2758 0 -2758
==========================================
- Hits 18503 12526 -5977
+ Misses 10211 5277 -4934
+ Partials 183 0 -183
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `70.35% <68.00%> (-0.21%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `81.02% <55.55%> (-9.27%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.81% <0.00%> (-0.34%)` | :arrow_down: |
| ... and [354 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...e77e9fc](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#discussion_r416621439
##########
File path: superset/charts/schemas.py
##########
@@ -265,15 +265,23 @@ class ChartDataSelectOptionsSchema(ChartDataPostProcessingOperationOptionsSchema
columns = fields.List(
fields.String(),
description="Columns which to select from the input data, in the desired "
- "order. If columns are renamed, the old column name should be "
+ "order. If columns are renamed, the original column name should be "
"referenced here.",
example=["country", "gender", "age"],
+ required=False,
+ )
+ drop = fields.List(
Review comment:
Just an opinion but I personally prefer `exclude`. If columns are not provided will it select all columns?
##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -388,3 +398,92 @@ def cum(df: DataFrame, columns: Dict[str, str], operator: str) -> DataFrame:
_("Invalid cumulative operator: %(operator)s", operator=operator)
)
return _append_columns(df, getattr(df_cum, operation)(), columns)
+
+
+def geohash_decode(
+ df: DataFrame, geohash: str, longitude: str, latitude: str
+) -> DataFrame:
+ """
+ Decode a geohash column into longitude and latitude
+
+ :param df: DataFrame containing geohash data
+ :param geohash: Name of source column containing geohash location.
+ :param longitude: Name of new column to be created containing longitude.
+ :param latitude: Name of new column to be created containing latitude.
+ :return: DataFrame with decoded longitudes and latitudes
+ """
+ try:
+ lonlat_df = DataFrame()
+ lonlat_df["latitude"], lonlat_df["longitude"] = zip(
+ *df[geohash].apply(geohash_lib.decode)
+ )
+ return _append_columns(
+ df, lonlat_df, {"latitude": latitude, "longitude": longitude}
+ )
+ except ValueError:
+ raise QueryObjectValidationError(_("Invalid geohash string"))
+
+
+def geohash_encode(
+ df: DataFrame, geohash: str, longitude: str, latitude: str,
+) -> DataFrame:
+ """
+ Encode longitude and latitude into geohash
+
+ :param df: DataFrame containing longitude and latitude data
+ :param geohash: Name of new column to be created containing geohash location.
+ :param longitude: Name of source column containing longitude.
+ :param latitude: Name of source column containing latitude.
+ :return: DataFrame with decoded longitudes and latitudes
+ """
+ try:
+ encode_df = df[[latitude, longitude]]
+ encode_df.columns = ["latitude", "longitude"]
+ encode_df["geohash"] = encode_df.apply(
+ lambda row: geohash_lib.encode(row["latitude"], row["longitude"]), axis=1,
+ )
+ return _append_columns(df, encode_df, {"geohash": geohash})
+ except ValueError:
+ QueryObjectValidationError(_("Invalid longitude/latitude"))
+
+
+def geodetic_parse(
+ df: DataFrame,
+ geodetic: str,
+ longitude: str,
+ latitude: str,
+ altitude: Optional[str] = None,
+) -> DataFrame:
+ """
+ Parse a column containing a geodetic point string
+ [Geopy](https://geopy.readthedocs.io/en/stable/#geopy.point.Point).
+
+ :param df: DataFrame containing geodetic point data
+ :param geodetic: Name of source column containing geodetic point string.
+ :param longitude: Name of new column to be created containing longitude.
+ :param latitude: Name of new column to be created containing latitude.
+ :param altitude: Name of new column to be created containing altitude.
+ :return: DataFrame with decoded longitudes and latitudes
+ """
+
+ def _parse_location(location: str) -> Tuple[float, float, float]:
+ """
+ Parse a string containing a geodetic point and return latitude, longitude
+ and altitude
+ """
+ point = Point(location) # type: ignore
+ return point[0], point[1], point[2]
+
+ try:
+ geodetic_df = DataFrame()
+ (
+ geodetic_df["latitude"],
+ geodetic_df["longitude"],
+ geodetic_df["altitude"],
+ ) = zip(*df[geodetic].apply(_parse_location))
Review comment:
nice!
##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -325,23 +324,32 @@ def rolling( # pylint: disable=too-many-arguments
@validate_column_args("columns", "rename")
def select(
- df: DataFrame, columns: List[str], rename: Optional[Dict[str, str]] = None
+ df: DataFrame,
+ columns: Optional[List[str]] = None,
+ drop: Optional[List[str]] = None,
Review comment:
Can `drop` be added to `@validate_column_args` they must exist in the dataframe right?
##########
File path: tests/pandas_postprocessing_tests.py
##########
@@ -288,3 +316,83 @@ def test_cum(self):
columns={"y": "y"},
operator="abc",
)
+
+ def test_geohash_decode(self):
+ # decode lon/lat from geohash
+ post_df = proc.geohash_decode(
+ df=lonlat_df[["city", "geohash"]],
+ geohash="geohash",
+ latitude="latitude",
+ longitude="longitude",
+ )
+ self.assertListEqual(
+ sorted(post_df.columns.tolist()),
+ sorted(["city", "geohash", "latitude", "longitude"]),
+ )
+ self.assertListEqual(
+ round_floats(series_to_list(post_df["longitude"]), 6),
+ round_floats(series_to_list(lonlat_df["longitude"]), 6),
+ )
+ self.assertListEqual(
+ round_floats(series_to_list(post_df["latitude"]), 6),
+ round_floats(series_to_list(lonlat_df["latitude"]), 6),
+ )
+
+ def test_geohash_encode(self):
+ # encode lon/lat into geohash
+ post_df = proc.geohash_encode(
+ df=lonlat_df[["city", "latitude", "longitude"]],
+ latitude="latitude",
+ longitude="longitude",
+ geohash="geohash",
+ )
+ self.assertListEqual(
+ sorted(post_df.columns.tolist()),
+ sorted(["city", "geohash", "latitude", "longitude"]),
+ )
+ self.assertListEqual(
+ series_to_list(post_df["geohash"]), series_to_list(lonlat_df["geohash"]),
+ )
+
+ def geodetic_parse(self):
Review comment:
rename to: `def test_geodetic_parse`
##########
File path: superset/charts/schemas.py
##########
@@ -335,12 +343,81 @@ class ChartDataPivotOptionsSchema(ChartDataPostProcessingOperationOptionsSchema)
aggregates = ChartDataAggregateConfigField()
+class ChartDataGeohashDecodeOptionsSchema(
+ ChartDataPostProcessingOperationOptionsSchema
+):
+ """
+ Geohash decode operation config.
+ """
+
+ geohash = fields.String(
+ description="Name of source column containing geohash string", required=True,
+ )
+ latitude = fields.String(
+ description="Name of target column for decoded latitude", required=True,
+ )
+ longitude = fields.String(
+ description="Name of target column for decoded longitude", required=True,
+ )
+
+
+class ChartDataGeohashEncodeOptionsSchema(
+ ChartDataPostProcessingOperationOptionsSchema
+):
+ """
+ Geohash encode operation config.
+ """
+
+ latitude = fields.String(
+ description="Name of source latitude column", required=True,
+ )
+ longitude = fields.String(
+ description="Name of source longitude column", required=True,
+ )
+ geohash = fields.String(
+ description="Name of target column for encoded geohash string", required=True,
+ )
+
+
+class ChartDataGeodeticParseOptionsSchema(
+ ChartDataPostProcessingOperationOptionsSchema
+):
+ """
+ Geodetic point string parsing operation config.
+ """
+
+ geodetic = fields.String(
+ description="Name of source column containing geodetic point strings",
+ required=True,
+ )
+ latitude = fields.String(
+ description="Name of target column for decoded latitude", required=True,
+ )
+ longitude = fields.String(
+ description="Name of target column for decoded longitude", required=True,
+ )
+ altitude = fields.String(
+ description="Name of target column for decoded longitude. If omitted, "
Review comment:
`Name of target column for decoded altitude`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `1.61%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 65.64% +1.61%
==========================================
Files 532 581 +49
Lines 28897 30262 +1365
Branches 2758 3071 +313
==========================================
+ Hits 18503 19867 +1364
- Misses 10211 10214 +3
+ Partials 183 181 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.74% <ø> (?)` | |
| #python | `70.48% <63.63%> (-0.09%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `80.45% <48.38%> (-9.85%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [274 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...91de731](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 64.05% +0.02%
==========================================
Files 532 532
Lines 28897 28966 +69
Branches 2758 2758
==========================================
+ Hits 18503 18553 +50
- Misses 10211 10230 +19
Partials 183 183
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (-0.01%)` | :arrow_down: |
| #python | `70.57% <88.23%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <83.78%> (-1.98%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `87.74% <0.00%> (-0.77%)` | :arrow_down: |
| [...rset-frontend/src/components/StackTraceMessage.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3RhY2tUcmFjZU1lc3NhZ2UuanN4) | | |
| [...tend/src/components/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlV2l0aFN0YWNrVHJhY2UudHN4) | `0.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.33% <0.00%> (+0.08%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...186a1b2](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-620376742
@ktmud in reference to your comment on #9427 , I'll add the rename change here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.48%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.51% +6.48%
==========================================
Files 532 581 +49
Lines 28897 30262 +1365
Branches 2758 3071 +313
==========================================
+ Hits 18503 21340 +2837
+ Misses 10211 8811 -1400
+ Partials 183 111 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.72% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `58.74% <ø> (?)` | |
| #python | `70.57% <63.63%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `80.45% <48.38%> (-9.85%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `7.27% <0.00%> (-92.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (-2.79%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | `100.00% <0.00%> (ø)` | |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...91de731](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 64.08% +0.05%
==========================================
Files 532 532
Lines 28897 28966 +69
Branches 2758 2758
==========================================
+ Hits 18503 18564 +61
- Misses 10211 10219 +8
Partials 183 183
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (-0.01%)` | :arrow_down: |
| #python | `70.63% <88.23%> (+0.06%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <83.78%> (-1.98%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [...rset-frontend/src/components/StackTraceMessage.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3RhY2tUcmFjZU1lc3NhZ2UuanN4) | | |
| [...tend/src/components/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlV2l0aFN0YWNrVHJhY2UudHN4) | `0.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.33% <0.00%> (+0.08%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.79% <0.00%> (+0.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...186a1b2](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.41% +6.38%
==========================================
Files 532 399 -133
Lines 28897 12469 -16428
Branches 2758 3078 +320
==========================================
- Hits 18503 8780 -9723
+ Misses 10211 3577 -6634
+ Partials 183 112 -71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `58.75% <ø> (?)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `7.27% <0.00%> (-92.73%)` | :arrow_down: |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (-2.79%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | `100.00% <0.00%> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | | |
| [superset/charts/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | | |
| [superset/stats\_logger.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3RhdHNfbG9nZ2VyLnB5) | | |
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | | |
| ... and [356 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...7419861](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **decrease** coverage by `5.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
- Coverage 64.03% 58.74% -5.29%
==========================================
Files 532 399 -133
Lines 28897 12464 -16433
Branches 2758 3071 +313
==========================================
- Hits 18503 7322 -11181
+ Misses 10211 4961 -5250
+ Partials 183 181 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.74% <ø> (?)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...91de731](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
- Coverage 64.03% 63.73% -0.30%
==========================================
Files 532 532
Lines 28897 28966 +69
Branches 2758 2758
==========================================
- Hits 18503 18461 -42
- Misses 10211 10311 +100
- Partials 183 194 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.82% <ø> (-0.84%)` | :arrow_down: |
| #python | `70.57% <88.23%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <83.78%> (-1.98%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `50.00% <0.00%> (-14.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `49.65% <0.00%> (-9.10%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `17.24% <0.00%> (-8.52%)` | :arrow_down: |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `46.26% <0.00%> (-5.98%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `42.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...186a1b2](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `5.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 69.89% +5.86%
==========================================
Files 532 399 -133
Lines 28897 12469 -16428
Branches 2758 3078 +320
==========================================
- Hits 18503 8715 -9788
+ Misses 10211 3635 -6576
+ Partials 183 119 -64
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.83% <ø> (-0.83%)` | :arrow_down: |
| #javascript | `58.75% <ø> (?)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `7.27% <0.00%> (-92.73%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (-2.79%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-2.00%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | `100.00% <0.00%> (ø)` | |
| [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | | |
| ... and [358 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...7419861](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#discussion_r416672053
##########
File path: tests/pandas_postprocessing_tests.py
##########
@@ -288,3 +316,83 @@ def test_cum(self):
columns={"y": "y"},
operator="abc",
)
+
+ def test_geohash_decode(self):
+ # decode lon/lat from geohash
+ post_df = proc.geohash_decode(
+ df=lonlat_df[["city", "geohash"]],
+ geohash="geohash",
+ latitude="latitude",
+ longitude="longitude",
+ )
+ self.assertListEqual(
+ sorted(post_df.columns.tolist()),
+ sorted(["city", "geohash", "latitude", "longitude"]),
+ )
+ self.assertListEqual(
+ round_floats(series_to_list(post_df["longitude"]), 6),
+ round_floats(series_to_list(lonlat_df["longitude"]), 6),
+ )
+ self.assertListEqual(
+ round_floats(series_to_list(post_df["latitude"]), 6),
+ round_floats(series_to_list(lonlat_df["latitude"]), 6),
+ )
+
+ def test_geohash_encode(self):
+ # encode lon/lat into geohash
+ post_df = proc.geohash_encode(
+ df=lonlat_df[["city", "latitude", "longitude"]],
+ latitude="latitude",
+ longitude="longitude",
+ geohash="geohash",
+ )
+ self.assertListEqual(
+ sorted(post_df.columns.tolist()),
+ sorted(["city", "geohash", "latitude", "longitude"]),
+ )
+ self.assertListEqual(
+ series_to_list(post_df["geohash"]), series_to_list(lonlat_df["geohash"]),
+ )
+
+ def geodetic_parse(self):
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.26%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.29% +6.26%
==========================================
Files 532 581 +49
Lines 28897 30262 +1365
Branches 2758 3071 +313
==========================================
+ Hits 18503 21272 +2769
+ Misses 10211 8872 -1339
+ Partials 183 118 -65
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.83% <ø> (-0.83%)` | :arrow_down: |
| #javascript | `58.74% <ø> (?)` | |
| #python | `70.57% <63.63%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `80.45% <48.38%> (-9.85%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `7.27% <0.00%> (-92.73%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (-2.79%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-2.00%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...91de731](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.51%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
+ Coverage 64.03% 70.54% +6.51%
==========================================
Files 532 581 +49
Lines 28897 30272 +1375
Branches 2758 3072 +314
==========================================
+ Hits 18503 21355 +2852
+ Misses 10211 8805 -1406
+ Partials 183 112 -71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (-0.01%)` | :arrow_down: |
| #javascript | `58.75% <ø> (?)` | |
| #python | `70.63% <88.23%> (+0.06%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <83.78%> (-1.98%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `7.27% <0.00%> (-92.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (-2.79%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/StackTraceMessage.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3RhY2tUcmFjZU1lc3NhZ2UuanN4) | | |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...186a1b2](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-619991131
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=h1) Report
> Merging [#9661](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **decrease** coverage by `5.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9661 +/- ##
==========================================
- Coverage 64.03% 58.75% -5.28%
==========================================
Files 532 399 -133
Lines 28897 12469 -16428
Branches 2758 3078 +320
==========================================
- Hits 18503 7326 -11177
+ Misses 10211 4961 -5250
+ Partials 183 182 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.75% <ø> (?)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [444 more](https://codecov.io/gh/apache/incubator-superset/pull/9661/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=footer). Last update [5e4c291...7419861](https://codecov.io/gh/apache/incubator-superset/pull/9661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9661: feat: Add geospatial post processing operations
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#issuecomment-620652274
Thanks for the valuable comments @dpgaspar !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org