[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #4013: Support SubqueryAlias wrap filter.

[GitBox <gi...@apache.org>]

Dandandan commented on code in PR #4013:
URL: https://github.com/apache/arrow-datafusion/pull/4013#discussion_r1008711121


##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -1013,7 +1013,10 @@ impl DefaultPhysicalPlanner {
                         LogicalPlan::TableScan(..) => {
                             self.create_initial_plan(input, session_state).await
                         }
-                        _ => Err(DataFusionError::Plan("SubqueryAlias should only wrap TableScan".to_string()))
+                        LogicalPlan::Filter(..) => {
+                            self.create_initial_plan(input, session_state).await
+                        }
+                        _ => Err(DataFusionError::Plan("SubqueryAlias should only wrap TableScan or Filter".to_string()))

Review Comment:
   Ideally we should be able to support wrapping any plan in a subquery with alias (this could also simplify some planning code).
   But I got some errors trying this before.
   https://github.com/apache/arrow-datafusion/issues/3927



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org