You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/05/23 08:53:13 UTC

Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59486/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1605
    https://issues.apache.org/jira/browse/RANGER-1605


Repository: ranger


Description
-------

These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin. We should remove them to keep the code valid.


Diffs
-----

  security-admin/scripts/db_setup.py b5ab132 


Diff: https://reviews.apache.org/r/59486/diff/1/


Testing
-------


Thanks,

pengjianhua

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59486/#review175887
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On 五月 23, 2017, 8:53 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59486/
> -----------------------------------------------------------
> 
> (Updated 五月 23, 2017, 8:53 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1605
>     https://issues.apache.org/jira/browse/RANGER-1605
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin. We should remove them to keep the code valid.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py b5ab132 
> 
> 
> Diff: https://reviews.apache.org/r/59486/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

Posted by pengjianhua <pe...@zte.com.cn>.

> On 五月 23, 2017, 9:05 a.m., Colm O hEigeartaigh wrote:
> > Could you describe why they are invalid?

className = re.match("(Patch.*?)_.*.class",filename)
className = className.group(1)
The className variable is not used in the current loop. This segment code is copied from other places. These extra code has not been deleted.


- pengjianhua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59486/#review175773
-----------------------------------------------------------


On 五月 23, 2017, 8:53 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59486/
> -----------------------------------------------------------
> 
> (Updated 五月 23, 2017, 8:53 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1605
>     https://issues.apache.org/jira/browse/RANGER-1605
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin. We should remove them to keep the code valid.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py b5ab132 
> 
> 
> Diff: https://reviews.apache.org/r/59486/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59486/#review175773
-----------------------------------------------------------



Could you describe why they are invalid?

- Colm O hEigeartaigh


On May 23, 2017, 8:53 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59486/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 8:53 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1605
>     https://issues.apache.org/jira/browse/RANGER-1605
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin. We should remove them to keep the code valid.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py b5ab132 
> 
> 
> Diff: https://reviews.apache.org/r/59486/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59486/#review175784
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 23, 2017, 8:53 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59486/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 8:53 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1605
>     https://issues.apache.org/jira/browse/RANGER-1605
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin. We should remove them to keep the code valid.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py b5ab132 
> 
> 
> Diff: https://reviews.apache.org/r/59486/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>