You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Vincent Massol (JIRA)" <ji...@codehaus.org> on 2005/10/28 21:56:11 UTC

[jira] Created: (MNG-1356) Java system properties should be interpolated in pom.xml

Java system properties should be interpolated in pom.xml
--------------------------------------------------------

         Key: MNG-1356
         URL: http://jira.codehaus.org/browse/MNG-1356
     Project: Maven 2
        Type: Improvement
  Components: maven-core  
    Versions: 2.0    
 Reporter: Vincent Massol


Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:

Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1356?page=all ]
     
Brett Porter closed MNG-1356:
-----------------------------

     Resolution: Won't Fix
    Fix Version:     (was: 2.0.1)

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>     Assignee: Edwin Punzalan

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1356?page=comments#action_50729 ] 

Edwin Punzalan commented on MNG-1356:
-------------------------------------

This pom is what I used to try it: 

<project> 
  <modelVersion>4.0.0</modelVersion> 
  <groupId>test</groupId> 
  <artifactId>a</artifactId> 
  <version>1.0</version> 
  <packaging>jar</packaging> 
  <name>a test</name>
  <dependencies>
    <dependency>
      <groupId>test</groupId>
      <artifactId>test</artifactId>
      <version>1.0-${java.io.tmpdir}</version>
    </dependency>
  </dependencies>
</project>


Also, I tried using: System.getProperties().list(System.out) and found only java.io.tmpdir, no java.io.tmp.dir.  Maybe its something jdk specific. I'm using 1.4.2_07

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>     Assignee: Edwin Punzalan
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1356?page=comments#action_50255 ] 

John Casey commented on MNG-1356:
---------------------------------

are these containers artifacts that could be resolved as part of a plugin-dependency? That is to say, could you do:

<build>
  <plugins>
    <plugin>
      <groupId/>
      <artifactId>cargo-maven-plugin</artifactId>
      <dependencies>
        <dependency>
          <groupId/>
          <artifactId>tomcat</artifactId>
          <version>5.0</version>
        </dependency>
      </dependencies>
    </plugin>
  </plugins>
</build>

Or are you downloading the stock binaries for these containers?

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1356?page=comments#action_50664 ] 

Edwin Punzalan commented on MNG-1356:
-------------------------------------

This is already implemented and should be closed. All values in System.getProperties() can be interpolated into pom.xml.

btw, its "java.io.tmpdir" not "java.io.tmp.dir".  Maybe that's the reason why you can't get it interpolated?

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Reopened: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1356?page=all ]
     
Brett Porter reopened MNG-1356:
-------------------------------


> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>     Assignee: Edwin Punzalan
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1356?page=all ]
     
Vincent Massol closed MNG-1356:
-------------------------------

    Resolution: Won't Fix

Stupid me! I should have read better what you said Edwin. I thought you said I should use java.io.tmp.dir instead of java.io.tmpdir but that was actually the opposite. Please accept my apologies and thanks again for your help. It's working fine.

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>     Assignee: Edwin Punzalan
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1356?page=all ]

Brett Porter updated MNG-1356:
------------------------------

    Description: 
Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:

Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).



  was:
Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:

Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).



    Fix Version: 2.0.1
    Environment: 

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1356?page=comments#action_50256 ] 

John Casey commented on MNG-1356:
---------------------------------

Alternately, if your plugin is downloading the containers, can't you simply use a plugin configuration that specifies ${java.io.tmp.dir} as the value? IIRC, the parameter expression evaluator should look it up from the sysprops. If not, that's a problem...

My tendency would be to say that you'd be introducing a bad source of variability to your POM if you could do:

<project>
  ...
  <version>${user.home}</version>
  ...
</project>

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1356?page=comments#action_50276 ] 

Vincent Massol commented on MNG-1356:
-------------------------------------

Hi John,

Yes, it's Cargo which is downloading the container distribution.

Using a plugin configuration is exactly what I'm after but it wasn't working when I tried it. Here's an example of the POM I would like to have:

    <plugins>
      <plugin>
        <groupId>org.codehaus.cargo.maven2</groupId>
        <artifactId>cargo-maven2-plugin</artifactId>
        <configuration>
          <wait>true</wait>
          <container>
            <containerId>${containerId}</containerId>
            <log>${basedir}/target/${containerId}/cargo.log</log>
            <zipUrlInstaller>
              <url>${downloadUrl}</url>
              <installDir>${java.io.tmp.dir}/cargo</installDir>
            </zipUrlInstaller>
          </container>
          <configuration>
            <dir>${basedir}/target/${containerId}/container</dir>
            <properties>
              <property>
                <name>cargo.servlet.port</name>
                <value>${port}</value>
              </property>
              <property>
                <name>cargo.logging</name>
                <value>high</value>
              </property>
            </properties>
          </configuration>
        </configuration>
      </plugin>
    </plugins>
[...]

Thanks

> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1356) Java system properties should be interpolated in pom.xml

Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1356?page=comments#action_50680 ] 

Vincent Massol commented on MNG-1356:
-------------------------------------

Hi Edwin,

I have correctly used java.io.tmp.dir (as shown above in the config). I have just tried again and once more I got a null.

Do you have an IT test for this that I could look at?


> Java system properties should be interpolated in pom.xml
> --------------------------------------------------------
>
>          Key: MNG-1356
>          URL: http://jira.codehaus.org/browse/MNG-1356
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-core
>     Versions: 2.0
>     Reporter: Vincent Massol
>     Assignee: Edwin Punzalan
>      Fix For: 2.0.1

>
>
> Here's a use case where I'd need ${java.io.tmp.dir} interpolated in my pom.xml:
> Some plugins output things. Some of those things can be transient and putting them in ${basedir]/target is fine. However there are other cases where you want to be sure that what is generated stays even after a clean. This is the case for the cargo plugin which can automatically download containers. It wouldn't be nice that the downloaded containers be wiped out on a clean. I'd like to leave it to the user to decide where to put them and one location that would be fine is ${java.io.tmp.dir} (this is the one I want to use in the cargo plugin's functional tests).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org