You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:27:56 UTC

[GitHub] [flink] zentol commented on pull request #11056: [FLINK-15903][e2e] Make REST port configurable

zentol commented on pull request #11056:
URL: https://github.com/apache/flink/pull/11056#issuecomment-626644681


   > Is there something that needs to be changed in the java based e2e test framework?
   
   Several things actually; the `LocalStandaloneFlinkResource` assumes that Flink runs on port 8081, just like the `FlinkDistribution` and `MetricsAvailabilityITCase`.
   
   So, the `FlinkDistribution#startFlinkCluster` should be reduced to calling `start-cluster.sh`; there is no way to reliably determine which port it should query since this class is ultimately stateless, and it is the responsibility of the `FlinkResource` anyway to ensure the cluster is actually started.
   `LocalStandaloneFlinkResource` can determine the port from the given configuration, and can assume it to be 8081 by default.
   As for `MetricsAvailabilityITCase`, we're probably looking at extensions to the `ClusterController` for retrieving metrics, which would internally rely on the logic in the FlinkResource.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org