You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Matthew Imrie (JIRA)" <ji...@apache.org> on 2013/05/02 21:06:15 UTC

[jira] [Updated] (THRIFT-1957) NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned

     [ https://issues.apache.org/jira/browse/THRIFT-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Imrie updated THRIFT-1957:
----------------------------------

    Summary: NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned  (was: TFramedTransport and TBufferedTransport read bytes as unsigned)
    
> NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1957
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1957
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>    Affects Versions: 0.9
>         Environment: NodeJS 10.4, Thrift 0.9
>            Reporter: Matthew Imrie
>              Labels: patch
>         Attachments: nodejs-thrift-signed-byte-fix.patch
>
>
> Thrift for NodeJS is reading bytes as unsigned. The Apache Thrift specification describes them as signed. 
> I changed the readByte function in both TFramedTransport and TBufferedTransport to call a new readByte method in binary.js that properly converts to a signed byte. Unit test for the method is included in binary.test.js

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira