You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2019/01/18 05:56:35 UTC
[DISCUSS] Cordova-Android Release
Does anyone have any reason to delay a cordova-android platform release?
Any outstanding patches to land?
If not, I will start the release process shortly.
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
Agreed on my part, please go ahead with the VOTE.
No other objections have been forthcoming over the past 1-2 days, so I
don't see any more reason to block it.
On Tue, Feb 12, 2019, 10:03 PM Bryan Ellis <erisu@apache.org wrote:
> Thank you, Brody, for your investigation into the build configuration and
> quick fixes to get the repo releasable.
>
> For the follow-up items.
> * Documentation is not a blocker for the cordova-android repo release as
> the docs are in cordova-docs. It is though recommended to be updated so we
> can quickly cut the doc release when we reach that stage.
>
> * Deprecate android-targetSdkVersion, android-maxSdkVersion, and other
> related items in config.xml.
>
> The last PR we just merged in uses android-targetSdkVersion from
> config.xml to set the cdvTargetSdkVersion.
>
> I think, for now, we should not add any messages. Let's open a new
> discussion thread and/or apache/cordova issue to track this discussion.
> There are many ideas on improving the build configuration (gradle) that
> even leads down to the Cordova side for passing variables. Some have
> already even start to cleanup this area locally. So I think we should
> discuss this but outside of this release.
>
> I think we can continue with the release. In fact, I am ready to push the
> VOTE. :)
>
>
>
>
> From: Brody Chris <ch...@gmail.com>
> Reply: dev@cordova.apache.org <de...@cordova.apache.org>
> Date: February 13, 2019 at 10:39:00
> To: dev@cordova.apache.org <de...@cordova.apache.org>
> Subject: Re: [DISCUSS] Cordova-Android Release
>
> A couple followup items:
> * I suspect we should update the documentation as well
> * I think it would be good if we could deprecate
> android-targetSdkVersion, android-maxSdkVersion, and maybe some
> related items in config.xml, as I had loosely implied on GitHub. I
> wonder if we want to add the deprecation message before cutting the
> major release.
>
> I think there is no need to hold up cordova-android release for
> AndroidX testing, as I said earlier, would love confirmation from
> Julio.
>
> Thanks Bryan for your efforts!
>
> On Tue, Feb 12, 2019 at 6:57 PM Chris Brody <ch...@gmail.com>
> wrote:
> >
> > I will revert the breaking change from PR #664 and finish PR #665 then.
> >
> > On Tue, Feb 12, 2019 at 6:50 PM Bryan Ellis <er...@apache.org> wrote:
> > >
> > > I also agree.
> > >
> > > Since it seems everyone has limited time, I recommend that we revert
> the breaking change and merge in the PR that has the limited scope change
> and resolves the main issues that most people face.
> > >
> > > Just test to make sure that the other WIP change is OK.
> > >
> > > After release, we can return at any time and clean up the build
> configurations.
> > >
> > > I know there is a lot to do, but we can do another major release. I
> believe there are no rules preventing us from releasing a major shortly
> after another.
> > >
> > > This major already introduces a lot of awaited features such as
> Android P support, Adaptive Icons, and much more.
> > >
> > >
> > >
> > > From: Brody Chris <ch...@gmail.com>
> > > Reply: dev@cordova.apache.org <de...@cordova.apache.org>
> > > Date: February 13, 2019 at 8:13:23
> > > To: dev@cordova.apache.org <de...@cordova.apache.org>
> > > Subject: Re: [DISCUSS] Cordova-Android Release
> > >
> > > I would definitely agree that we should do it right and get rid of
> > > project.properties, along with the other Eclipse artifacts. I already
> > > raised issues on GitHub to get rid of project.properties and other
> > > artifacts from Eclipse.
> > >
> > > I think none of us have the extra time to go through the needed
> > > cleanup, that is why I would favor the compromise solution that I
> > > proposed. (Quick solution would be to revert a recent change, which
> > > would both be ugly and reintroduce a known issue.)
> > >
> > > I think the root cause of our troubles with Android SDK versions has
> > > been the complexity of the build scripts, I just raised
> > > https://github.com/apache/cordova-android/issues/667 to clean it up.
> > >
> > > I hope we can find a good way to unblock and finish the long awaited
> > > major release.
> > >
> > > On Tue, Feb 12, 2019 at 5:50 PM Darryl Pogue <dv...@gmail.com>
> wrote:
> > > >
> > > > On Tue, Feb 12, 2019 at 2:47 PM Chris Brody <ch...@gmail.com>
> wrote:
> > > > > [...]
> > > > > The easy solution to bug 666 would be to revert PR 664, which
> would
> > > > > consequently reintroduce cordova-android bug 629. I would favor
> > > > > resolving it by reading the default targetSdkVersion value from
> > > > > project.properties, as briefly discussed on GitHub.
> > > >
> > > > Ideally we'd set it in settings.gradle and get rid of
> > > > project.properties entirely :\
> > > >
> > > > Unfortunately, I don't have capacity to pick anything up at the
> moment.
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [DISCUSS] Cordova-Android Release
Posted by Bryan Ellis <er...@apache.org>.
Thank you, Brody, for your investigation into the build configuration and quick fixes to get the repo releasable.
For the follow-up items.
* Documentation is not a blocker for the cordova-android repo release as the docs are in cordova-docs. It is though recommended to be updated so we can quickly cut the doc release when we reach that stage.
* Deprecate android-targetSdkVersion, android-maxSdkVersion, and other related items in config.xml.
The last PR we just merged in uses android-targetSdkVersion from config.xml to set the cdvTargetSdkVersion.
I think, for now, we should not add any messages. Let's open a new discussion thread and/or apache/cordova issue to track this discussion. There are many ideas on improving the build configuration (gradle) that even leads down to the Cordova side for passing variables. Some have already even start to cleanup this area locally. So I think we should discuss this but outside of this release.
I think we can continue with the release. In fact, I am ready to push the VOTE. :)
From: Brody Chris <ch...@gmail.com>
Reply: dev@cordova.apache.org <de...@cordova.apache.org>
Date: February 13, 2019 at 10:39:00
To: dev@cordova.apache.org <de...@cordova.apache.org>
Subject: Re: [DISCUSS] Cordova-Android Release
A couple followup items:
* I suspect we should update the documentation as well
* I think it would be good if we could deprecate
android-targetSdkVersion, android-maxSdkVersion, and maybe some
related items in config.xml, as I had loosely implied on GitHub. I
wonder if we want to add the deprecation message before cutting the
major release.
I think there is no need to hold up cordova-android release for
AndroidX testing, as I said earlier, would love confirmation from
Julio.
Thanks Bryan for your efforts!
On Tue, Feb 12, 2019 at 6:57 PM Chris Brody <ch...@gmail.com> wrote:
>
> I will revert the breaking change from PR #664 and finish PR #665 then.
>
> On Tue, Feb 12, 2019 at 6:50 PM Bryan Ellis <er...@apache.org> wrote:
> >
> > I also agree.
> >
> > Since it seems everyone has limited time, I recommend that we revert the breaking change and merge in the PR that has the limited scope change and resolves the main issues that most people face.
> >
> > Just test to make sure that the other WIP change is OK.
> >
> > After release, we can return at any time and clean up the build configurations.
> >
> > I know there is a lot to do, but we can do another major release. I believe there are no rules preventing us from releasing a major shortly after another.
> >
> > This major already introduces a lot of awaited features such as Android P support, Adaptive Icons, and much more.
> >
> >
> >
> > From: Brody Chris <ch...@gmail.com>
> > Reply: dev@cordova.apache.org <de...@cordova.apache.org>
> > Date: February 13, 2019 at 8:13:23
> > To: dev@cordova.apache.org <de...@cordova.apache.org>
> > Subject: Re: [DISCUSS] Cordova-Android Release
> >
> > I would definitely agree that we should do it right and get rid of
> > project.properties, along with the other Eclipse artifacts. I already
> > raised issues on GitHub to get rid of project.properties and other
> > artifacts from Eclipse.
> >
> > I think none of us have the extra time to go through the needed
> > cleanup, that is why I would favor the compromise solution that I
> > proposed. (Quick solution would be to revert a recent change, which
> > would both be ugly and reintroduce a known issue.)
> >
> > I think the root cause of our troubles with Android SDK versions has
> > been the complexity of the build scripts, I just raised
> > https://github.com/apache/cordova-android/issues/667 to clean it up.
> >
> > I hope we can find a good way to unblock and finish the long awaited
> > major release.
> >
> > On Tue, Feb 12, 2019 at 5:50 PM Darryl Pogue <dv...@gmail.com> wrote:
> > >
> > > On Tue, Feb 12, 2019 at 2:47 PM Chris Brody <ch...@gmail.com> wrote:
> > > > [...]
> > > > The easy solution to bug 666 would be to revert PR 664, which would
> > > > consequently reintroduce cordova-android bug 629. I would favor
> > > > resolving it by reading the default targetSdkVersion value from
> > > > project.properties, as briefly discussed on GitHub.
> > >
> > > Ideally we'd set it in settings.gradle and get rid of
> > > project.properties entirely :\
> > >
> > > Unfortunately, I don't have capacity to pick anything up at the moment.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
A couple followup items:
* I suspect we should update the documentation as well
* I think it would be good if we could deprecate
android-targetSdkVersion, android-maxSdkVersion, and maybe some
related items in config.xml, as I had loosely implied on GitHub. I
wonder if we want to add the deprecation message before cutting the
major release.
I think there is no need to hold up cordova-android release for
AndroidX testing, as I said earlier, would love confirmation from
Julio.
Thanks Bryan for your efforts!
On Tue, Feb 12, 2019 at 6:57 PM Chris Brody <ch...@gmail.com> wrote:
>
> I will revert the breaking change from PR #664 and finish PR #665 then.
>
> On Tue, Feb 12, 2019 at 6:50 PM Bryan Ellis <er...@apache.org> wrote:
> >
> > I also agree.
> >
> > Since it seems everyone has limited time, I recommend that we revert the breaking change and merge in the PR that has the limited scope change and resolves the main issues that most people face.
> >
> > Just test to make sure that the other WIP change is OK.
> >
> > After release, we can return at any time and clean up the build configurations.
> >
> > I know there is a lot to do, but we can do another major release. I believe there are no rules preventing us from releasing a major shortly after another.
> >
> > This major already introduces a lot of awaited features such as Android P support, Adaptive Icons, and much more.
> >
> >
> >
> > From: Brody Chris <ch...@gmail.com>
> > Reply: dev@cordova.apache.org <de...@cordova.apache.org>
> > Date: February 13, 2019 at 8:13:23
> > To: dev@cordova.apache.org <de...@cordova.apache.org>
> > Subject: Re: [DISCUSS] Cordova-Android Release
> >
> > I would definitely agree that we should do it right and get rid of
> > project.properties, along with the other Eclipse artifacts. I already
> > raised issues on GitHub to get rid of project.properties and other
> > artifacts from Eclipse.
> >
> > I think none of us have the extra time to go through the needed
> > cleanup, that is why I would favor the compromise solution that I
> > proposed. (Quick solution would be to revert a recent change, which
> > would both be ugly and reintroduce a known issue.)
> >
> > I think the root cause of our troubles with Android SDK versions has
> > been the complexity of the build scripts, I just raised
> > https://github.com/apache/cordova-android/issues/667 to clean it up.
> >
> > I hope we can find a good way to unblock and finish the long awaited
> > major release.
> >
> > On Tue, Feb 12, 2019 at 5:50 PM Darryl Pogue <dv...@gmail.com> wrote:
> > >
> > > On Tue, Feb 12, 2019 at 2:47 PM Chris Brody <ch...@gmail.com> wrote:
> > > > [...]
> > > > The easy solution to bug 666 would be to revert PR 664, which would
> > > > consequently reintroduce cordova-android bug 629. I would favor
> > > > resolving it by reading the default targetSdkVersion value from
> > > > project.properties, as briefly discussed on GitHub.
> > >
> > > Ideally we'd set it in settings.gradle and get rid of
> > > project.properties entirely :\
> > >
> > > Unfortunately, I don't have capacity to pick anything up at the moment.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I will revert the breaking change from PR #664 and finish PR #665 then.
On Tue, Feb 12, 2019 at 6:50 PM Bryan Ellis <er...@apache.org> wrote:
>
> I also agree.
>
> Since it seems everyone has limited time, I recommend that we revert the breaking change and merge in the PR that has the limited scope change and resolves the main issues that most people face.
>
> Just test to make sure that the other WIP change is OK.
>
> After release, we can return at any time and clean up the build configurations.
>
> I know there is a lot to do, but we can do another major release. I believe there are no rules preventing us from releasing a major shortly after another.
>
> This major already introduces a lot of awaited features such as Android P support, Adaptive Icons, and much more.
>
>
>
> From: Brody Chris <ch...@gmail.com>
> Reply: dev@cordova.apache.org <de...@cordova.apache.org>
> Date: February 13, 2019 at 8:13:23
> To: dev@cordova.apache.org <de...@cordova.apache.org>
> Subject: Re: [DISCUSS] Cordova-Android Release
>
> I would definitely agree that we should do it right and get rid of
> project.properties, along with the other Eclipse artifacts. I already
> raised issues on GitHub to get rid of project.properties and other
> artifacts from Eclipse.
>
> I think none of us have the extra time to go through the needed
> cleanup, that is why I would favor the compromise solution that I
> proposed. (Quick solution would be to revert a recent change, which
> would both be ugly and reintroduce a known issue.)
>
> I think the root cause of our troubles with Android SDK versions has
> been the complexity of the build scripts, I just raised
> https://github.com/apache/cordova-android/issues/667 to clean it up.
>
> I hope we can find a good way to unblock and finish the long awaited
> major release.
>
> On Tue, Feb 12, 2019 at 5:50 PM Darryl Pogue <dv...@gmail.com> wrote:
> >
> > On Tue, Feb 12, 2019 at 2:47 PM Chris Brody <ch...@gmail.com> wrote:
> > > [...]
> > > The easy solution to bug 666 would be to revert PR 664, which would
> > > consequently reintroduce cordova-android bug 629. I would favor
> > > resolving it by reading the default targetSdkVersion value from
> > > project.properties, as briefly discussed on GitHub.
> >
> > Ideally we'd set it in settings.gradle and get rid of
> > project.properties entirely :\
> >
> > Unfortunately, I don't have capacity to pick anything up at the moment.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Bryan Ellis <er...@apache.org>.
I also agree.
Since it seems everyone has limited time, I recommend that we revert the breaking change and merge in the PR that has the limited scope change and resolves the main issues that most people face.
Just test to make sure that the other WIP change is OK.
After release, we can return at any time and clean up the build configurations.
I know there is a lot to do, but we can do another major release. I believe there are no rules preventing us from releasing a major shortly after another.
This major already introduces a lot of awaited features such as Android P support, Adaptive Icons, and much more.
From: Brody Chris <ch...@gmail.com>
Reply: dev@cordova.apache.org <de...@cordova.apache.org>
Date: February 13, 2019 at 8:13:23
To: dev@cordova.apache.org <de...@cordova.apache.org>
Subject: Re: [DISCUSS] Cordova-Android Release
I would definitely agree that we should do it right and get rid of
project.properties, along with the other Eclipse artifacts. I already
raised issues on GitHub to get rid of project.properties and other
artifacts from Eclipse.
I think none of us have the extra time to go through the needed
cleanup, that is why I would favor the compromise solution that I
proposed. (Quick solution would be to revert a recent change, which
would both be ugly and reintroduce a known issue.)
I think the root cause of our troubles with Android SDK versions has
been the complexity of the build scripts, I just raised
https://github.com/apache/cordova-android/issues/667 to clean it up.
I hope we can find a good way to unblock and finish the long awaited
major release.
On Tue, Feb 12, 2019 at 5:50 PM Darryl Pogue <dv...@gmail.com> wrote:
>
> On Tue, Feb 12, 2019 at 2:47 PM Chris Brody <ch...@gmail.com> wrote:
> > [...]
> > The easy solution to bug 666 would be to revert PR 664, which would
> > consequently reintroduce cordova-android bug 629. I would favor
> > resolving it by reading the default targetSdkVersion value from
> > project.properties, as briefly discussed on GitHub.
>
> Ideally we'd set it in settings.gradle and get rid of
> project.properties entirely :\
>
> Unfortunately, I don't have capacity to pick anything up at the moment.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I would definitely agree that we should do it right and get rid of
project.properties, along with the other Eclipse artifacts. I already
raised issues on GitHub to get rid of project.properties and other
artifacts from Eclipse.
I think none of us have the extra time to go through the needed
cleanup, that is why I would favor the compromise solution that I
proposed. (Quick solution would be to revert a recent change, which
would both be ugly and reintroduce a known issue.)
I think the root cause of our troubles with Android SDK versions has
been the complexity of the build scripts, I just raised
https://github.com/apache/cordova-android/issues/667 to clean it up.
I hope we can find a good way to unblock and finish the long awaited
major release.
On Tue, Feb 12, 2019 at 5:50 PM Darryl Pogue <dv...@gmail.com> wrote:
>
> On Tue, Feb 12, 2019 at 2:47 PM Chris Brody <ch...@gmail.com> wrote:
> > [...]
> > The easy solution to bug 666 would be to revert PR 664, which would
> > consequently reintroduce cordova-android bug 629. I would favor
> > resolving it by reading the default targetSdkVersion value from
> > project.properties, as briefly discussed on GitHub.
>
> Ideally we'd set it in settings.gradle and get rid of
> project.properties entirely :\
>
> Unfortunately, I don't have capacity to pick anything up at the moment.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Darryl Pogue <dv...@gmail.com>.
On Tue, Feb 12, 2019 at 2:47 PM Chris Brody <ch...@gmail.com> wrote:
> [...]
> The easy solution to bug 666 would be to revert PR 664, which would
> consequently reintroduce cordova-android bug 629. I would favor
> resolving it by reading the default targetSdkVersion value from
> project.properties, as briefly discussed on GitHub.
Ideally we'd set it in settings.gradle and get rid of
project.properties entirely :\
Unfortunately, I don't have capacity to pick anything up at the moment.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
We are now down to the following:
* https://github.com/apache/cordova-android/pull/655 for which I just
limited the scope as discussed on GitHub
* https://github.com/apache/cordova-android/issues/666 where I listed
some alternative solutions
The easy solution to bug 666 would be to revert PR 664, which would
consequently reintroduce cordova-android bug 629. I would favor
resolving it by reading the default targetSdkVersion value from
project.properties, as briefly discussed on GitHub.
I hope to get these items resolved soon. Unfortunately I cannot make
any promises due to some other priorities. I have already sacrificed
some my own priorities to close the gap on the new release, and this
is not the first time. I would be really grateful if anyone can help
or even take these items over. I would happy to provide some guidance
and answer any questions.
On Mon, Feb 11, 2019 at 9:19 PM Chris Brody <ch...@gmail.com> wrote:
>
> I think we are almost ready for cordova-andropid@8.0.0 release, should
> finish the following:
>
> * review and merge the following proposed PRs:
> - https://github.com/apache/cordova-android/pull/656
> - https://github.com/apache/cordova-android/pull/663
> - https://github.com/apache/cordova-android/pull/664
>
> * then I can go through the final testing and review of proposal in
> https://github.com/apache/cordova-android/pull/655
>
> On Fri, Feb 8, 2019 at 2:58 PM Chris Brody <ch...@gmail.com> wrote:
> >
> > I think it would be a pretty bad reflection on Apache Cordova if we
> > would announce a new release that is known to depend on deprecated
> > platform behavior. Not supporting AndroidX would be a prime example. I
> > think it would also be pretty bad if a bug such as bug 508 would be
> > introduced in the middle of the most recent release and not resolved
> > before we make a new major release.
> >
> > That said, I think we have determined on GitHub that there is no issue
> > with using cordova-android@8 (nightly) with AndroidX. The PSPDF team
> > reported that this is only an issue with our plugins. (And from a
> > quick scan I think the number of affected Apache Cordova plugins would
> > be very limited limited.) So I would conclude that the issue with
> > AndroidX should be blocking for Cordova CLI (and cordova-lib) but
> > **not** for cordova-android.
> >
> > I would personally favor making the new cordova-android release once
> > the following PRs are finished, reviewed, and merged:
> >
> > * https://github.com/apache/cordova-android/pull/655 - needs review
> > * https://github.com/apache/cordova-android/pull/656 - quick fix
> > proposal that I just made
> >
> > and less importantly:
> >
> > * https://github.com/apache/cordova-android/pull/642 - needs a review
> > before merging
> > * https://github.com/apache/cordova-android/pull/632 - needs a review
> > before merging
> >
> > I do think there are quite a few more issues that should be resolved
> > in a future cordova-android / Cordova CLI release. Yes we can always
> > make a new major release whenever it is needed.
> >
> > On Fri, Feb 8, 2019 at 6:59 AM Jan Piotrowski <pi...@gmail.com> wrote:
> > >
> > > Let me correct my question then:
> > > Why are those blocking and can not be added in a future major
> > > cordova-android release (with an accompanying CLI release that adds
> > > this as the new default android version to be installed if that is
> > > still necessary) when those changes are merged?
> > >
> > > -J
> > >
> > >
> > > Am Fr., 8. Feb. 2019 um 12:30 Uhr schrieb julio cesar sanchez
> > > <jc...@gmail.com>:
> > > >
> > > > Unless we find a way of enabling/disabling Android X support, it's going to
> > > > be a breaking change for all plugins using using the old way, so we can't
> > > > do that in a 8.1 release
> > > >
> > > > El vie., 8 feb. 2019 a las 12:03, Jan Piotrowski (<pi...@gmail.com>)
> > > > escribió:
> > > >
> > > > > I am not sure I follow:
> > > > > Why are those blocking and can not be added with a quick 8.1 when
> > > > > those changes are merged?
> > > > >
> > > > > -J
> > > > >
> > > > > Am Fr., 8. Feb. 2019 um 01:55 Uhr schrieb Chris Brody <
> > > > > chris.brody@gmail.com>:
> > > > > >
> > > > > > I think the major blockers are AndroidX and bug 508. I already
> > > > > > proposed a quick fix solution for 508. For AndroidX I think we need to
> > > > > > do a little more analysis and testing.
> > > > > >
> > > > > > Unfortunately I cannot promise much on my part due to some other
> > > > > > priorities. I will try to take another look in the next few days, no
> > > > > > guarantees though.
> > > > > >
> > > > > > On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <ch...@gmail.com>
> > > > > wrote:
> > > > > > >
> > > > > > > Update coming later today. I think there are still a number of
> > > > > > > blockers that we need to get resolved.
> > > > > > >
> > > > > > > On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com>
> > > > > wrote:
> > > > > > > >
> > > > > > > > Can I get an update on this?
> > > > > > > > Is there anyone still working on any blockers that need to be
> > > > > finished
> > > > > > > > before release?
> > > > > > > > Can we continue with this release?
> > > > > > > >
> > > > > > > >
> > > > > > > > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com>
> > > > > wrote:
> > > > > > > >
> > > > > > > > > I would agree with Julio that we should verify androidx support
> > > > > before we
> > > > > > > > > finish the next major release. I don't expect we will have to make
> > > > > any
> > > > > > > > > fixes on cordova-android for androidx support. Issues for
> > > > > reference:
> > > > > > > > > * https://github.com/apache/cordova/issues/69
> > > > > > > > > * https://github.com/apache/cordova-android/issues/565
> > > > > > > > >
> > > > > > > > > I just raised WIP PR
> > > > > https://github.com/apache/cordova-android/pull/633 to
> > > > > > > > > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> > > > > > > > >
> > > > > > > > > I think we should also try to resolve the following issues before
> > > > > the next
> > > > > > > > > major release:
> > > > > > > > > * https://github.com/apache/cordova-android/issues/629 - issue
> > > > > with
> > > > > > > > > Android
> > > > > > > > > Studio 3.2 & 3.3
> > > > > > > > > * https://github.com/apache/cordova-android/issues/623 - fix
> > > > > logging of
> > > > > > > > > Java version (a PR was already proposed)
> > > > > > > > >
> > > > > > > > > I think it would be nice but not absolutely necessary to resolve
> > > > > the
> > > > > > > > > following issue as well:
> > > > > > > > > * https://github.com/apache/cordova-android/issues/617 - support
> > > > > > > > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now
> > > > > deprecated
> > > > > > > > > * https://github.com/apache/cordova-android/issues/634 - update
> > > > > Gradle
> > > > > > > > > classpath for Android Studio 3.3
> > > > > > > > > * review & merge the following PRs:
> > > > > > > > > - https://github.com/apache/cordova-android/pull/632 - ignore
> > > > > more
> > > > > > > > > Gradle
> > > > > > > > > build artifacts in Android project
> > > > > > > > > - https://github.com/apache/cordova-android/pull/635 - ignore
> > > > > Android
> > > > > > > > > Studio .idea files in Android project
> > > > > > > > >
> > > > > > > > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > > > > > > > > jcesarmobile@gmail.com>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > As it's going to be a major release, I think we should look a
> > > > > bit more
> > > > > > > > > into
> > > > > > > > > > Android X before doing a major release, just in case we need to
> > > > > do major
> > > > > > > > > > changes.
> > > > > > > > > > In the issue related to Android X, I commented that we didn't
> > > > > have the
> > > > > > > > > > gradle.properties file, but in the linked PR I saw it's going to
> > > > > be
> > > > > > > > > > generated by the tooling now, so should be easier to just write
> > > > > to it
> > > > > > > > > with
> > > > > > > > > > whatever is needed, and probably make it opt-in for now as it's
> > > > > not clear
> > > > > > > > > > if using Android X will prevent old plugins from working.
> > > > > > > > > > Or is the gradle.properties file supposed to be managed by the
> > > > > user
> > > > > > > > > > somehow?
> > > > > > > > > >
> > > > > > > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<
> > > > > chris.brody@gmail.com>)
> > > > > > > > > > escribió:
> > > > > > > > > >
> > > > > > > > > > > I am investigating a quick solution for the bug, hope to have
> > > > > something
> > > > > > > > > > > today.
> > > > > > > > > > >
> > > > > > > > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <
> > > > > chris.brody@gmail.com
> > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > The bug was introduced by new code that was added to both
> > > > > master and
> > > > > > > > > > > 7.1.4.
> > > > > > > > > > > >
> > > > > > > > > > > > On 7.1.4 the issue is discussed in:
> > > > > > > > > > > > https://github.com/apache/cordova-android/issues/599
> > > > > > > > > > > >
> > > > > > > > > > > > I hope we can find a quick solution before we make the new
> > > > > release.
> > > > > > > > > > > >
> > > > > > > > > > > > Fixing the bug would introduce some kind of change in
> > > > > behavior, with
> > > > > > > > > a
> > > > > > > > > > > > possible risk that it would be a breaking change for someone
> > > > > else.
> > > > > > > > > > > >
> > > > > > > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <
> > > > > piotrowski@gmail.com
> > > > > > > > > >
> > > > > > > > > > > > wrote:
> > > > > > > > > > > >
> > > > > > > > > > > >> Is this a new bug introduced by the new code that would be
> > > > > released?
> > > > > > > > > > > >> If not, there is no reason to stop a release of that (good)
> > > > > code. As
> > > > > > > > > > > >> soon as a fix for this bug is available, we can release it
> > > > > as a
> > > > > > > > > follow
> > > > > > > > > > > >> up release (patch, minor, major - whatever appropriate).
> > > > > > > > > > > >>
> > > > > > > > > > > >> -J
> > > > > > > > > > > >>
> > > > > > > > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > > > > > > > > >> chris.brody@gmail.com>:
> > > > > > > > > > > >> >
> > > > > > > > > > > >> > I do not think we should make a new cordova-android
> > > > > release before
> > > > > > > > > > we
> > > > > > > > > > > >> can
> > > > > > > > > > > >> > resolve
> > > > > https://github.com/apache/cordova-android/issues/508
> > > > > > > > > > > >> >
> > > > > > > > > > > >> > I think it is a pretty bad bug. I would be happy to
> > > > > explain
> > > > > > > > > further
> > > > > > > > > > if
> > > > > > > > > > > >> > needed.
> > > > > > > > > > > >> >
> > > > > > > > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <
> > > > > erisu@apache.org>
> > > > > > > > > > > wrote:
> > > > > > > > > > > >> >
> > > > > > > > > > > >> > > Does anyone have any reason to delay a cordova-android
> > > > > platform
> > > > > > > > > > > >> release?
> > > > > > > > > > > >> > > Any outstanding patches to land?
> > > > > > > > > > > >> > >
> > > > > > > > > > > >> > > If not, I will start the release process shortly.
> > > > > > > > > > > >> > >
> > > > > > > > > > > >>
> > > > > > > > > > > >>
> > > > > > > > >
> > > > > ---------------------------------------------------------------------
> > > > > > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > > > > > > >> For additional commands, e-mail:
> > > > > dev-help@cordova.apache.org
> > > > > > > > > > > >>
> > > > > > > > > > > >>
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > >
> > > > > > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > > >
> > > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I think we are almost ready for cordova-andropid@8.0.0 release, should
finish the following:
* review and merge the following proposed PRs:
- https://github.com/apache/cordova-android/pull/656
- https://github.com/apache/cordova-android/pull/663
- https://github.com/apache/cordova-android/pull/664
* then I can go through the final testing and review of proposal in
https://github.com/apache/cordova-android/pull/655
On Fri, Feb 8, 2019 at 2:58 PM Chris Brody <ch...@gmail.com> wrote:
>
> I think it would be a pretty bad reflection on Apache Cordova if we
> would announce a new release that is known to depend on deprecated
> platform behavior. Not supporting AndroidX would be a prime example. I
> think it would also be pretty bad if a bug such as bug 508 would be
> introduced in the middle of the most recent release and not resolved
> before we make a new major release.
>
> That said, I think we have determined on GitHub that there is no issue
> with using cordova-android@8 (nightly) with AndroidX. The PSPDF team
> reported that this is only an issue with our plugins. (And from a
> quick scan I think the number of affected Apache Cordova plugins would
> be very limited limited.) So I would conclude that the issue with
> AndroidX should be blocking for Cordova CLI (and cordova-lib) but
> **not** for cordova-android.
>
> I would personally favor making the new cordova-android release once
> the following PRs are finished, reviewed, and merged:
>
> * https://github.com/apache/cordova-android/pull/655 - needs review
> * https://github.com/apache/cordova-android/pull/656 - quick fix
> proposal that I just made
>
> and less importantly:
>
> * https://github.com/apache/cordova-android/pull/642 - needs a review
> before merging
> * https://github.com/apache/cordova-android/pull/632 - needs a review
> before merging
>
> I do think there are quite a few more issues that should be resolved
> in a future cordova-android / Cordova CLI release. Yes we can always
> make a new major release whenever it is needed.
>
> On Fri, Feb 8, 2019 at 6:59 AM Jan Piotrowski <pi...@gmail.com> wrote:
> >
> > Let me correct my question then:
> > Why are those blocking and can not be added in a future major
> > cordova-android release (with an accompanying CLI release that adds
> > this as the new default android version to be installed if that is
> > still necessary) when those changes are merged?
> >
> > -J
> >
> >
> > Am Fr., 8. Feb. 2019 um 12:30 Uhr schrieb julio cesar sanchez
> > <jc...@gmail.com>:
> > >
> > > Unless we find a way of enabling/disabling Android X support, it's going to
> > > be a breaking change for all plugins using using the old way, so we can't
> > > do that in a 8.1 release
> > >
> > > El vie., 8 feb. 2019 a las 12:03, Jan Piotrowski (<pi...@gmail.com>)
> > > escribió:
> > >
> > > > I am not sure I follow:
> > > > Why are those blocking and can not be added with a quick 8.1 when
> > > > those changes are merged?
> > > >
> > > > -J
> > > >
> > > > Am Fr., 8. Feb. 2019 um 01:55 Uhr schrieb Chris Brody <
> > > > chris.brody@gmail.com>:
> > > > >
> > > > > I think the major blockers are AndroidX and bug 508. I already
> > > > > proposed a quick fix solution for 508. For AndroidX I think we need to
> > > > > do a little more analysis and testing.
> > > > >
> > > > > Unfortunately I cannot promise much on my part due to some other
> > > > > priorities. I will try to take another look in the next few days, no
> > > > > guarantees though.
> > > > >
> > > > > On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <ch...@gmail.com>
> > > > wrote:
> > > > > >
> > > > > > Update coming later today. I think there are still a number of
> > > > > > blockers that we need to get resolved.
> > > > > >
> > > > > > On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com>
> > > > wrote:
> > > > > > >
> > > > > > > Can I get an update on this?
> > > > > > > Is there anyone still working on any blockers that need to be
> > > > finished
> > > > > > > before release?
> > > > > > > Can we continue with this release?
> > > > > > >
> > > > > > >
> > > > > > > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com>
> > > > wrote:
> > > > > > >
> > > > > > > > I would agree with Julio that we should verify androidx support
> > > > before we
> > > > > > > > finish the next major release. I don't expect we will have to make
> > > > any
> > > > > > > > fixes on cordova-android for androidx support. Issues for
> > > > reference:
> > > > > > > > * https://github.com/apache/cordova/issues/69
> > > > > > > > * https://github.com/apache/cordova-android/issues/565
> > > > > > > >
> > > > > > > > I just raised WIP PR
> > > > https://github.com/apache/cordova-android/pull/633 to
> > > > > > > > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> > > > > > > >
> > > > > > > > I think we should also try to resolve the following issues before
> > > > the next
> > > > > > > > major release:
> > > > > > > > * https://github.com/apache/cordova-android/issues/629 - issue
> > > > with
> > > > > > > > Android
> > > > > > > > Studio 3.2 & 3.3
> > > > > > > > * https://github.com/apache/cordova-android/issues/623 - fix
> > > > logging of
> > > > > > > > Java version (a PR was already proposed)
> > > > > > > >
> > > > > > > > I think it would be nice but not absolutely necessary to resolve
> > > > the
> > > > > > > > following issue as well:
> > > > > > > > * https://github.com/apache/cordova-android/issues/617 - support
> > > > > > > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now
> > > > deprecated
> > > > > > > > * https://github.com/apache/cordova-android/issues/634 - update
> > > > Gradle
> > > > > > > > classpath for Android Studio 3.3
> > > > > > > > * review & merge the following PRs:
> > > > > > > > - https://github.com/apache/cordova-android/pull/632 - ignore
> > > > more
> > > > > > > > Gradle
> > > > > > > > build artifacts in Android project
> > > > > > > > - https://github.com/apache/cordova-android/pull/635 - ignore
> > > > Android
> > > > > > > > Studio .idea files in Android project
> > > > > > > >
> > > > > > > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > > > > > > > jcesarmobile@gmail.com>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > As it's going to be a major release, I think we should look a
> > > > bit more
> > > > > > > > into
> > > > > > > > > Android X before doing a major release, just in case we need to
> > > > do major
> > > > > > > > > changes.
> > > > > > > > > In the issue related to Android X, I commented that we didn't
> > > > have the
> > > > > > > > > gradle.properties file, but in the linked PR I saw it's going to
> > > > be
> > > > > > > > > generated by the tooling now, so should be easier to just write
> > > > to it
> > > > > > > > with
> > > > > > > > > whatever is needed, and probably make it opt-in for now as it's
> > > > not clear
> > > > > > > > > if using Android X will prevent old plugins from working.
> > > > > > > > > Or is the gradle.properties file supposed to be managed by the
> > > > user
> > > > > > > > > somehow?
> > > > > > > > >
> > > > > > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<
> > > > chris.brody@gmail.com>)
> > > > > > > > > escribió:
> > > > > > > > >
> > > > > > > > > > I am investigating a quick solution for the bug, hope to have
> > > > something
> > > > > > > > > > today.
> > > > > > > > > >
> > > > > > > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <
> > > > chris.brody@gmail.com
> > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > The bug was introduced by new code that was added to both
> > > > master and
> > > > > > > > > > 7.1.4.
> > > > > > > > > > >
> > > > > > > > > > > On 7.1.4 the issue is discussed in:
> > > > > > > > > > > https://github.com/apache/cordova-android/issues/599
> > > > > > > > > > >
> > > > > > > > > > > I hope we can find a quick solution before we make the new
> > > > release.
> > > > > > > > > > >
> > > > > > > > > > > Fixing the bug would introduce some kind of change in
> > > > behavior, with
> > > > > > > > a
> > > > > > > > > > > possible risk that it would be a breaking change for someone
> > > > else.
> > > > > > > > > > >
> > > > > > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <
> > > > piotrowski@gmail.com
> > > > > > > > >
> > > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > >> Is this a new bug introduced by the new code that would be
> > > > released?
> > > > > > > > > > >> If not, there is no reason to stop a release of that (good)
> > > > code. As
> > > > > > > > > > >> soon as a fix for this bug is available, we can release it
> > > > as a
> > > > > > > > follow
> > > > > > > > > > >> up release (patch, minor, major - whatever appropriate).
> > > > > > > > > > >>
> > > > > > > > > > >> -J
> > > > > > > > > > >>
> > > > > > > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > > > > > > > >> chris.brody@gmail.com>:
> > > > > > > > > > >> >
> > > > > > > > > > >> > I do not think we should make a new cordova-android
> > > > release before
> > > > > > > > > we
> > > > > > > > > > >> can
> > > > > > > > > > >> > resolve
> > > > https://github.com/apache/cordova-android/issues/508
> > > > > > > > > > >> >
> > > > > > > > > > >> > I think it is a pretty bad bug. I would be happy to
> > > > explain
> > > > > > > > further
> > > > > > > > > if
> > > > > > > > > > >> > needed.
> > > > > > > > > > >> >
> > > > > > > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <
> > > > erisu@apache.org>
> > > > > > > > > > wrote:
> > > > > > > > > > >> >
> > > > > > > > > > >> > > Does anyone have any reason to delay a cordova-android
> > > > platform
> > > > > > > > > > >> release?
> > > > > > > > > > >> > > Any outstanding patches to land?
> > > > > > > > > > >> > >
> > > > > > > > > > >> > > If not, I will start the release process shortly.
> > > > > > > > > > >> > >
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > > > > > >> For additional commands, e-mail:
> > > > dev-help@cordova.apache.org
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > >
> > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I think it would be a pretty bad reflection on Apache Cordova if we
would announce a new release that is known to depend on deprecated
platform behavior. Not supporting AndroidX would be a prime example. I
think it would also be pretty bad if a bug such as bug 508 would be
introduced in the middle of the most recent release and not resolved
before we make a new major release.
That said, I think we have determined on GitHub that there is no issue
with using cordova-android@8 (nightly) with AndroidX. The PSPDF team
reported that this is only an issue with our plugins. (And from a
quick scan I think the number of affected Apache Cordova plugins would
be very limited limited.) So I would conclude that the issue with
AndroidX should be blocking for Cordova CLI (and cordova-lib) but
**not** for cordova-android.
I would personally favor making the new cordova-android release once
the following PRs are finished, reviewed, and merged:
* https://github.com/apache/cordova-android/pull/655 - needs review
* https://github.com/apache/cordova-android/pull/656 - quick fix
proposal that I just made
and less importantly:
* https://github.com/apache/cordova-android/pull/642 - needs a review
before merging
* https://github.com/apache/cordova-android/pull/632 - needs a review
before merging
I do think there are quite a few more issues that should be resolved
in a future cordova-android / Cordova CLI release. Yes we can always
make a new major release whenever it is needed.
On Fri, Feb 8, 2019 at 6:59 AM Jan Piotrowski <pi...@gmail.com> wrote:
>
> Let me correct my question then:
> Why are those blocking and can not be added in a future major
> cordova-android release (with an accompanying CLI release that adds
> this as the new default android version to be installed if that is
> still necessary) when those changes are merged?
>
> -J
>
>
> Am Fr., 8. Feb. 2019 um 12:30 Uhr schrieb julio cesar sanchez
> <jc...@gmail.com>:
> >
> > Unless we find a way of enabling/disabling Android X support, it's going to
> > be a breaking change for all plugins using using the old way, so we can't
> > do that in a 8.1 release
> >
> > El vie., 8 feb. 2019 a las 12:03, Jan Piotrowski (<pi...@gmail.com>)
> > escribió:
> >
> > > I am not sure I follow:
> > > Why are those blocking and can not be added with a quick 8.1 when
> > > those changes are merged?
> > >
> > > -J
> > >
> > > Am Fr., 8. Feb. 2019 um 01:55 Uhr schrieb Chris Brody <
> > > chris.brody@gmail.com>:
> > > >
> > > > I think the major blockers are AndroidX and bug 508. I already
> > > > proposed a quick fix solution for 508. For AndroidX I think we need to
> > > > do a little more analysis and testing.
> > > >
> > > > Unfortunately I cannot promise much on my part due to some other
> > > > priorities. I will try to take another look in the next few days, no
> > > > guarantees though.
> > > >
> > > > On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <ch...@gmail.com>
> > > wrote:
> > > > >
> > > > > Update coming later today. I think there are still a number of
> > > > > blockers that we need to get resolved.
> > > > >
> > > > > On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > Can I get an update on this?
> > > > > > Is there anyone still working on any blockers that need to be
> > > finished
> > > > > > before release?
> > > > > > Can we continue with this release?
> > > > > >
> > > > > >
> > > > > > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > > I would agree with Julio that we should verify androidx support
> > > before we
> > > > > > > finish the next major release. I don't expect we will have to make
> > > any
> > > > > > > fixes on cordova-android for androidx support. Issues for
> > > reference:
> > > > > > > * https://github.com/apache/cordova/issues/69
> > > > > > > * https://github.com/apache/cordova-android/issues/565
> > > > > > >
> > > > > > > I just raised WIP PR
> > > https://github.com/apache/cordova-android/pull/633 to
> > > > > > > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> > > > > > >
> > > > > > > I think we should also try to resolve the following issues before
> > > the next
> > > > > > > major release:
> > > > > > > * https://github.com/apache/cordova-android/issues/629 - issue
> > > with
> > > > > > > Android
> > > > > > > Studio 3.2 & 3.3
> > > > > > > * https://github.com/apache/cordova-android/issues/623 - fix
> > > logging of
> > > > > > > Java version (a PR was already proposed)
> > > > > > >
> > > > > > > I think it would be nice but not absolutely necessary to resolve
> > > the
> > > > > > > following issue as well:
> > > > > > > * https://github.com/apache/cordova-android/issues/617 - support
> > > > > > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now
> > > deprecated
> > > > > > > * https://github.com/apache/cordova-android/issues/634 - update
> > > Gradle
> > > > > > > classpath for Android Studio 3.3
> > > > > > > * review & merge the following PRs:
> > > > > > > - https://github.com/apache/cordova-android/pull/632 - ignore
> > > more
> > > > > > > Gradle
> > > > > > > build artifacts in Android project
> > > > > > > - https://github.com/apache/cordova-android/pull/635 - ignore
> > > Android
> > > > > > > Studio .idea files in Android project
> > > > > > >
> > > > > > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > > > > > > jcesarmobile@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > As it's going to be a major release, I think we should look a
> > > bit more
> > > > > > > into
> > > > > > > > Android X before doing a major release, just in case we need to
> > > do major
> > > > > > > > changes.
> > > > > > > > In the issue related to Android X, I commented that we didn't
> > > have the
> > > > > > > > gradle.properties file, but in the linked PR I saw it's going to
> > > be
> > > > > > > > generated by the tooling now, so should be easier to just write
> > > to it
> > > > > > > with
> > > > > > > > whatever is needed, and probably make it opt-in for now as it's
> > > not clear
> > > > > > > > if using Android X will prevent old plugins from working.
> > > > > > > > Or is the gradle.properties file supposed to be managed by the
> > > user
> > > > > > > > somehow?
> > > > > > > >
> > > > > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<
> > > chris.brody@gmail.com>)
> > > > > > > > escribió:
> > > > > > > >
> > > > > > > > > I am investigating a quick solution for the bug, hope to have
> > > something
> > > > > > > > > today.
> > > > > > > > >
> > > > > > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <
> > > chris.brody@gmail.com
> > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > The bug was introduced by new code that was added to both
> > > master and
> > > > > > > > > 7.1.4.
> > > > > > > > > >
> > > > > > > > > > On 7.1.4 the issue is discussed in:
> > > > > > > > > > https://github.com/apache/cordova-android/issues/599
> > > > > > > > > >
> > > > > > > > > > I hope we can find a quick solution before we make the new
> > > release.
> > > > > > > > > >
> > > > > > > > > > Fixing the bug would introduce some kind of change in
> > > behavior, with
> > > > > > > a
> > > > > > > > > > possible risk that it would be a breaking change for someone
> > > else.
> > > > > > > > > >
> > > > > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <
> > > piotrowski@gmail.com
> > > > > > > >
> > > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > >> Is this a new bug introduced by the new code that would be
> > > released?
> > > > > > > > > >> If not, there is no reason to stop a release of that (good)
> > > code. As
> > > > > > > > > >> soon as a fix for this bug is available, we can release it
> > > as a
> > > > > > > follow
> > > > > > > > > >> up release (patch, minor, major - whatever appropriate).
> > > > > > > > > >>
> > > > > > > > > >> -J
> > > > > > > > > >>
> > > > > > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > > > > > > >> chris.brody@gmail.com>:
> > > > > > > > > >> >
> > > > > > > > > >> > I do not think we should make a new cordova-android
> > > release before
> > > > > > > > we
> > > > > > > > > >> can
> > > > > > > > > >> > resolve
> > > https://github.com/apache/cordova-android/issues/508
> > > > > > > > > >> >
> > > > > > > > > >> > I think it is a pretty bad bug. I would be happy to
> > > explain
> > > > > > > further
> > > > > > > > if
> > > > > > > > > >> > needed.
> > > > > > > > > >> >
> > > > > > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <
> > > erisu@apache.org>
> > > > > > > > > wrote:
> > > > > > > > > >> >
> > > > > > > > > >> > > Does anyone have any reason to delay a cordova-android
> > > platform
> > > > > > > > > >> release?
> > > > > > > > > >> > > Any outstanding patches to land?
> > > > > > > > > >> > >
> > > > > > > > > >> > > If not, I will start the release process shortly.
> > > > > > > > > >> > >
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > > > > >> For additional commands, e-mail:
> > > dev-help@cordova.apache.org
> > > > > > > > > >>
> > > > > > > > > >>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Jan Piotrowski <pi...@gmail.com>.
Let me correct my question then:
Why are those blocking and can not be added in a future major
cordova-android release (with an accompanying CLI release that adds
this as the new default android version to be installed if that is
still necessary) when those changes are merged?
-J
Am Fr., 8. Feb. 2019 um 12:30 Uhr schrieb julio cesar sanchez
<jc...@gmail.com>:
>
> Unless we find a way of enabling/disabling Android X support, it's going to
> be a breaking change for all plugins using using the old way, so we can't
> do that in a 8.1 release
>
> El vie., 8 feb. 2019 a las 12:03, Jan Piotrowski (<pi...@gmail.com>)
> escribió:
>
> > I am not sure I follow:
> > Why are those blocking and can not be added with a quick 8.1 when
> > those changes are merged?
> >
> > -J
> >
> > Am Fr., 8. Feb. 2019 um 01:55 Uhr schrieb Chris Brody <
> > chris.brody@gmail.com>:
> > >
> > > I think the major blockers are AndroidX and bug 508. I already
> > > proposed a quick fix solution for 508. For AndroidX I think we need to
> > > do a little more analysis and testing.
> > >
> > > Unfortunately I cannot promise much on my part due to some other
> > > priorities. I will try to take another look in the next few days, no
> > > guarantees though.
> > >
> > > On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <ch...@gmail.com>
> > wrote:
> > > >
> > > > Update coming later today. I think there are still a number of
> > > > blockers that we need to get resolved.
> > > >
> > > > On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com>
> > wrote:
> > > > >
> > > > > Can I get an update on this?
> > > > > Is there anyone still working on any blockers that need to be
> > finished
> > > > > before release?
> > > > > Can we continue with this release?
> > > > >
> > > > >
> > > > > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com>
> > wrote:
> > > > >
> > > > > > I would agree with Julio that we should verify androidx support
> > before we
> > > > > > finish the next major release. I don't expect we will have to make
> > any
> > > > > > fixes on cordova-android for androidx support. Issues for
> > reference:
> > > > > > * https://github.com/apache/cordova/issues/69
> > > > > > * https://github.com/apache/cordova-android/issues/565
> > > > > >
> > > > > > I just raised WIP PR
> > https://github.com/apache/cordova-android/pull/633 to
> > > > > > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> > > > > >
> > > > > > I think we should also try to resolve the following issues before
> > the next
> > > > > > major release:
> > > > > > * https://github.com/apache/cordova-android/issues/629 - issue
> > with
> > > > > > Android
> > > > > > Studio 3.2 & 3.3
> > > > > > * https://github.com/apache/cordova-android/issues/623 - fix
> > logging of
> > > > > > Java version (a PR was already proposed)
> > > > > >
> > > > > > I think it would be nice but not absolutely necessary to resolve
> > the
> > > > > > following issue as well:
> > > > > > * https://github.com/apache/cordova-android/issues/617 - support
> > > > > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now
> > deprecated
> > > > > > * https://github.com/apache/cordova-android/issues/634 - update
> > Gradle
> > > > > > classpath for Android Studio 3.3
> > > > > > * review & merge the following PRs:
> > > > > > - https://github.com/apache/cordova-android/pull/632 - ignore
> > more
> > > > > > Gradle
> > > > > > build artifacts in Android project
> > > > > > - https://github.com/apache/cordova-android/pull/635 - ignore
> > Android
> > > > > > Studio .idea files in Android project
> > > > > >
> > > > > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > > > > > jcesarmobile@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > As it's going to be a major release, I think we should look a
> > bit more
> > > > > > into
> > > > > > > Android X before doing a major release, just in case we need to
> > do major
> > > > > > > changes.
> > > > > > > In the issue related to Android X, I commented that we didn't
> > have the
> > > > > > > gradle.properties file, but in the linked PR I saw it's going to
> > be
> > > > > > > generated by the tooling now, so should be easier to just write
> > to it
> > > > > > with
> > > > > > > whatever is needed, and probably make it opt-in for now as it's
> > not clear
> > > > > > > if using Android X will prevent old plugins from working.
> > > > > > > Or is the gradle.properties file supposed to be managed by the
> > user
> > > > > > > somehow?
> > > > > > >
> > > > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<
> > chris.brody@gmail.com>)
> > > > > > > escribió:
> > > > > > >
> > > > > > > > I am investigating a quick solution for the bug, hope to have
> > something
> > > > > > > > today.
> > > > > > > >
> > > > > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <
> > chris.brody@gmail.com
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > The bug was introduced by new code that was added to both
> > master and
> > > > > > > > 7.1.4.
> > > > > > > > >
> > > > > > > > > On 7.1.4 the issue is discussed in:
> > > > > > > > > https://github.com/apache/cordova-android/issues/599
> > > > > > > > >
> > > > > > > > > I hope we can find a quick solution before we make the new
> > release.
> > > > > > > > >
> > > > > > > > > Fixing the bug would introduce some kind of change in
> > behavior, with
> > > > > > a
> > > > > > > > > possible risk that it would be a breaking change for someone
> > else.
> > > > > > > > >
> > > > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <
> > piotrowski@gmail.com
> > > > > > >
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > >> Is this a new bug introduced by the new code that would be
> > released?
> > > > > > > > >> If not, there is no reason to stop a release of that (good)
> > code. As
> > > > > > > > >> soon as a fix for this bug is available, we can release it
> > as a
> > > > > > follow
> > > > > > > > >> up release (patch, minor, major - whatever appropriate).
> > > > > > > > >>
> > > > > > > > >> -J
> > > > > > > > >>
> > > > > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > > > > > >> chris.brody@gmail.com>:
> > > > > > > > >> >
> > > > > > > > >> > I do not think we should make a new cordova-android
> > release before
> > > > > > > we
> > > > > > > > >> can
> > > > > > > > >> > resolve
> > https://github.com/apache/cordova-android/issues/508
> > > > > > > > >> >
> > > > > > > > >> > I think it is a pretty bad bug. I would be happy to
> > explain
> > > > > > further
> > > > > > > if
> > > > > > > > >> > needed.
> > > > > > > > >> >
> > > > > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <
> > erisu@apache.org>
> > > > > > > > wrote:
> > > > > > > > >> >
> > > > > > > > >> > > Does anyone have any reason to delay a cordova-android
> > platform
> > > > > > > > >> release?
> > > > > > > > >> > > Any outstanding patches to land?
> > > > > > > > >> > >
> > > > > > > > >> > > If not, I will start the release process shortly.
> > > > > > > > >> > >
> > > > > > > > >>
> > > > > > > > >>
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > > > >> For additional commands, e-mail:
> > dev-help@cordova.apache.org
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by julio cesar sanchez <jc...@gmail.com>.
Unless we find a way of enabling/disabling Android X support, it's going to
be a breaking change for all plugins using using the old way, so we can't
do that in a 8.1 release
El vie., 8 feb. 2019 a las 12:03, Jan Piotrowski (<pi...@gmail.com>)
escribió:
> I am not sure I follow:
> Why are those blocking and can not be added with a quick 8.1 when
> those changes are merged?
>
> -J
>
> Am Fr., 8. Feb. 2019 um 01:55 Uhr schrieb Chris Brody <
> chris.brody@gmail.com>:
> >
> > I think the major blockers are AndroidX and bug 508. I already
> > proposed a quick fix solution for 508. For AndroidX I think we need to
> > do a little more analysis and testing.
> >
> > Unfortunately I cannot promise much on my part due to some other
> > priorities. I will try to take another look in the next few days, no
> > guarantees though.
> >
> > On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <ch...@gmail.com>
> wrote:
> > >
> > > Update coming later today. I think there are still a number of
> > > blockers that we need to get resolved.
> > >
> > > On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com>
> wrote:
> > > >
> > > > Can I get an update on this?
> > > > Is there anyone still working on any blockers that need to be
> finished
> > > > before release?
> > > > Can we continue with this release?
> > > >
> > > >
> > > > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com>
> wrote:
> > > >
> > > > > I would agree with Julio that we should verify androidx support
> before we
> > > > > finish the next major release. I don't expect we will have to make
> any
> > > > > fixes on cordova-android for androidx support. Issues for
> reference:
> > > > > * https://github.com/apache/cordova/issues/69
> > > > > * https://github.com/apache/cordova-android/issues/565
> > > > >
> > > > > I just raised WIP PR
> https://github.com/apache/cordova-android/pull/633 to
> > > > > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> > > > >
> > > > > I think we should also try to resolve the following issues before
> the next
> > > > > major release:
> > > > > * https://github.com/apache/cordova-android/issues/629 - issue
> with
> > > > > Android
> > > > > Studio 3.2 & 3.3
> > > > > * https://github.com/apache/cordova-android/issues/623 - fix
> logging of
> > > > > Java version (a PR was already proposed)
> > > > >
> > > > > I think it would be nice but not absolutely necessary to resolve
> the
> > > > > following issue as well:
> > > > > * https://github.com/apache/cordova-android/issues/617 - support
> > > > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now
> deprecated
> > > > > * https://github.com/apache/cordova-android/issues/634 - update
> Gradle
> > > > > classpath for Android Studio 3.3
> > > > > * review & merge the following PRs:
> > > > > - https://github.com/apache/cordova-android/pull/632 - ignore
> more
> > > > > Gradle
> > > > > build artifacts in Android project
> > > > > - https://github.com/apache/cordova-android/pull/635 - ignore
> Android
> > > > > Studio .idea files in Android project
> > > > >
> > > > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > > > > jcesarmobile@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > As it's going to be a major release, I think we should look a
> bit more
> > > > > into
> > > > > > Android X before doing a major release, just in case we need to
> do major
> > > > > > changes.
> > > > > > In the issue related to Android X, I commented that we didn't
> have the
> > > > > > gradle.properties file, but in the linked PR I saw it's going to
> be
> > > > > > generated by the tooling now, so should be easier to just write
> to it
> > > > > with
> > > > > > whatever is needed, and probably make it opt-in for now as it's
> not clear
> > > > > > if using Android X will prevent old plugins from working.
> > > > > > Or is the gradle.properties file supposed to be managed by the
> user
> > > > > > somehow?
> > > > > >
> > > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<
> chris.brody@gmail.com>)
> > > > > > escribió:
> > > > > >
> > > > > > > I am investigating a quick solution for the bug, hope to have
> something
> > > > > > > today.
> > > > > > >
> > > > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <
> chris.brody@gmail.com
> > > > > wrote:
> > > > > > >
> > > > > > > > The bug was introduced by new code that was added to both
> master and
> > > > > > > 7.1.4.
> > > > > > > >
> > > > > > > > On 7.1.4 the issue is discussed in:
> > > > > > > > https://github.com/apache/cordova-android/issues/599
> > > > > > > >
> > > > > > > > I hope we can find a quick solution before we make the new
> release.
> > > > > > > >
> > > > > > > > Fixing the bug would introduce some kind of change in
> behavior, with
> > > > > a
> > > > > > > > possible risk that it would be a breaking change for someone
> else.
> > > > > > > >
> > > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <
> piotrowski@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > >> Is this a new bug introduced by the new code that would be
> released?
> > > > > > > >> If not, there is no reason to stop a release of that (good)
> code. As
> > > > > > > >> soon as a fix for this bug is available, we can release it
> as a
> > > > > follow
> > > > > > > >> up release (patch, minor, major - whatever appropriate).
> > > > > > > >>
> > > > > > > >> -J
> > > > > > > >>
> > > > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > > > > >> chris.brody@gmail.com>:
> > > > > > > >> >
> > > > > > > >> > I do not think we should make a new cordova-android
> release before
> > > > > > we
> > > > > > > >> can
> > > > > > > >> > resolve
> https://github.com/apache/cordova-android/issues/508
> > > > > > > >> >
> > > > > > > >> > I think it is a pretty bad bug. I would be happy to
> explain
> > > > > further
> > > > > > if
> > > > > > > >> > needed.
> > > > > > > >> >
> > > > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <
> erisu@apache.org>
> > > > > > > wrote:
> > > > > > > >> >
> > > > > > > >> > > Does anyone have any reason to delay a cordova-android
> platform
> > > > > > > >> release?
> > > > > > > >> > > Any outstanding patches to land?
> > > > > > > >> > >
> > > > > > > >> > > If not, I will start the release process shortly.
> > > > > > > >> > >
> > > > > > > >>
> > > > > > > >>
> > > > >
> ---------------------------------------------------------------------
> > > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > > >> For additional commands, e-mail:
> dev-help@cordova.apache.org
> > > > > > > >>
> > > > > > > >>
> > > > > > >
> > > > > >
> > > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [DISCUSS] Cordova-Android Release
Posted by Jan Piotrowski <pi...@gmail.com>.
I am not sure I follow:
Why are those blocking and can not be added with a quick 8.1 when
those changes are merged?
-J
Am Fr., 8. Feb. 2019 um 01:55 Uhr schrieb Chris Brody <ch...@gmail.com>:
>
> I think the major blockers are AndroidX and bug 508. I already
> proposed a quick fix solution for 508. For AndroidX I think we need to
> do a little more analysis and testing.
>
> Unfortunately I cannot promise much on my part due to some other
> priorities. I will try to take another look in the next few days, no
> guarantees though.
>
> On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <ch...@gmail.com> wrote:
> >
> > Update coming later today. I think there are still a number of
> > blockers that we need to get resolved.
> >
> > On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com> wrote:
> > >
> > > Can I get an update on this?
> > > Is there anyone still working on any blockers that need to be finished
> > > before release?
> > > Can we continue with this release?
> > >
> > >
> > > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com> wrote:
> > >
> > > > I would agree with Julio that we should verify androidx support before we
> > > > finish the next major release. I don't expect we will have to make any
> > > > fixes on cordova-android for androidx support. Issues for reference:
> > > > * https://github.com/apache/cordova/issues/69
> > > > * https://github.com/apache/cordova-android/issues/565
> > > >
> > > > I just raised WIP PR https://github.com/apache/cordova-android/pull/633 to
> > > > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> > > >
> > > > I think we should also try to resolve the following issues before the next
> > > > major release:
> > > > * https://github.com/apache/cordova-android/issues/629 - issue with
> > > > Android
> > > > Studio 3.2 & 3.3
> > > > * https://github.com/apache/cordova-android/issues/623 - fix logging of
> > > > Java version (a PR was already proposed)
> > > >
> > > > I think it would be nice but not absolutely necessary to resolve the
> > > > following issue as well:
> > > > * https://github.com/apache/cordova-android/issues/617 - support
> > > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now deprecated
> > > > * https://github.com/apache/cordova-android/issues/634 - update Gradle
> > > > classpath for Android Studio 3.3
> > > > * review & merge the following PRs:
> > > > - https://github.com/apache/cordova-android/pull/632 - ignore more
> > > > Gradle
> > > > build artifacts in Android project
> > > > - https://github.com/apache/cordova-android/pull/635 - ignore Android
> > > > Studio .idea files in Android project
> > > >
> > > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > > > jcesarmobile@gmail.com>
> > > > wrote:
> > > >
> > > > > As it's going to be a major release, I think we should look a bit more
> > > > into
> > > > > Android X before doing a major release, just in case we need to do major
> > > > > changes.
> > > > > In the issue related to Android X, I commented that we didn't have the
> > > > > gradle.properties file, but in the linked PR I saw it's going to be
> > > > > generated by the tooling now, so should be easier to just write to it
> > > > with
> > > > > whatever is needed, and probably make it opt-in for now as it's not clear
> > > > > if using Android X will prevent old plugins from working.
> > > > > Or is the gradle.properties file supposed to be managed by the user
> > > > > somehow?
> > > > >
> > > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<ch...@gmail.com>)
> > > > > escribió:
> > > > >
> > > > > > I am investigating a quick solution for the bug, hope to have something
> > > > > > today.
> > > > > >
> > > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.brody@gmail.com
> > > > wrote:
> > > > > >
> > > > > > > The bug was introduced by new code that was added to both master and
> > > > > > 7.1.4.
> > > > > > >
> > > > > > > On 7.1.4 the issue is discussed in:
> > > > > > > https://github.com/apache/cordova-android/issues/599
> > > > > > >
> > > > > > > I hope we can find a quick solution before we make the new release.
> > > > > > >
> > > > > > > Fixing the bug would introduce some kind of change in behavior, with
> > > > a
> > > > > > > possible risk that it would be a breaking change for someone else.
> > > > > > >
> > > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <piotrowski@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Is this a new bug introduced by the new code that would be released?
> > > > > > >> If not, there is no reason to stop a release of that (good) code. As
> > > > > > >> soon as a fix for this bug is available, we can release it as a
> > > > follow
> > > > > > >> up release (patch, minor, major - whatever appropriate).
> > > > > > >>
> > > > > > >> -J
> > > > > > >>
> > > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > > > >> chris.brody@gmail.com>:
> > > > > > >> >
> > > > > > >> > I do not think we should make a new cordova-android release before
> > > > > we
> > > > > > >> can
> > > > > > >> > resolve https://github.com/apache/cordova-android/issues/508
> > > > > > >> >
> > > > > > >> > I think it is a pretty bad bug. I would be happy to explain
> > > > further
> > > > > if
> > > > > > >> > needed.
> > > > > > >> >
> > > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org>
> > > > > > wrote:
> > > > > > >> >
> > > > > > >> > > Does anyone have any reason to delay a cordova-android platform
> > > > > > >> release?
> > > > > > >> > > Any outstanding patches to land?
> > > > > > >> > >
> > > > > > >> > > If not, I will start the release process shortly.
> > > > > > >> > >
> > > > > > >>
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > > > > >>
> > > > > > >>
> > > > > >
> > > > >
> > > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I think the major blockers are AndroidX and bug 508. I already
proposed a quick fix solution for 508. For AndroidX I think we need to
do a little more analysis and testing.
Unfortunately I cannot promise much on my part due to some other
priorities. I will try to take another look in the next few days, no
guarantees though.
On Thu, Feb 7, 2019 at 2:22 PM Chris Brody <ch...@gmail.com> wrote:
>
> Update coming later today. I think there are still a number of
> blockers that we need to get resolved.
>
> On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com> wrote:
> >
> > Can I get an update on this?
> > Is there anyone still working on any blockers that need to be finished
> > before release?
> > Can we continue with this release?
> >
> >
> > On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com> wrote:
> >
> > > I would agree with Julio that we should verify androidx support before we
> > > finish the next major release. I don't expect we will have to make any
> > > fixes on cordova-android for androidx support. Issues for reference:
> > > * https://github.com/apache/cordova/issues/69
> > > * https://github.com/apache/cordova-android/issues/565
> > >
> > > I just raised WIP PR https://github.com/apache/cordova-android/pull/633 to
> > > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> > >
> > > I think we should also try to resolve the following issues before the next
> > > major release:
> > > * https://github.com/apache/cordova-android/issues/629 - issue with
> > > Android
> > > Studio 3.2 & 3.3
> > > * https://github.com/apache/cordova-android/issues/623 - fix logging of
> > > Java version (a PR was already proposed)
> > >
> > > I think it would be nice but not absolutely necessary to resolve the
> > > following issue as well:
> > > * https://github.com/apache/cordova-android/issues/617 - support
> > > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now deprecated
> > > * https://github.com/apache/cordova-android/issues/634 - update Gradle
> > > classpath for Android Studio 3.3
> > > * review & merge the following PRs:
> > > - https://github.com/apache/cordova-android/pull/632 - ignore more
> > > Gradle
> > > build artifacts in Android project
> > > - https://github.com/apache/cordova-android/pull/635 - ignore Android
> > > Studio .idea files in Android project
> > >
> > > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > > jcesarmobile@gmail.com>
> > > wrote:
> > >
> > > > As it's going to be a major release, I think we should look a bit more
> > > into
> > > > Android X before doing a major release, just in case we need to do major
> > > > changes.
> > > > In the issue related to Android X, I commented that we didn't have the
> > > > gradle.properties file, but in the linked PR I saw it's going to be
> > > > generated by the tooling now, so should be easier to just write to it
> > > with
> > > > whatever is needed, and probably make it opt-in for now as it's not clear
> > > > if using Android X will prevent old plugins from working.
> > > > Or is the gradle.properties file supposed to be managed by the user
> > > > somehow?
> > > >
> > > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<ch...@gmail.com>)
> > > > escribió:
> > > >
> > > > > I am investigating a quick solution for the bug, hope to have something
> > > > > today.
> > > > >
> > > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.brody@gmail.com
> > > wrote:
> > > > >
> > > > > > The bug was introduced by new code that was added to both master and
> > > > > 7.1.4.
> > > > > >
> > > > > > On 7.1.4 the issue is discussed in:
> > > > > > https://github.com/apache/cordova-android/issues/599
> > > > > >
> > > > > > I hope we can find a quick solution before we make the new release.
> > > > > >
> > > > > > Fixing the bug would introduce some kind of change in behavior, with
> > > a
> > > > > > possible risk that it would be a breaking change for someone else.
> > > > > >
> > > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <piotrowski@gmail.com
> > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Is this a new bug introduced by the new code that would be released?
> > > > > >> If not, there is no reason to stop a release of that (good) code. As
> > > > > >> soon as a fix for this bug is available, we can release it as a
> > > follow
> > > > > >> up release (patch, minor, major - whatever appropriate).
> > > > > >>
> > > > > >> -J
> > > > > >>
> > > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > > >> chris.brody@gmail.com>:
> > > > > >> >
> > > > > >> > I do not think we should make a new cordova-android release before
> > > > we
> > > > > >> can
> > > > > >> > resolve https://github.com/apache/cordova-android/issues/508
> > > > > >> >
> > > > > >> > I think it is a pretty bad bug. I would be happy to explain
> > > further
> > > > if
> > > > > >> > needed.
> > > > > >> >
> > > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org>
> > > > > wrote:
> > > > > >> >
> > > > > >> > > Does anyone have any reason to delay a cordova-android platform
> > > > > >> release?
> > > > > >> > > Any outstanding patches to land?
> > > > > >> > >
> > > > > >> > > If not, I will start the release process shortly.
> > > > > >> > >
> > > > > >>
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > > > >>
> > > > > >>
> > > > >
> > > >
> > >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
Update coming later today. I think there are still a number of
blockers that we need to get resolved.
On Thu, Feb 7, 2019 at 3:48 AM Bryan Ellis <el...@gmail.com> wrote:
>
> Can I get an update on this?
> Is there anyone still working on any blockers that need to be finished
> before release?
> Can we continue with this release?
>
>
> On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com> wrote:
>
> > I would agree with Julio that we should verify androidx support before we
> > finish the next major release. I don't expect we will have to make any
> > fixes on cordova-android for androidx support. Issues for reference:
> > * https://github.com/apache/cordova/issues/69
> > * https://github.com/apache/cordova-android/issues/565
> >
> > I just raised WIP PR https://github.com/apache/cordova-android/pull/633 to
> > resolve bug 508. I hope to fix the tests within the next 1-2 days.
> >
> > I think we should also try to resolve the following issues before the next
> > major release:
> > * https://github.com/apache/cordova-android/issues/629 - issue with
> > Android
> > Studio 3.2 & 3.3
> > * https://github.com/apache/cordova-android/issues/623 - fix logging of
> > Java version (a PR was already proposed)
> >
> > I think it would be nice but not absolutely necessary to resolve the
> > following issue as well:
> > * https://github.com/apache/cordova-android/issues/617 - support
> > ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now deprecated
> > * https://github.com/apache/cordova-android/issues/634 - update Gradle
> > classpath for Android Studio 3.3
> > * review & merge the following PRs:
> > - https://github.com/apache/cordova-android/pull/632 - ignore more
> > Gradle
> > build artifacts in Android project
> > - https://github.com/apache/cordova-android/pull/635 - ignore Android
> > Studio .idea files in Android project
> >
> > On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> > jcesarmobile@gmail.com>
> > wrote:
> >
> > > As it's going to be a major release, I think we should look a bit more
> > into
> > > Android X before doing a major release, just in case we need to do major
> > > changes.
> > > In the issue related to Android X, I commented that we didn't have the
> > > gradle.properties file, but in the linked PR I saw it's going to be
> > > generated by the tooling now, so should be easier to just write to it
> > with
> > > whatever is needed, and probably make it opt-in for now as it's not clear
> > > if using Android X will prevent old plugins from working.
> > > Or is the gradle.properties file supposed to be managed by the user
> > > somehow?
> > >
> > > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<ch...@gmail.com>)
> > > escribió:
> > >
> > > > I am investigating a quick solution for the bug, hope to have something
> > > > today.
> > > >
> > > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.brody@gmail.com
> > wrote:
> > > >
> > > > > The bug was introduced by new code that was added to both master and
> > > > 7.1.4.
> > > > >
> > > > > On 7.1.4 the issue is discussed in:
> > > > > https://github.com/apache/cordova-android/issues/599
> > > > >
> > > > > I hope we can find a quick solution before we make the new release.
> > > > >
> > > > > Fixing the bug would introduce some kind of change in behavior, with
> > a
> > > > > possible risk that it would be a breaking change for someone else.
> > > > >
> > > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <piotrowski@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > >> Is this a new bug introduced by the new code that would be released?
> > > > >> If not, there is no reason to stop a release of that (good) code. As
> > > > >> soon as a fix for this bug is available, we can release it as a
> > follow
> > > > >> up release (patch, minor, major - whatever appropriate).
> > > > >>
> > > > >> -J
> > > > >>
> > > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > > >> chris.brody@gmail.com>:
> > > > >> >
> > > > >> > I do not think we should make a new cordova-android release before
> > > we
> > > > >> can
> > > > >> > resolve https://github.com/apache/cordova-android/issues/508
> > > > >> >
> > > > >> > I think it is a pretty bad bug. I would be happy to explain
> > further
> > > if
> > > > >> > needed.
> > > > >> >
> > > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org>
> > > > wrote:
> > > > >> >
> > > > >> > > Does anyone have any reason to delay a cordova-android platform
> > > > >> release?
> > > > >> > > Any outstanding patches to land?
> > > > >> > >
> > > > >> > > If not, I will start the release process shortly.
> > > > >> > >
> > > > >>
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > > >>
> > > > >>
> > > >
> > >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Bryan Ellis <el...@gmail.com>.
Can I get an update on this?
Is there anyone still working on any blockers that need to be finished
before release?
Can we continue with this release?
On Sat, Jan 19, 2019 at 6:49 AM Chris Brody <ch...@gmail.com> wrote:
> I would agree with Julio that we should verify androidx support before we
> finish the next major release. I don't expect we will have to make any
> fixes on cordova-android for androidx support. Issues for reference:
> * https://github.com/apache/cordova/issues/69
> * https://github.com/apache/cordova-android/issues/565
>
> I just raised WIP PR https://github.com/apache/cordova-android/pull/633 to
> resolve bug 508. I hope to fix the tests within the next 1-2 days.
>
> I think we should also try to resolve the following issues before the next
> major release:
> * https://github.com/apache/cordova-android/issues/629 - issue with
> Android
> Studio 3.2 & 3.3
> * https://github.com/apache/cordova-android/issues/623 - fix logging of
> Java version (a PR was already proposed)
>
> I think it would be nice but not absolutely necessary to resolve the
> following issue as well:
> * https://github.com/apache/cordova-android/issues/617 - support
> ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now deprecated
> * https://github.com/apache/cordova-android/issues/634 - update Gradle
> classpath for Android Studio 3.3
> * review & merge the following PRs:
> - https://github.com/apache/cordova-android/pull/632 - ignore more
> Gradle
> build artifacts in Android project
> - https://github.com/apache/cordova-android/pull/635 - ignore Android
> Studio .idea files in Android project
>
> On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <
> jcesarmobile@gmail.com>
> wrote:
>
> > As it's going to be a major release, I think we should look a bit more
> into
> > Android X before doing a major release, just in case we need to do major
> > changes.
> > In the issue related to Android X, I commented that we didn't have the
> > gradle.properties file, but in the linked PR I saw it's going to be
> > generated by the tooling now, so should be easier to just write to it
> with
> > whatever is needed, and probably make it opt-in for now as it's not clear
> > if using Android X will prevent old plugins from working.
> > Or is the gradle.properties file supposed to be managed by the user
> > somehow?
> >
> > El vie., 18 ene. 2019 a las 15:02, Chris Brody (<ch...@gmail.com>)
> > escribió:
> >
> > > I am investigating a quick solution for the bug, hope to have something
> > > today.
> > >
> > > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.brody@gmail.com
> wrote:
> > >
> > > > The bug was introduced by new code that was added to both master and
> > > 7.1.4.
> > > >
> > > > On 7.1.4 the issue is discussed in:
> > > > https://github.com/apache/cordova-android/issues/599
> > > >
> > > > I hope we can find a quick solution before we make the new release.
> > > >
> > > > Fixing the bug would introduce some kind of change in behavior, with
> a
> > > > possible risk that it would be a breaking change for someone else.
> > > >
> > > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <piotrowski@gmail.com
> >
> > > > wrote:
> > > >
> > > >> Is this a new bug introduced by the new code that would be released?
> > > >> If not, there is no reason to stop a release of that (good) code. As
> > > >> soon as a fix for this bug is available, we can release it as a
> follow
> > > >> up release (patch, minor, major - whatever appropriate).
> > > >>
> > > >> -J
> > > >>
> > > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > > >> chris.brody@gmail.com>:
> > > >> >
> > > >> > I do not think we should make a new cordova-android release before
> > we
> > > >> can
> > > >> > resolve https://github.com/apache/cordova-android/issues/508
> > > >> >
> > > >> > I think it is a pretty bad bug. I would be happy to explain
> further
> > if
> > > >> > needed.
> > > >> >
> > > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org>
> > > wrote:
> > > >> >
> > > >> > > Does anyone have any reason to delay a cordova-android platform
> > > >> release?
> > > >> > > Any outstanding patches to land?
> > > >> > >
> > > >> > > If not, I will start the release process shortly.
> > > >> > >
> > > >>
> > > >>
> ---------------------------------------------------------------------
> > > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > > >>
> > > >>
> > >
> >
>
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I would agree with Julio that we should verify androidx support before we
finish the next major release. I don't expect we will have to make any
fixes on cordova-android for androidx support. Issues for reference:
* https://github.com/apache/cordova/issues/69
* https://github.com/apache/cordova-android/issues/565
I just raised WIP PR https://github.com/apache/cordova-android/pull/633 to
resolve bug 508. I hope to fix the tests within the next 1-2 days.
I think we should also try to resolve the following issues before the next
major release:
* https://github.com/apache/cordova-android/issues/629 - issue with Android
Studio 3.2 & 3.3
* https://github.com/apache/cordova-android/issues/623 - fix logging of
Java version (a PR was already proposed)
I think it would be nice but not absolutely necessary to resolve the
following issue as well:
* https://github.com/apache/cordova-android/issues/617 - support
ANDROID_SDK_ROOT in addition to ANDROID_HOME which is now deprecated
* https://github.com/apache/cordova-android/issues/634 - update Gradle
classpath for Android Studio 3.3
* review & merge the following PRs:
- https://github.com/apache/cordova-android/pull/632 - ignore more Gradle
build artifacts in Android project
- https://github.com/apache/cordova-android/pull/635 - ignore Android
Studio .idea files in Android project
On Fri, Jan 18, 2019 at 9:09 AM julio cesar sanchez <jc...@gmail.com>
wrote:
> As it's going to be a major release, I think we should look a bit more into
> Android X before doing a major release, just in case we need to do major
> changes.
> In the issue related to Android X, I commented that we didn't have the
> gradle.properties file, but in the linked PR I saw it's going to be
> generated by the tooling now, so should be easier to just write to it with
> whatever is needed, and probably make it opt-in for now as it's not clear
> if using Android X will prevent old plugins from working.
> Or is the gradle.properties file supposed to be managed by the user
> somehow?
>
> El vie., 18 ene. 2019 a las 15:02, Chris Brody (<ch...@gmail.com>)
> escribió:
>
> > I am investigating a quick solution for the bug, hope to have something
> > today.
> >
> > On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.brody@gmail.com wrote:
> >
> > > The bug was introduced by new code that was added to both master and
> > 7.1.4.
> > >
> > > On 7.1.4 the issue is discussed in:
> > > https://github.com/apache/cordova-android/issues/599
> > >
> > > I hope we can find a quick solution before we make the new release.
> > >
> > > Fixing the bug would introduce some kind of change in behavior, with a
> > > possible risk that it would be a breaking change for someone else.
> > >
> > > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <pi...@gmail.com>
> > > wrote:
> > >
> > >> Is this a new bug introduced by the new code that would be released?
> > >> If not, there is no reason to stop a release of that (good) code. As
> > >> soon as a fix for this bug is available, we can release it as a follow
> > >> up release (patch, minor, major - whatever appropriate).
> > >>
> > >> -J
> > >>
> > >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> > >> chris.brody@gmail.com>:
> > >> >
> > >> > I do not think we should make a new cordova-android release before
> we
> > >> can
> > >> > resolve https://github.com/apache/cordova-android/issues/508
> > >> >
> > >> > I think it is a pretty bad bug. I would be happy to explain further
> if
> > >> > needed.
> > >> >
> > >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org>
> > wrote:
> > >> >
> > >> > > Does anyone have any reason to delay a cordova-android platform
> > >> release?
> > >> > > Any outstanding patches to land?
> > >> > >
> > >> > > If not, I will start the release process shortly.
> > >> > >
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> For additional commands, e-mail: dev-help@cordova.apache.org
> > >>
> > >>
> >
>
Re: [DISCUSS] Cordova-Android Release
Posted by julio cesar sanchez <jc...@gmail.com>.
As it's going to be a major release, I think we should look a bit more into
Android X before doing a major release, just in case we need to do major
changes.
In the issue related to Android X, I commented that we didn't have the
gradle.properties file, but in the linked PR I saw it's going to be
generated by the tooling now, so should be easier to just write to it with
whatever is needed, and probably make it opt-in for now as it's not clear
if using Android X will prevent old plugins from working.
Or is the gradle.properties file supposed to be managed by the user somehow?
El vie., 18 ene. 2019 a las 15:02, Chris Brody (<ch...@gmail.com>)
escribió:
> I am investigating a quick solution for the bug, hope to have something
> today.
>
> On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.brody@gmail.com wrote:
>
> > The bug was introduced by new code that was added to both master and
> 7.1.4.
> >
> > On 7.1.4 the issue is discussed in:
> > https://github.com/apache/cordova-android/issues/599
> >
> > I hope we can find a quick solution before we make the new release.
> >
> > Fixing the bug would introduce some kind of change in behavior, with a
> > possible risk that it would be a breaking change for someone else.
> >
> > On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <pi...@gmail.com>
> > wrote:
> >
> >> Is this a new bug introduced by the new code that would be released?
> >> If not, there is no reason to stop a release of that (good) code. As
> >> soon as a fix for this bug is available, we can release it as a follow
> >> up release (patch, minor, major - whatever appropriate).
> >>
> >> -J
> >>
> >> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> >> chris.brody@gmail.com>:
> >> >
> >> > I do not think we should make a new cordova-android release before we
> >> can
> >> > resolve https://github.com/apache/cordova-android/issues/508
> >> >
> >> > I think it is a pretty bad bug. I would be happy to explain further if
> >> > needed.
> >> >
> >> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org>
> wrote:
> >> >
> >> > > Does anyone have any reason to delay a cordova-android platform
> >> release?
> >> > > Any outstanding patches to land?
> >> > >
> >> > > If not, I will start the release process shortly.
> >> > >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> >> For additional commands, e-mail: dev-help@cordova.apache.org
> >>
> >>
>
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I am investigating a quick solution for the bug, hope to have something
today.
On Fri, Jan 18, 2019, 8:42 AM Chris Brody <chris.brody@gmail.com wrote:
> The bug was introduced by new code that was added to both master and 7.1.4.
>
> On 7.1.4 the issue is discussed in:
> https://github.com/apache/cordova-android/issues/599
>
> I hope we can find a quick solution before we make the new release.
>
> Fixing the bug would introduce some kind of change in behavior, with a
> possible risk that it would be a breaking change for someone else.
>
> On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <pi...@gmail.com>
> wrote:
>
>> Is this a new bug introduced by the new code that would be released?
>> If not, there is no reason to stop a release of that (good) code. As
>> soon as a fix for this bug is available, we can release it as a follow
>> up release (patch, minor, major - whatever appropriate).
>>
>> -J
>>
>> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
>> chris.brody@gmail.com>:
>> >
>> > I do not think we should make a new cordova-android release before we
>> can
>> > resolve https://github.com/apache/cordova-android/issues/508
>> >
>> > I think it is a pretty bad bug. I would be happy to explain further if
>> > needed.
>> >
>> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org> wrote:
>> >
>> > > Does anyone have any reason to delay a cordova-android platform
>> release?
>> > > Any outstanding patches to land?
>> > >
>> > > If not, I will start the release process shortly.
>> > >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
The bug was introduced by new code that was added to both master and 7.1.4.
On 7.1.4 the issue is discussed in:
https://github.com/apache/cordova-android/issues/599
I hope we can find a quick solution before we make the new release.
Fixing the bug would introduce some kind of change in behavior, with a
possible risk that it would be a breaking change for someone else.
On Fri, Jan 18, 2019 at 8:27 AM Jan Piotrowski <pi...@gmail.com> wrote:
> Is this a new bug introduced by the new code that would be released?
> If not, there is no reason to stop a release of that (good) code. As
> soon as a fix for this bug is available, we can release it as a follow
> up release (patch, minor, major - whatever appropriate).
>
> -J
>
> Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <
> chris.brody@gmail.com>:
> >
> > I do not think we should make a new cordova-android release before we can
> > resolve https://github.com/apache/cordova-android/issues/508
> >
> > I think it is a pretty bad bug. I would be happy to explain further if
> > needed.
> >
> > On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org> wrote:
> >
> > > Does anyone have any reason to delay a cordova-android platform
> release?
> > > Any outstanding patches to land?
> > >
> > > If not, I will start the release process shortly.
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [DISCUSS] Cordova-Android Release
Posted by Jan Piotrowski <pi...@gmail.com>.
Is this a new bug introduced by the new code that would be released?
If not, there is no reason to stop a release of that (good) code. As
soon as a fix for this bug is available, we can release it as a follow
up release (patch, minor, major - whatever appropriate).
-J
Am Fr., 18. Jan. 2019 um 13:18 Uhr schrieb Chris Brody <ch...@gmail.com>:
>
> I do not think we should make a new cordova-android release before we can
> resolve https://github.com/apache/cordova-android/issues/508
>
> I think it is a pretty bad bug. I would be happy to explain further if
> needed.
>
> On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org> wrote:
>
> > Does anyone have any reason to delay a cordova-android platform release?
> > Any outstanding patches to land?
> >
> > If not, I will start the release process shortly.
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [DISCUSS] Cordova-Android Release
Posted by Chris Brody <ch...@gmail.com>.
I do not think we should make a new cordova-android release before we can
resolve https://github.com/apache/cordova-android/issues/508
I think it is a pretty bad bug. I would be happy to explain further if
needed.
On Fri, Jan 18, 2019 at 12:56 AM Bryan Ellis <er...@apache.org> wrote:
> Does anyone have any reason to delay a cordova-android platform release?
> Any outstanding patches to land?
>
> If not, I will start the release process shortly.
>