You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/03/23 08:28:48 UTC
[GitHub] zeppelin pull request #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium pa...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2181
[ZEPPELIN-2304] Fix vis Icon sizes in helium page
### What is this PR for?
Icon size of helium vis packages doesn't fit into the container button. I attached a image.
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2304](https://issues.apache.org/jira/browse/ZEPPELIN-2304)
### How should this be tested?
1. Install 2+ vis packages.
2. Open the `#helium` page
### Screenshots (if appropriate)
#### Before
<img width="378" alt="2304_before" src="https://cloud.githubusercontent.com/assets/4968473/24238569/17b7dbaa-0fee-11e7-9994-39fd7700c70c.png">
#### After
<img width="389" alt="2304_after" src="https://cloud.githubusercontent.com/assets/4968473/24238572/1aac7b72-0fee-11e7-934d-da4c2d864b54.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2304/fix-vis-icon-size-in-helium-page
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2181
----
commit a55e7d6e0ecea306801bad4db8653e1b69e1ca30
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-23T08:20:55Z
fix: Icon size of vis pkgs in helium page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2181
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2181
Just rebased and CI is green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2181
@AhyoungRyu I saw your comment now. Let me create a PR for the branch 0.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2181
looks like we need to rebase first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium pa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2181
Thanks. Merging into master and branch-0.7 now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2181
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2181
Merge into master and branch-0.7 if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2181
@1ambda I couldn't auto merge this PR into branch-0.7 since there are some conflicts. If you don't mind, can you create separate PR for branch-0.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---