Re: [PR] Lift MessagingService.minimum_version to 40 (CASSANDRA-18314) [cassandra]

["michaelsembwever (via GitHub)" <gi...@apache.org>]

michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1384818716


##########
src/java/org/apache/cassandra/hints/HintsDescriptor.java:
##########
@@ -231,8 +231,6 @@ static int messagingVersion(int hintsVersion)
     {
         switch (hintsVersion)
         {
-            case VERSION_30:
-                return MessagingService.VERSION_30;

Review Comment:
   turned out, HintsDescriptor is part of deserialisation, and we needed to keep this to maintain readability of old hint files.
   
   see https://issues.apache.org/jira/browse/CASSANDRA-18314?focusedCommentId=17783522&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17783522 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org