You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/14 04:42:22 UTC
[GitHub] [apisix-dashboard] tomtiao opened a new pull request, #2639: feat(route): make front-end adapt `route` v3 api modification
tomtiao opened a new pull request, #2639:
URL: https://github.com/apache/apisix-dashboard/pull/2639
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
It seems that `/labels/route` is missing in v3. This spawns Network Error notification which prevents tests from passing. Should I query all route data and collect the labels?
Tests of `route` fails due to:
- create process depends on other modules, like `upstream` which haven't been adapted yet
- missing apis in v3
I have modified some of the frontend code using the info in the Postman api docs. Tell me if I could do more.
### Code that block tests
- `batch-delete-route` test
- `/labels/route` notification prevents cy from clicking the button
- missing api
- `create-route-*` test
- create process depends on `upstream`
- `data-loader-import` test
- missing api
- `search-route` test
- depends on create process
- `table-auto-jump-when-no-data` test
- `/labels/route` notification prevents cy from clicking the button
**Related issues**
fix/resolve #2636
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2639: feat(route): make front-end adapt `route` v3 api modification
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on PR #2639:
URL: https://github.com/apache/apisix-dashboard/pull/2639#issuecomment-1289891366
> I wonder if we could turn off the tests. 😂
I think you can temporarily close the irrelevant tests, the relevant tests need to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2639: feat(route): make front-end adapt `route` v3 api modification
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on PR #2639:
URL: https://github.com/apache/apisix-dashboard/pull/2639#issuecomment-1278475563
### <span aria-hidden="true">👷</span> Deploy Preview for *apisix-dashboard* processing.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 358382ff844ef5f349cb738ab2edf514181b013d |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apisix-dashboard/deploys/6348e8aee1a8a7000a1d2f02 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2639: feat(route): make front-end adapt `route` v3 api modification
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on PR #2639:
URL: https://github.com/apache/apisix-dashboard/pull/2639#issuecomment-1283526333
For features that are not yet supported, can we disable the corresponding test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2639: feat(route): make front-end adapt `route` v3 api modification
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on PR #2639:
URL: https://github.com/apache/apisix-dashboard/pull/2639#issuecomment-1283522870
Hello, @tomtiao Do you have any questions for the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tomtiao commented on pull request #2639: feat(route): make front-end adapt `route` v3 api modification
Posted by GitBox <gi...@apache.org>.
tomtiao commented on PR #2639:
URL: https://github.com/apache/apisix-dashboard/pull/2639#issuecomment-1285530936
> Hello, @tomtiao Do you have any questions for the CI?
I wonder if we could turn off the tests. 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org