You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/06/08 09:05:51 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"
jackwener opened a new pull request, #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599
This reverts commit 87e5adc9
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599#issuecomment-1582621961
cc @RTEnzyme who originally contributed this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] RTEnzyme commented on pull request #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"
Posted by "RTEnzyme (via GitHub)" <gi...@apache.org>.
RTEnzyme commented on PR #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599#issuecomment-1583856049
I agree that `not()` should only support boolean types. If we want to implement bitwise_not on integers, we should create a new Expr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599#issuecomment-1582380146
wait for opinion of @liukun4515 in #6589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599#discussion_r1222689501
##########
datafusion/core/tests/sqllogictests/test_files/scalar.slt:
##########
@@ -911,17 +911,15 @@ SELECT not(true), not(false)
----
false true
-query BB
+query error DataFusion error: Optimizer rule 'simplify_expressions' failed\ncaused by\nInternal error: NOT 'Literal \{ value: Int64\(1\) \}' can't be evaluated because the expression's type is Int64, not boolean or NULL\. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
Review Comment:
It should fail in `type coercion`, it's a future ticket.
We should try to cast param. (if fail cast then throw a error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599#issuecomment-1582623064
Also cc @comphead who commented on https://github.com/apache/arrow-datafusion/pull/5902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6599: Revert "feat: Implement the bitwise_not in NotExpr (#5902)"
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6599:
URL: https://github.com/apache/arrow-datafusion/pull/6599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org