You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/10/12 01:33:03 UTC
[jira] [Created] (HBASE-6987) Port HBASE-6920 to trunk (?)
Gregory Chanan created HBASE-6987:
-------------------------------------
Summary: Port HBASE-6920 to trunk (?)
Key: HBASE-6987
URL: https://issues.apache.org/jira/browse/HBASE-6987
Project: HBase
Issue Type: Bug
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Priority: Critical
Fix For: 0.96.0
Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474769#comment-13474769 ]
Lars Hofhansl commented on HBASE-6987:
--------------------------------------
The entire logic in changed in trunk (thanks to the great work of [~nkeywal]).
>From what I've seen, this should not be necessary in trunk (but this is the master connection - not the ZK connections, so I am not entirely sure).
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Critical
> Fix For: 0.96.0
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481679#comment-13481679 ]
stack commented on HBASE-6987:
------------------------------
+1
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Task
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480577#comment-13480577 ]
Lars Hofhansl commented on HBASE-6987:
--------------------------------------
Looks good. +1
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480558#comment-13480558 ]
Gregory Chanan commented on HBASE-6987:
---------------------------------------
[~lhofhansl] mind taking a quick look?
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481961#comment-13481961 ]
Hudson commented on HBASE-6987:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #231 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/231/])
HBASE-6987 Port HBASE-6920 to trunk (?) (Revision 1401015)
Result = FAILURE
gchanan :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/RandomTimeoutRpcEngine.java
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Task
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6987:
----------------------------------
Status: Patch Available (was: Open)
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6987:
----------------------------------
Priority: Minor (was: Critical)
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6987:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the review, Lars. Committed to trunk.
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476495#comment-13476495 ]
Gregory Chanan commented on HBASE-6987:
---------------------------------------
It looks like we won't get stuck, as in HBASE-6920.
It may be possible to throw an UndeclaredThrowableException to the client, need to look more into it. But can be lower priority.
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Critical
> Fix For: 0.96.0
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478675#comment-13478675 ]
Hadoop QA commented on HBASE-6987:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12549624/HBASE-6987.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3072//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3072//console
This message is automatically generated.
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6987:
----------------------------------
Attachment: HBASE-6987.patch
* Attached HBASE-6987.patch *
Code in trunk looks good (thanks again to nkeywal).
This patch makes a couple of changes:
- Simplifies some HBaseAdmin logic wrt checking if the master is available
- Adds a test for HBASE-6920 (it passes, since the code-under-test is good :)). It is non-invasive to the RpcEngine layer, unlike the original test in HBASE-6920.
The test isn't perfect; it only throws ServiceExceptions because that is all that ProtobufRpcEngine throws. If that changes or another RpcEngine is used, the RandomTimeoutRpcEngine may not properly mimic the exception types coming from the RpcEngine. Putting hooks into any deeper layer (e.g. HBaseClient) would get very tricky and invasive.
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Bug
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6987:
----------------------------------
Issue Type: Task (was: Bug)
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Task
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6987) Port HBASE-6920 to trunk (?)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481778#comment-13481778 ]
Hudson commented on HBASE-6987:
-------------------------------
Integrated in HBase-TRUNK #3472 (See [https://builds.apache.org/job/HBase-TRUNK/3472/])
HBASE-6987 Port HBASE-6920 to trunk (?) (Revision 1401015)
Result = FAILURE
gchanan :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/RandomTimeoutRpcEngine.java
> Port HBASE-6920 to trunk (?)
> ----------------------------
>
> Key: HBASE-6987
> URL: https://issues.apache.org/jira/browse/HBASE-6987
> Project: HBase
> Issue Type: Task
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-6987.patch
>
>
> Need to investigate whether we need to port HBASE-6920 to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira