You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/08 18:57:29 UTC

[GitHub] [geode] Bill opened a new pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version: Second Try, with git mv

Bill opened a new pull request #5355:
URL: https://github.com/apache/geode/pull/5355


   [GEODE-8337](https://issues.apache.org/jira/browse/GEODE-8337)
   
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5355:
URL: https://github.com/apache/geode/pull/5355#issuecomment-660366214


   Acceptance test failed with:
   
   ```go
   > Task :geode-assembly:docker
   
   free(): invalid pointer
   
   SIGABRT: abort
   
   PC=0x7fb44f973e97 m=0 sigcode=18446744073709551610
   
   signal arrived during cgo execution
   
   
   goroutine 1 [syscall, locked to thread]:
   
   runtime.cgocall(0x4afd50, 0xc420051cc0, 0xc420051ce8)
   
   	/usr/lib/go-1.8/src/runtime/cgocall.go:131 +0xe2 fp=0xc420051c90 sp=0xc420051c50
   ```
   
   I'm assuming this is due to a bug in Docker or a resource issue in the CI infrastructure. I'm re-triggering this suite…


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5355:
URL: https://github.com/apache/geode/pull/5355#issuecomment-660300943


   Thanks for the review @bschuchardt. I'm rewriting history on this PR now to get it down to the minimal number of commits (2). After CI runs on that I'll merge it!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill merged pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
Bill merged pull request #5355:
URL: https://github.com/apache/geode/pull/5355


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill edited a comment on pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
Bill edited a comment on pull request #5355:
URL: https://github.com/apache/geode/pull/5355#issuecomment-660372715


   Distributed test failure is due to open, flaky [GEODE-8191](https://issues.apache.org/jira/browse/GEODE-8191) so I'm calling that test ok ✓


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] albertogpz commented on pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
albertogpz commented on pull request #5355:
URL: https://github.com/apache/geode/pull/5355#issuecomment-655921588


   > @albertogpz for some reason I can't add you as a reviewer, but thought you might be interested in this, the "last" PR associated with GEODE-8240. This one finalizing the renaming of the types in the new versioning hierarchy (and the associated `Versioning` factory) etc.
   
   @Bill it might be because I am not a committer. Thanks for taking me into account because I am definitely interested.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5355:
URL: https://github.com/apache/geode/pull/5355#issuecomment-655804702


   @albertogpz for some reason I can't add you as a reviewer, but thought you might be interested in this, the "last" PR associated with GEODE-8240. This one finalizing the renaming of the types in the new versioning hierarchy (and the associated `Versioning` factory) etc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5355:
URL: https://github.com/apache/geode/pull/5355#issuecomment-660372715


   Distributed test failure is due to [GEODE-8191](https://issues.apache.org/jira/browse/GEODE-8191) so I'm calling that test ok ✓


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill edited a comment on pull request #5355: GEODE-8337: Rename Version->KnownVersion, VersionOrdinal->Version

Posted by GitBox <gi...@apache.org>.
Bill edited a comment on pull request #5355:
URL: https://github.com/apache/geode/pull/5355#issuecomment-660372715


   Distributed test failure is due to open, flaky [GEODE-8191](https://issues.apache.org/jira/browse/GEODE-8191) so I'm calling the distributed test ok ✓


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org