You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/29 03:48:27 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #4739: Revert "lib/netdb: Change the default NETDB_DNSCLIENT_NAMESIZE to NAM…

yamt opened a new pull request #4739:
URL: https://github.com/apache/incubator-nuttx/pull/4739


   …E_MAX"
   
   ## Summary
   
   This reverts commit 3724f6be557525a550f35fe2942f10c1d06f27c2.
   
   Because there is no real correlation between DNS namesize and NAME_MAX
   as far as I know. The former is about network and the latter is about
   filesystem. While they might happen to be similar values for
   some configurations, it's very confusing to use them this way.
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4739: Revert "lib/netdb: Change the default NETDB_DNSCLIENT_NAMESIZE to NAM…

Posted by GitBox <gi...@apache.org>.

masayuki2009 commented on pull request #4739:
URL: https://github.com/apache/incubator-nuttx/pull/4739#issuecomment-954440033


   >Because there is no real correlation between DNS namesize and NAME_MAX
   >as far as I know. The former is about network and the latter is about
   >filesystem. While they might happen to be similar values for
   >some configurations, it's very confusing to use them this way.
   
   I agree.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4739: Revert "lib/netdb: Change the default NETDB_DNSCLIENT_NAMESIZE to NAM…

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 edited a comment on pull request #4739:
URL: https://github.com/apache/incubator-nuttx/pull/4739#issuecomment-954452705


   It make sense to have the same default value for the length of domain name and file path, but it's too late to make the change from compatibility perspective since 32 isn't a practical value for NETDB_DNSCLIENT_NAMESIZE in the today's network infrastructure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4739: Revert "lib/netdb: Change the default NETDB_DNSCLIENT_NAMESIZE to NAM…

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #4739:
URL: https://github.com/apache/incubator-nuttx/pull/4739


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4739: Revert "lib/netdb: Change the default NETDB_DNSCLIENT_NAMESIZE to NAM…

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on pull request #4739:
URL: https://github.com/apache/incubator-nuttx/pull/4739#issuecomment-954452705


   It make sense to have the same default value for the length of domain name and file path, but it's too late to make the change from compatibility perspective. 32 isn't a practical value NETDB_DNSCLIENT_NAMESIZE in the today's network infrastructure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org