[GitHub] [druid] clintropolis commented on a diff in pull request #13777: Information schema now uses numeric column types

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis commented on code in PR #13777:
URL: https://github.com/apache/druid/pull/13777#discussion_r1103891003


##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/InformationSchema.java:
##########
@@ -73,44 +73,65 @@ public class InformationSchema extends AbstractSchema
   private static final String SCHEMATA_TABLE = "SCHEMATA";
   private static final String TABLES_TABLE = "TABLES";
   private static final String COLUMNS_TABLE = "COLUMNS";
-  private static final RowSignature SCHEMATA_SIGNATURE = RowSignature

Review Comment:
   nit: why the change from using `RowSignature`? Just thinking ahead and wondering if this has any impact on if we want to make `INFORMATION_SCHEMA` and `sys` tables be executed with the Druid engine (instead of the "bindable" fallback engine). If they are modeled as native datasources then we would want these to be defined in terms of the native types...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org