[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6058: Core,Spark: Add metadata to Scan Report

[GitBox <gi...@apache.org>]

danielcweeks commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1020398769


##########
core/src/main/java/org/apache/iceberg/BaseTableScan.java:
##########
@@ -141,6 +142,8 @@ public CloseableIterable<FileScanTask> planFiles() {
           doPlanFiles(),
           () -> {
             planningDuration.stop();
+            Map<String, String> metadata = Maps.newHashMap(context().options());
+            metadata.putAll(EnvironmentContext.get());

Review Comment:
   I don't feel like there's a whole lot of value separating these at this point.  The metadata we're passing through is contextual and likely won't be consistent from engine to engine (e.g. spark will send app-id, but other engines may not).
   
   If we want more structured or explicit information from engines, I think we would need to define those values at a higher level to ensure consistency and reporting (for example a context object that's required at the catalog level).
   
   I'm on board with the current approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org