You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by andygrove <gi...@git.apache.org> on 2016/01/21 16:34:05 UTC

[GitHub] spark pull request: improved error message for java type inference...

GitHub user andygrove opened a pull request:

    https://github.com/apache/spark/pull/10865

    improved error message for java type inference failure

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/codefutures/spark SPARK-12932

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10865.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10865
    
----
commit f11f1c738771339e4031c313f759fa555524f3b3
Author: Andy Grove <an...@gmail.com>
Date:   2016-01-21T15:33:22Z

    improved error message

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/10865#issuecomment-174438863
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49980/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/10865#issuecomment-174421083
  
    **[Test build #49980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49980/consoleFull)** for PR 10865 at commit [`a85f52b`](https://github.com/apache/spark/commit/a85f52b0f5c2acaef78dce9a9730cb79456f9c81).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/10865


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/10865#issuecomment-174165671
  
    Yeah, these are consistent test failures but they're not due to this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/10865#issuecomment-173820679
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by rxin <gi...@git.apache.org>.

Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/10865#issuecomment-173790014
  
    cc @cloud-fan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/10865#issuecomment-173980178
  
    **[Test build #2440 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2440/consoleFull)** for PR 10865 at commit [`a85f52b`](https://github.com/apache/spark/commit/a85f52b0f5c2acaef78dce9a9730cb79456f9c81).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `              s\"Cannot infer type for class $`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/10865#issuecomment-173959408
  
    **[Test build #2440 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2440/consoleFull)** for PR 10865 at commit [`a85f52b`](https://github.com/apache/spark/commit/a85f52b0f5c2acaef78dce9a9730cb79456f9c81).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-12932] [Java API] improved error messag...

Posted by andygrove <gi...@git.apache.org>.

Github user andygrove commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10865#discussion_r50498238
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala ---
    @@ -406,7 +406,7 @@ object JavaTypeInference {
                   expressions.Literal(fieldName) :: extractorFor(fieldValue, fieldType) :: Nil
                 })
               } else {
    -            throw new UnsupportedOperationException(s"no encoder found for ${other.getName}")
    +            throw new UnsupportedOperationException(s"Cannot infer type for Java class ${other.getName} because it is not bean-compliant")
    --- End diff --
    
    Thanks. I have pushed a fix.
    
    On Thu, Jan 21, 2016 at 8:12 PM, Reynold Xin <no...@github.com>
    wrote:
    
    > In
    > sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
    > <https://github.com/apache/spark/pull/10865#discussion_r50498058>:
    >
    > > @@ -406,7 +406,7 @@ object JavaTypeInference {
    > >                expressions.Literal(fieldName) :: extractorFor(fieldValue, fieldType) :: Nil
    > >              })
    > >            } else {
    > > -            throw new UnsupportedOperationException(s"no encoder found for ${other.getName}")
    > > +            throw new UnsupportedOperationException(s"Cannot infer type for Java class ${other.getName} because it is not bean-compliant")
    >
    > this needs to be less than 100 chars wide to fit spark's style guide
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/10865/files#r50498058>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org