You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "showuon (via GitHub)" <gi...@apache.org> on 2025/03/10 04:56:19 UTC
[PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
showuon opened a new pull request, #19172:
URL: https://github.com/apache/kafka/pull/19172
In "Upgrading to 4.0.0 from any version 0.8.x through 3.9.x" section, we directly give instructions about [Upgrading to KRaft-based clusters](https://kafka.apache.org/documentation/#upgrade_390_kraft), but there might still be some users under ZK cluster before upgrading to v4.0.0. We need to make it clear that they need to upgrade to KRaft mode first before upgrading to v4.0.0 in "Upgrading to 4.0.0 from any version 0.8.x through 3.9.x" section.
Before:
<img width="825" alt="image" src="https://github.com/user-attachments/assets/4309e963-a589-4003-b2fb-1acf5309b1f1" />
After:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon merged PR #19172:
URL: https://github.com/apache/kafka/pull/19172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #19172:
URL: https://github.com/apache/kafka/pull/19172#discussion_r1986603287
##########
docs/upgrade.html:
##########
@@ -64,7 +70,7 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker upgrades to 4.0.x (and higher) require KRaft mode and
the software and metadata versions must be at least 3.3.x (the first version when KRaft mode was deemed production ready). For clusters in KRaft mode
with versions older than 3.3.x, we recommend upgrading to 3.9.x before upgrading to 4.0.x. Clusters in ZooKeeper mode
- have to be <a href="/39/documentation.html#kraft_zk_migration">migrated to KRaft mode</a> before they can be upgraded to 4.0.x.
+ have to be <a href="/{{version}}/documentation.html#kraft_zk_migration">migrated to KRaft mode</a> before they can be upgraded to 4.0.x.
Review Comment:
Side fix: we should use `{{version}}` variable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #19172:
URL: https://github.com/apache/kafka/pull/19172#issuecomment-2709433524
@dajac , I think we should merge this PR to v4.0.0, though it's not a blocker for the RC3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #19172:
URL: https://github.com/apache/kafka/pull/19172#discussion_r1987352108
##########
docs/upgrade.html:
##########
@@ -61,10 +67,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
<a href="https://cwiki.apache.org/confluence/x/K5sODg">KIP-896</a> for the details.
</li>
<li>
- Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker upgrades to 4.0.x (and higher) require KRaft mode and
- the software and metadata versions must be at least 3.3.x (the first version when KRaft mode was deemed production ready). For clusters in KRaft mode
- with versions older than 3.3.x, we recommend upgrading to 3.9.x before upgrading to 4.0.x. Clusters in ZooKeeper mode
- have to be <a href="/39/documentation.html#kraft_zk_migration">migrated to KRaft mode</a> before they can be upgraded to 4.0.x.
+ Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. About version upgrade,
+ check <a href="/{{version}}/documentation.html#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a> for more info.
Review Comment:
Changing 4.0.0 to 4.0.x would make document more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19172:
URL: https://github.com/apache/kafka/pull/19172#discussion_r1986702996
##########
docs/upgrade.html:
##########
@@ -31,6 +31,12 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+<p>Note: Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker upgrades to 4.0.x (and higher) require KRaft mode and
Review Comment:
Okay, I just find it odd that there are two identical descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #19172:
URL: https://github.com/apache/kafka/pull/19172#discussion_r1986734547
##########
docs/upgrade.html:
##########
@@ -31,6 +31,12 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+<p>Note: Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker upgrades to 4.0.x (and higher) require KRaft mode and
Review Comment:
@chia7712 , I think you're right, we should not have duplicated content. I've changed the notable change to refer to upgrade section like this:
`Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. About version upgrade, check <a href="/{{version}}/documentation.html#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a> for more info.`
Let me know what you think. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19172:
URL: https://github.com/apache/kafka/pull/19172#discussion_r1986684323
##########
docs/upgrade.html:
##########
@@ -31,6 +31,12 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+<p>Note: Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker upgrades to 4.0.x (and higher) require KRaft mode and
Review Comment:
should we remove the duplicate section from `Notable changes in 4.0.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #19172:
URL: https://github.com/apache/kafka/pull/19172#discussion_r1986687663
##########
docs/upgrade.html:
##########
@@ -31,6 +31,12 @@ <h5><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable changes in 4
</ul>
<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a></h4>
+<p>Note: Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker upgrades to 4.0.x (and higher) require KRaft mode and
Review Comment:
I don't know, to be honest, because that's also a notable change in v4.0.0... Maybe we can hear the 3rd opinion from the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: improve upgrade to v4.0.0 doc [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #19172:
URL: https://github.com/apache/kafka/pull/19172#discussion_r1988244400
##########
docs/upgrade.html:
##########
@@ -61,10 +67,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
<a href="https://cwiki.apache.org/confluence/x/K5sODg">KIP-896</a> for the details.
</li>
<li>
- Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker upgrades to 4.0.x (and higher) require KRaft mode and
- the software and metadata versions must be at least 3.3.x (the first version when KRaft mode was deemed production ready). For clusters in KRaft mode
- with versions older than 3.3.x, we recommend upgrading to 3.9.x before upgrading to 4.0.x. Clusters in ZooKeeper mode
- have to be <a href="/39/documentation.html#kraft_zk_migration">migrated to KRaft mode</a> before they can be upgraded to 4.0.x.
+ Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. About version upgrade,
+ check <a href="/{{version}}/documentation.html#upgrade_4_0_0">Upgrading to 4.0.0 from any version 3.3.x through 3.9.x</a> for more info.
Review Comment:
Sounds good. PR updated. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org