You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Jim Meyering <ji...@meyering.net> on 2007/02/14 10:30:10 UTC
nit in configure.ac
I tried using ./configure --disable-apr yesterday, and it failed.
The following patch fixes the immediate bug, but of course, any
subsequent attempt to build without APR fails for now.
I still don't have a password, so, rather than waiting to be able
to commit the change myself, I'll just resume posting patches.
Here it is:
2007-02-14 Jim Meyering <ji...@meyering.net>
* configure.ac: Use $enableval, not $enable_APR in the code
supporting --disable-apr and --enable-apr. The latter doesn't work.
Index: configure.ac
===================================================================
--- configure.ac (revision 506983)
+++ configure.ac (working copy)
@@ -102,18 +102,18 @@
AC_ARG_ENABLE(apr,
[ --enable-apr use the Apache Portable Runtime library (default)
--disable-apr do not use the Apache Portable Runtime library],
-[case $enable_APR in
+[case $enableval in
yes|no) ;;
- *) AC_MSG_ERROR([invalid APR enable/disable value: $enable_APR]) ;;
+ *) AC_MSG_ERROR([invalid APR enable/disable value: $enableval]) ;;
esac],
-[enable_APR=yes])
+[enableval=yes])
APR_MINIMUM_VERSION=1.2.2
AC_SUBST(APR_MINIMUM_VERSION)
AC_SUBST(APR_CXXFLAGS)
AC_SUBST(USE_APR)
-if test "$enable_APR" = yes; then
+if test "$enableval" = yes; then
PKG_CHECK_MODULES([APR], [apr-1 >= $APR_MINIMUM_VERSION])
APR_CXXFLAGS="$APR_CFLAGS -DUSE_APR=1"
USE_APR=1
Re: nit in configure.ac
Posted by Gordon Sim <gs...@redhat.com>.
Jim Meyering wrote:
> 2007-02-14 Jim Meyering <ji...@meyering.net>
>
> * configure.ac: Use $enableval, not $enable_APR in the code
> supporting --disable-apr and --enable-apr. The latter doesn't work.
Applied as rev. 507455