You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "j-mercier (via GitHub)" <gi...@apache.org> on 2023/04/26 23:01:18 UTC

[GitHub] [airflow] j-mercier commented on pull request #22913: Do not declare a volume for sshKeySecret if dag persistence is enabled

j-mercier commented on PR #22913:
URL: https://github.com/apache/airflow/pull/22913#issuecomment-1524140287

   > [This change](https://github.com/astronomer/airflow/blob/04c59040915f1e2ea6b7bdce39b9833b3011f898/chart/templates/scheduler/scheduler-deployment.yaml#L249-L259) breaks scheduler deployment when dag persistence, git-sync and git-sync-ssh-key are enabled. In this case, `git-sync-ssh-key` volume mount will still be generated (see [_helpers](https://github.com/astronomer/airflow/blob/04c59040915f1e2ea6b7bdce39b9833b3011f898/chart/templates/_helpers.yaml#L233-L237)), without the corresponding `git-sync-ssh-key` volume.
   
   +1
   Is it possible to revert this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org