You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/31 11:10:26 UTC
[GitHub] flink pull request #4425: [FLINK-7305] [checkstyle] Allow imports from org.a...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4425
[FLINK-7305] [checkstyle] Allow imports from org.apache.flink.shaded and add new import block
## What is the purpose of the change
This PR allows shaded imports which is hard requirement for the integration of flink-shaded, and adds a separate checkstyle import block to distinguish these from actual flink imports.
## Brief change log
- allow shaded imports from org.apache.flink.shaded
- add new import block for shaded imports
## Verifying this change
This change can be verified by
* importing some class from org.apache.flink.shaded (doesn't have to exist)
* run `mvn checkstyle:check`, it should only raise an `UnusedImport` error.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
- If yes, how is the feature documented? (**not applicable**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7305
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4425
----
commit 8bfb837f39617e84e37c3ecda4ea0e1b2ec0f196
Author: zentol <ch...@apache.org>
Date: 2017-06-13T15:02:03Z
[FLINK-7305] [checkstyle] Allow imports from org.apache.flink.shaded + add new import block
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4425: [FLINK-7305] [checkstyle] Allow imports from org.a...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4425#discussion_r130827731
--- Diff: tools/maven/checkstyle.xml ---
@@ -198,7 +198,7 @@ This file is based on the checkstyle file of Apache Beam.
<!-- Checks for out of order import statements. -->
<property name="severity" value="error"/>
<!-- Flink imports first, then other imports, then javax, java and scala imports, then static imports. -->
--- End diff --
nit: Update this comment line as well?
"Flink and Flink shaded imports first, then other ..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4425: [FLINK-7305] [checkstyle] Allow imports from org.a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4425: [FLINK-7305] [checkstyle] Allow imports from org.a...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4425#discussion_r130835728
--- Diff: tools/maven/checkstyle.xml ---
@@ -198,7 +198,7 @@ This file is based on the checkstyle file of Apache Beam.
<!-- Checks for out of order import statements. -->
<property name="severity" value="error"/>
<!-- Flink imports first, then other imports, then javax, java and scala imports, then static imports. -->
--- End diff --
Or that, yes :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4425: [FLINK-7305] [checkstyle] Allow imports from org.a...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4425#discussion_r130838704
--- Diff: tools/maven/checkstyle.xml ---
@@ -198,7 +198,7 @@ This file is based on the checkstyle file of Apache Beam.
<!-- Checks for out of order import statements. -->
<property name="severity" value="error"/>
<!-- Flink imports first, then other imports, then javax, java and scala imports, then static imports. -->
--- End diff --
cool, will do while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4425: [FLINK-7305] [checkstyle] Allow imports from org.a...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4425#discussion_r130835579
--- Diff: tools/maven/checkstyle.xml ---
@@ -198,7 +198,7 @@ This file is based on the checkstyle file of Apache Beam.
<!-- Checks for out of order import statements. -->
<property name="severity" value="error"/>
<!-- Flink imports first, then other imports, then javax, java and scala imports, then static imports. -->
--- End diff --
How about removing the line since the line below is self explanatory?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---