You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/05/12 08:02:53 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #2413: [CALCITE-4603] Least restrictive for collections of collections

rubenada commented on a change in pull request #2413:
URL: https://github.com/apache/calcite/pull/2413#discussion_r630814848



##########
File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeFactoryTest.java
##########
@@ -83,6 +83,37 @@
     assertThat(leastRestrictive.isNullable(), is(true));
   }
 
+  @Test void testLeastRestrictiveForArrays() {

Review comment:
       Maybe we should add tests where leastRestrictive is not computable, to verify it returns the expected result (`null`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org