[jira] Commented: (DERBY-4183) Our regression tests use various jar files for which we don't have build scripts.

["Dag H. Wanvik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752276#action_12752276 ] 

Dag H. Wanvik commented on DERBY-4183:
--------------------------------------

Thanks for the patch, Mark.

Some superficial comments:
I think some of the changes for your other patch snuck into this one, cf. DatabaseClassLoadingTest? (it did not compile for me, relying on the new idString method of EmbedPreparedStatement)

All new code needs the usual header, btw.

Did anyone encourage you to file a ICLA, btw? http://wiki.apache.org/db-derby/DerbyContributorChecklist . Apache requires this from contributors when a patch gets non-trivial.



> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4183
>                 URL: https://issues.apache.org/jira/browse/DERBY-4183
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Rick Hillegas
>         Attachments: status.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.