You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Stefan Huehner (JIRA)" <ji...@apache.org> on 2007/03/04 18:38:50 UTC
[jira] Created: (OFBIZ-776) Couple of misc. fixes i.e. unused
return values leading to bugs, type in assignment
Couple of misc. fixes i.e. unused return values leading to bugs, type in assignment
-----------------------------------------------------------------------------------
Key: OFBIZ-776
URL: https://issues.apache.org/jira/browse/OFBIZ-776
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Affects Versions: SVN trunk
Reporter: Stefan Huehner
Priority: Minor
Attachments: ofbiz_misc1.diff
Hi,
patch corrects some misc. issues i noticed:
- string.trim() and string.concat() do not modify the object they are called upon, but rather return the modifed string as a result.
- in the ShoppingCartItem constructor an assignment had no effect but looked like a type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-776) Couple of misc. fixes i.e. unused return
values leading to bugs, type in assignment
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-776.
-----------------------------------
Resolution: Fixed
Framework patch is in rev. 519589
> Couple of misc. fixes i.e. unused return values leading to bugs, type in assignment
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-776
> URL: https://issues.apache.org/jira/browse/OFBIZ-776
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Scott Gray
> Priority: Minor
> Attachments: ofbiz_misc1.diff, ofbiz_misc2.diff
>
>
> Hi,
> patch corrects some misc. issues i noticed:
> - string.trim() and string.concat() do not modify the object they are called upon, but rather return the modifed string as a result.
> - in the ShoppingCartItem constructor an assignment had no effect but looked like a type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-776) Couple of misc. fixes i.e. unused
return values leading to bugs, type in assignment
Posted by "Stefan Huehner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Huehner updated OFBIZ-776:
---------------------------------
Attachment: ofbiz_misc2.diff
Hi,
this patch corrects another possible bug. This null-check was against a field which we just dereferenced instead of the looked up field. Looks like a possible typo.
> Couple of misc. fixes i.e. unused return values leading to bugs, type in assignment
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-776
> URL: https://issues.apache.org/jira/browse/OFBIZ-776
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Priority: Minor
> Attachments: ofbiz_misc1.diff, ofbiz_misc2.diff
>
>
> Hi,
> patch corrects some misc. issues i noticed:
> - string.trim() and string.concat() do not modify the object they are called upon, but rather return the modifed string as a result.
> - in the ShoppingCartItem constructor an assignment had no effect but looked like a type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-776) Couple of misc. fixes i.e. unused
return values leading to bugs, type in assignment
Posted by "Stefan Huehner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Huehner updated OFBIZ-776:
---------------------------------
Attachment: ofbiz_misc1.diff
Patch,. as described in the issue.
> Couple of misc. fixes i.e. unused return values leading to bugs, type in assignment
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-776
> URL: https://issues.apache.org/jira/browse/OFBIZ-776
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Priority: Minor
> Attachments: ofbiz_misc1.diff
>
>
> Hi,
> patch corrects some misc. issues i noticed:
> - string.trim() and string.concat() do not modify the object they are called upon, but rather return the modifed string as a result.
> - in the ShoppingCartItem constructor an assignment had no effect but looked like a type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-776) Couple of misc. fixes i.e. unused
return values leading to bugs, type in assignment
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481925 ]
Scott Gray commented on OFBIZ-776:
----------------------------------
Thanks Stefan, I've commited your first patch in rev. 519584.
Someone else will have to commit the second patch, I've reviewed and it's ok but I don't have permissions to commit to the framework.
> Couple of misc. fixes i.e. unused return values leading to bugs, type in assignment
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-776
> URL: https://issues.apache.org/jira/browse/OFBIZ-776
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Scott Gray
> Priority: Minor
> Attachments: ofbiz_misc1.diff, ofbiz_misc2.diff
>
>
> Hi,
> patch corrects some misc. issues i noticed:
> - string.trim() and string.concat() do not modify the object they are called upon, but rather return the modifed string as a result.
> - in the ShoppingCartItem constructor an assignment had no effect but looked like a type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-776) Couple of misc. fixes i.e. unused
return values leading to bugs, type in assignment
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Gray reassigned OFBIZ-776:
--------------------------------
Assignee: Scott Gray
> Couple of misc. fixes i.e. unused return values leading to bugs, type in assignment
> -----------------------------------------------------------------------------------
>
> Key: OFBIZ-776
> URL: https://issues.apache.org/jira/browse/OFBIZ-776
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Scott Gray
> Priority: Minor
> Attachments: ofbiz_misc1.diff, ofbiz_misc2.diff
>
>
> Hi,
> patch corrects some misc. issues i noticed:
> - string.trim() and string.concat() do not modify the object they are called upon, but rather return the modifed string as a result.
> - in the ShoppingCartItem constructor an assignment had no effect but looked like a type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.