You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/11/08 22:58:23 UTC
Review Request: FLUME-1690. ElasticSearchSink unit tests do not run.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7974/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Renamed the *Test.java files to Test*.java (except AbstractElasticSearchSinkTest.java which contains no tests, only an abstract class).
This addresses bug FLUME-1690.
https://issues.apache.org/jira/browse/FLUME-1690
Diffs
-----
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializerTest.java 3317734
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializerTest.java a974e8b
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkTest.java bb2f9f4
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java PRE-CREATION
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java PRE-CREATION
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java PRE-CREATION
Diff: https://reviews.apache.org/r/7974/diff/
Testing
-------
Ran full build successfully
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1690. ElasticSearchSink unit tests do not run.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7974/#review13297
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Nov. 8, 2012, 9:58 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7974/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2012, 9:58 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Renamed the *Test.java files to Test*.java (except AbstractElasticSearchSinkTest.java which contains no tests, only an abstract class).
>
>
> This addresses bug FLUME-1690.
> https://issues.apache.org/jira/browse/FLUME-1690
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializerTest.java 3317734
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializerTest.java a974e8b
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkTest.java bb2f9f4
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java PRE-CREATION
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java PRE-CREATION
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7974/diff/
>
>
> Testing
> -------
>
> Ran full build successfully
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1690. ElasticSearchSink unit tests do not run.
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7974/#review13335
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Alten-Lorenz
On Nov. 8, 2012, 9:58 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7974/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2012, 9:58 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Renamed the *Test.java files to Test*.java (except AbstractElasticSearchSinkTest.java which contains no tests, only an abstract class).
>
>
> This addresses bug FLUME-1690.
> https://issues.apache.org/jira/browse/FLUME-1690
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializerTest.java 3317734
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializerTest.java a974e8b
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkTest.java bb2f9f4
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java PRE-CREATION
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java PRE-CREATION
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7974/diff/
>
>
> Testing
> -------
>
> Ran full build successfully
>
>
> Thanks,
>
> Hari Shreedharan
>
>