You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/13 19:25:32 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

ijuma commented on a change in pull request #10123:
URL: https://github.com/apache/kafka/pull/10123#discussion_r575703615



##########
File path: checkstyle/import-control.xml
##########
@@ -69,6 +69,17 @@
       <allow pkg="org.apache.kafka.common.metrics" />
     </subpackage>
 
+    <!-- Third-party compression libraries should only be references from this package -->
+    <subpackage name="compression">
+      <allow pkg="com.github.luben.zstd" />
+      <allow pkg="net.jpountz.lz4" />
+      <allow pkg="net.jpountz.xxhash" />
+      <allow pkg="org.apache.kafka.common.compression" />
+      <allow pkg="org.xerial.snappy" />
+      <!-- For testing -->

Review comment:
       That's a good point. It probably means we need to move BufferSupplier to another package to avoid circular dependencies.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org