[GitHub] mbeckerle commented on a change in pull request #49: Daffodil 1907 non dfdl annotation

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #49: Daffodil 1907 non dfdl annotation
URL: https://github.com/apache/incubator-daffodil/pull/49#discussion_r171432487
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/DFDLSchemaFile.scala
 ##########
 @@ -107,20 +107,15 @@ final class DFDLSchemaFile(val sset: SchemaSet,
     // parser throws out of fatalErrors.
   }
 
-  private lazy val loader = {
-    val ldr = new DaffodilXMLLoader(this)
-    // val shouldValidate = sset.validateDFDLSchemas
-    // ldr.setValidation(shouldValidate) // TODO: Validation not occurring JIRA DFDL-1473. Fix later.
-    ldr
-  }
-
   private def loadedNode = LV('loadedNode) {
     def die(e: Throwable) = {
       SDE("Error loading schema due to %s.", Misc.getSomeMessage(e).getOrElse("an unknown error."))
     }
     val node = try {
       log(LogLevel.Resolver, "Loading %s.", diagnosticDebugName)
-      val node = loader.load(schemaSource)
+      val ldr = new DaffodilXMLLoader(this)
+      ldr.setValidation(false)
 
 Review comment:
   Yes. This resolves DAFFODIL-1473 also.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services