You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/21 02:28:25 UTC
[GitHub] [apisix] An-DJ opened a new pull request, #8545: docs: replace the multi-lang-support image with the newer
An-DJ opened a new pull request, #8545:
URL: https://github.com/apache/apisix/pull/8545
### Description
Replace the multi-lang-support image in doc with the newer
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
### Checklist
- [X] I have explained the need for this PR and the problem it solves
- [X] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [X] I have updated the documentation to reflect this change
- [X] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8545: docs: replace the multi-lang-support image with the newer
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #8545:
URL: https://github.com/apache/apisix/pull/8545#discussion_r1054986897
##########
README.md:
##########
@@ -151,7 +151,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- **Multi-Language support**
- Apache APISIX is a multi-language gateway for plugin development and provides support via `RPC` and `Wasm`.
- 
Review Comment:
What does "temporarily" mean? A month or a year?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #8545: docs: replace the multi-lang-support image with the newer
Posted by GitBox <gi...@apache.org>.
membphis merged PR #8545:
URL: https://github.com/apache/apisix/pull/8545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8545: docs: replace the multi-lang-support image with the newer
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #8545:
URL: https://github.com/apache/apisix/pull/8545#discussion_r1054032965
##########
README.md:
##########
@@ -151,7 +151,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- **Multi-Language support**
- Apache APISIX is a multi-language gateway for plugin development and provides support via `RPC` and `Wasm`.
- 
Review Comment:
We can remove the old image?
https://github.com/apache/apisix/blob/master/docs/assets/images/apisix-multi-lang-support.png
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] An-DJ commented on a diff in pull request #8545: docs: replace the multi-lang-support image with the newer
Posted by GitBox <gi...@apache.org>.
An-DJ commented on code in PR #8545:
URL: https://github.com/apache/apisix/pull/8545#discussion_r1054040429
##########
README.md:
##########
@@ -151,7 +151,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- **Multi-Language support**
- Apache APISIX is a multi-language gateway for plugin development and provides support via `RPC` and `Wasm`.
- 
Review Comment:
@membphis and I think that the old image may be used in other existing websites, so that its' deletion may cause panic. We'd better remain it temporarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #8545: docs: replace the multi-lang-support image with the newer
Posted by GitBox <gi...@apache.org>.
soulbird commented on code in PR #8545:
URL: https://github.com/apache/apisix/pull/8545#discussion_r1054989520
##########
README.md:
##########
@@ -151,7 +151,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- **Multi-Language support**
- Apache APISIX is a multi-language gateway for plugin development and provides support via `RPC` and `Wasm`.
- 
Review Comment:
If panic, then we fix it one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org