You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vijaykiran <gi...@git.apache.org> on 2016/01/05 12:10:33 UTC
[GitHub] spark pull request: [SPARK-12633][DOC] Update param descriptions
GitHub user vijaykiran opened a pull request:
https://github.com/apache/spark/pull/10600
[SPARK-12633][DOC] Update param descriptions
Updates the param descriptions to be consistent. See [SPARK-11219] for
more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vijaykiran/spark SPARK-12633
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10600
----
commit b609b486cc0725ff3b9e659ddc8cae15556c33bc
Author: vijaykiran <ma...@vijaykiran.com>
Date: 2016-01-05T11:08:34Z
[SPARK-12633][DOC] Update param descriptions
Updates the param descriptions to be consistent. See [SPARK-11219] for
more details.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by vijaykiran <gi...@git.apache.org>.
Github user vijaykiran commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50617105
--- Diff: python/pyspark/mllib/regression.py ---
@@ -66,8 +67,10 @@ class LinearModel(object):
"""
A linear model that has a vector of coefficients and an intercept.
- :param weights: Weights computed for every feature.
- :param intercept: Intercept computed for this model.
+ :param weights:
+ Weights computed for every feature.
--- End diff --
Sorry - I don't understand, which word ? "Weights" is already capitalized ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-187619600
@BryanCutler it looks like a version of the "allowed values" got merged in the PR for `classification.py` - https://github.com/apache/spark/pull/11183/files#diff-3a683f424bec70006f6c225a32d162f9R297?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-175341022
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50151/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-189444469
@MLnick I don't have a preference for `Supported values` vs `Allowed values` but I would like to see it consistent throughout, so it should probably be updated in `classification.py`. Should I do that here, or open another issue for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-175341019
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50575636
--- Diff: python/pyspark/mllib/regression.py ---
@@ -66,8 +67,10 @@ class LinearModel(object):
"""
A linear model that has a vector of coefficients and an intercept.
- :param weights: Weights computed for every feature.
- :param intercept: Intercept computed for this model.
+ :param weights:
+ Weights computed for every feature.
--- End diff --
Capitalize the first word
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-175340697
**[Test build #50151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50151/consoleFull)** for PR 10600 at commit [`5feecba`](https://github.com/apache/spark/commit/5feecbad219895696709d804facfb8c575d1d5b4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-178847838
we need to settle on the `:Allowed values:` format, also in classification.py, before we can finish this one up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50575904
--- Diff: python/pyspark/mllib/regression.py ---
@@ -393,27 +401,35 @@ def train(cls, data, iterations=100, step=1.0, regParam=0.01,
set of rows of A, each with its corresponding right hand side
label y. See also the documentation for the precise formulation.
- :param data: The training data, an RDD of
- LabeledPoint.
- :param iterations: The number of iterations
- (default: 100).
- :param step: The step parameter used in SGD
- (default: 1.0).
- :param regParam: The regularizer parameter
- (default: 0.01).
- :param miniBatchFraction: Fraction of data to be used for each
- SGD iteration (default: 1.0).
- :param initialWeights: The initial weights (default: None).
- :param intercept: Boolean parameter which indicates the
- use or not of the augmented representation
- for training data (i.e. whether bias
- features are activated or not,
- default: False).
- :param validateData: Boolean parameter which indicates if
- the algorithm should validate data
- before training. (default: True)
- :param convergenceTol: A condition which decides iteration termination.
- (default: 0.001)
+ :param data:
+ The training data, an RDD of LabeledPoint.
+ :param iterations:
+ The number of iterations.
+ (default: 100)
+ :param step:
+ The step parameter used in SGD.
+ (default: 1.0)
+ :param regParam:
+ The regularizer parameter.
+ (default: 0.01)
+ :param miniBatchFraction:
+ Fraction of data to be used for each SGD iteration.
+ (default: 1.0)
+ :param initialWeights:
+ The initial weights.
+ (default: None)
+ :param intercept:
+ Boolean parameter which indicates the use or not of the
+ augmented representation for training data (i.e. whether bias
+ features are activated or not).
+ (default: False)
--- End diff --
not aligned properly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-189312012
@BryanCutler ok, from that comment discussion it seems the format agreed would be:
```
Allowed values:
- "l1" ...
- "l2" ...
```
As we discussed in the PR for `tree.py`, I prefer `Supported values` over `Allowed values`, though that would require updating it here and in `classification.py` (and #10598 has been merged already).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-175332872
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by vijaykiran <gi...@git.apache.org>.
Github user vijaykiran commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-174636594
@BryanCutler Fixed the indentation and added period.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50575606
--- Diff: python/pyspark/mllib/regression.py ---
@@ -37,10 +37,11 @@ class LabeledPoint(object):
"""
Class that represents the features and labels of a data point.
- :param label: Label for this data point.
- :param features: Vector of features for this point (NumPy array,
- list, pyspark.mllib.linalg.SparseVector, or scipy.sparse
- column matrix)
+ :param label:
+ Label for this data point.
+ :param features:
+ Vector of features for this point (NumPy array, list,
+ pyspark.mllib.linalg.SparseVector, or scipy.sparse column matrix)
--- End diff --
Capitalize the first word and add a period at the end
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-187813500
Yeah, we were discussing the format of "allowed values" in that PR. I just wanted to make sure we used the same format for the similar params here. I'm not too crazy about the extra blank lines, but Sphinx requires them to format it correctly without generating errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50734713
--- Diff: python/pyspark/mllib/regression.py ---
@@ -37,10 +37,11 @@ class LabeledPoint(object):
"""
Class that represents the features and labels of a data point.
- :param label: Label for this data point.
- :param features: Vector of features for this point (NumPy array,
- list, pyspark.mllib.linalg.SparseVector, or scipy.sparse
- column matrix)
+ :param label:
+ Label for this data point.
+ :param features:
+ Vector of features for this point (NumPy array, list,
+ pyspark.mllib.linalg.SparseVector, or scipy.sparse column matrix)
--- End diff --
Sorry, my bad - it is already capitalized, my font was too small I guess :). Could you just add a period after the end of the description? So should read ..."scipy.sparse column matrix)."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-170159799
I just added a note to the parent JIRA about a formatting issue affecting all 5 PRs: [https://issues.apache.org/jira/browse/SPARK-11219?focusedCommentId=15090225&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15090225]
Could you please check it out & ping when I should review again? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-175333725
**[Test build #50151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50151/consoleFull)** for PR 10600 at commit [`5feecba`](https://github.com/apache/spark/commit/5feecbad219895696709d804facfb8c575d1d5b4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][DOC] Update param descriptions
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-168973957
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by vijaykiran <gi...@git.apache.org>.
Github user vijaykiran commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50745215
--- Diff: python/pyspark/mllib/regression.py ---
@@ -393,27 +401,35 @@ def train(cls, data, iterations=100, step=1.0, regParam=0.01,
set of rows of A, each with its corresponding right hand side
label y. See also the documentation for the precise formulation.
- :param data: The training data, an RDD of
- LabeledPoint.
- :param iterations: The number of iterations
- (default: 100).
- :param step: The step parameter used in SGD
- (default: 1.0).
- :param regParam: The regularizer parameter
- (default: 0.01).
- :param miniBatchFraction: Fraction of data to be used for each
- SGD iteration (default: 1.0).
- :param initialWeights: The initial weights (default: None).
- :param intercept: Boolean parameter which indicates the
- use or not of the augmented representation
- for training data (i.e. whether bias
- features are activated or not,
- default: False).
- :param validateData: Boolean parameter which indicates if
- the algorithm should validate data
- before training. (default: True)
- :param convergenceTol: A condition which decides iteration termination.
- (default: 0.001)
+ :param data:
+ The training data, an RDD of LabeledPoint.
+ :param iterations:
+ The number of iterations.
+ (default: 100)
+ :param step:
+ The step parameter used in SGD.
+ (default: 1.0)
+ :param regParam:
+ The regularizer parameter.
+ (default: 0.01)
+ :param miniBatchFraction:
+ Fraction of data to be used for each SGD iteration.
+ (default: 1.0)
+ :param initialWeights:
+ The initial weights.
+ (default: None)
+ :param intercept:
+ Boolean parameter which indicates the use or not of the
+ augmented representation for training data (i.e. whether bias
+ features are activated or not).
+ (default: False)
--- End diff --
Fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by vijaykiran <gi...@git.apache.org>.
Github user vijaykiran commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-173933605
ping @jkbradley !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-189482847
It's pretty minor so just add it here
On Fri, 26 Feb 2016 at 21:31, Bryan Cutler <no...@github.com> wrote:
> @MLnick <https://github.com/MLnick> I don't have a preference for Supported
> values vs Allowed values but I would like to see it consistent
> throughout, so it should probably be updated in classification.py. Should
> I do that here, or open another issue for that?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/10600#issuecomment-189444469>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50734723
--- Diff: python/pyspark/mllib/regression.py ---
@@ -66,8 +67,10 @@ class LinearModel(object):
"""
A linear model that has a vector of coefficients and an intercept.
- :param weights: Weights computed for every feature.
- :param intercept: Intercept computed for this model.
+ :param weights:
+ Weights computed for every feature.
--- End diff --
My fault again, this is fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-174027903
Thanks @vijaykiran , just a couple minor corrections and would you mind changing the PR title to indicate this is for regression.py?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12633][Python][MLlib][DOC] Update param...
Posted by vijaykiran <gi...@git.apache.org>.
Github user vijaykiran commented on a diff in the pull request:
https://github.com/apache/spark/pull/10600#discussion_r50617094
--- Diff: python/pyspark/mllib/regression.py ---
@@ -37,10 +37,11 @@ class LabeledPoint(object):
"""
Class that represents the features and labels of a data point.
- :param label: Label for this data point.
- :param features: Vector of features for this point (NumPy array,
- list, pyspark.mllib.linalg.SparseVector, or scipy.sparse
- column matrix)
+ :param label:
+ Label for this data point.
+ :param features:
+ Vector of features for this point (NumPy array, list,
+ pyspark.mllib.linalg.SparseVector, or scipy.sparse column matrix)
--- End diff --
Do you mean "pyspark.mllib" should be "Pyspark" ? I thought package names should be left alone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org