You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/21 16:42:51 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10918:
[FLINK-15684][docs][bp-1.10] Add taskmanager.memory.flink.size to common
options
tillrohrmann commented on a change in pull request #10918: [FLINK-15684][docs][bp-1.10] Add taskmanager.memory.flink.size to common options
URL: https://github.com/apache/flink/pull/10918#discussion_r369114604
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -257,20 +257,25 @@
key("taskmanager.memory.process.size")
.memoryType()
.noDefaultValue()
- .withDescription("Total Process Memory size for the TaskExecutors. This includes all the memory that a"
- + " TaskExecutor consumes, consisting of Total Flink Memory, JVM Metaspace, and JVM Overhead. On"
- + " containerized setups, this should be set to the container memory.");
+ .withDescription("Total Process Memory size for the TaskExecutors. This includes all the memory that a "
+ + "TaskExecutor consumes, consisting of Total Flink Memory (configured with "
+ + "'taskmanager.memory.flink.size'), JVM Metaspace, and JVM Overhead. On "
+ + "containerized setups, this should be set to the container memory."
Review comment:
I would put the reference to `flink.size` at the end of the description similar to what we are doing in the description of `TOTAL_FLINK_MEMORY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services