You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "macroguo-ghy (via GitHub)" <gi...@apache.org> on 2023/08/18 06:09:36 UTC

[GitHub] [calcite] macroguo-ghy commented on a diff in pull request #3363: [CALCITE-5922] The SQL generated for the POSITION function(with 3 input arguments) by the SparkSqlDialect is not recognized by Spark SQL

macroguo-ghy commented on code in PR #3363:
URL: https://github.com/apache/calcite/pull/3363#discussion_r1298015064


##########
core/src/main/java/org/apache/calcite/sql/dialect/SparkSqlDialect.java:
##########
@@ -147,9 +147,34 @@ public SparkSqlDialect(SqlDialect.Context context) {
       case TRIM:
         unparseHiveTrim(writer, call, leftPrec, rightPrec);
         break;
+      case POSITION:

Review Comment:
   Good suggestion! I replaced it with `SqlUtil.unparseFunctionSyntax`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org