You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/10 21:31:09 UTC

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #21803: Separated pandas and numpy implementations of sklearn.

ryanthompson591 commented on code in PR #21803:
URL: https://github.com/apache/beam/pull/21803#discussion_r894902713


##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -43,13 +41,26 @@ class ModelFileType(enum.Enum):
   JOBLIB = 2
 
 
-class SklearnModelHandler(ModelHandler[Union[numpy.ndarray, pandas.DataFrame],
-                                       PredictionResult,
-                                       BaseEstimator]):
-  """ Implementation of the ModelHandler interface for scikit-learn.
+def load_model(model_uri, file_type):

Review Comment:
   yep it should be private. I don't think it should go in the base class, because it is sklearn specific and will not be used outside this module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org