You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/29 09:15:05 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #28634: Add doc-strings and small improvement to email util

potiuk commented on code in PR #28634:
URL: https://github.com/apache/airflow/pull/28634#discussion_r1058832965


##########
airflow/utils/email.py:
##########
@@ -87,7 +106,7 @@ def send_email_smtp(
     from_email: str | None = None,
     custom_headers: dict[str, Any] | None = None,
     **kwargs,
-):
+) -> None:

Review Comment:
   Maybe a good idea to add parameter docstring here for consistency? Seems to be the last undocumented method here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org