You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/11 02:36:13 UTC
[GitHub] [spark] sarutak commented on a change in pull request #28448: [SPARK-31638][WEBUI]Clean Pagination code for all webUI pages
sarutak commented on a change in pull request #28448:
URL: https://github.com/apache/spark/pull/28448#discussion_r422748282
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -523,13 +517,11 @@ private[ui] class JobPagedTable(
store,
data,
basePath,
- currentTime,
Review comment:
If we can remove `currentTime` here, can we also remove `currentTime` from `JobPagedTable`?
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -573,17 +563,9 @@ private[ui] class JobPagedTable(
<th class={cssClass}>
<a href={headerLink}>
- {
- if (tooltip.nonEmpty) {
- <span data-toggle="tooltip" data-placement="top" title={tooltip.get}>
- {header} {Unparsed(arrow)}
- </span>
- } else {
- <span>
- {header} {Unparsed(arrow)}
- </span>
- }
- }
+ <span data-toggle="tooltip" data-placement="top" title={tooltip.getOrElse("")}>
Review comment:
Nice catch. Tooltips with zero-length titles are never displayed.
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
##########
@@ -501,25 +499,21 @@ private[ui] class TaskPagedTable(
override val dataSource: TaskDataSource = new TaskDataSource(
stage,
- currentTime,
Review comment:
Similar to the comment for AllJobsPage, can we remove `currentTime` from `TaskPagedTable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org