[GitHub] [tinkerpop] spmallette commented on pull request #1403: TINKERPOP-2472 GraphBinary for Gremlin.Net

[GitBox <gi...@apache.org>]

spmallette commented on pull request #1403:
URL: https://github.com/apache/tinkerpop/pull/1403#issuecomment-800159590


   > Given how big the PR already is, I suggest that we keep it as is for now and change the configuration to GraphBinary manually to execute the tests locally when we make non-trivial changes to GraphBinary.
   
   I'm fine with that for now, but we really should have the GLV tests run with both serializers on each build. Please create a follow-on issue in JIRA for it and it can be some we return to later. 
   
   > I also haven't implemented serializers for Metrics and TraversalMetrics. Not sure if we need those in the first version as they are also not supported for GraphSON. So, I would prefer to add them with a follow-up PR.
   
    GraphSON supports metrics: https://tinkerpop.apache.org/docs/3.4.10/dev/io/#_metrics_2 but if you just want to get in what you have that's fine. I presume we would add Upgrade Documentation and Reference Documentation adjustments when that happens?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org