You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/03 17:43:58 UTC
[GitHub] [trafficcontrol] rob05c commented on a change in pull request
#4596: Add support for server search server side
rob05c commented on a change in pull request #4596: Add support for server search server side
URL: https://github.com/apache/trafficcontrol/pull/4596#discussion_r403185992
##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -242,6 +242,30 @@ func getServers(params map[string]string, tx *sqlx.Tx, user *auth.CurrentUser) (
"dsId": dbhelpers.WhereColumnInfo{"dss.deliveryservice", nil},
}
+ searchQueryParamsToSQLCols := map[string]dbhelpers.WhereColumnInfo{
Review comment:
We should make sure all the columns we're allowing search on have indexes, to prevent performance issues and accidental or intentional DDOS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services