You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/06 14:11:22 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #537: bug: respond status of api should keep same as `admin api` do
nic-chen opened a new issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ x ] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
___
### Bug
after refactor, respond status of api should keep same as `admin api` do.
but it's always 200 currently.
I think we need to fix it in `github.com/shiningrush/droplet`
@ShiningRush please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705950739
Please follow the RESTful way, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705952415
OK, I will add a new field for `Response` to control http status code this afternoon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705932393
We only need to ensure that the data structure is the same as that of AdminAPI, not the response code.
Using response codes to check the result is not a good way,this will increase the complexity of the front-end, and can not enumerate all situations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
ShiningRush edited a comment on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705932393
We only need to ensure that the data structure is the same as that of admin API, not the response code.
Using response codes to check the result is not a good way,this will increase the complexity of the front-end, and can not enumerate all situations
Is here any reason that we must keep same http status code with admin API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705950739
Please follow the RESTful way, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
ShiningRush edited a comment on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705932393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705945254
As far as I know, some users have already used `http status` in their system, if we do not maintain the original `http status `, they will have to modify the code.
Moreover, the response status code of the admin api complies with `resful` specifications.
The workload of front-end changes need @juzhiyuan to take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-706563608
After discussions, the frontend will use the Logic Code instead of standard HTTP Status code to check if this request is successful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705932393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705945254
As far as I know, some users have already used `http status` in their system, if we do not maintain the original `http status `, they will have to modify the code.
Moreover, the response status code of the admin api complies with `resful` specifications.
The workload of front-end changes need @juzhiyuan to take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #537: bug: respond status of api should keep same as `admin api` do
Posted by GitBox <gi...@apache.org>.
ShiningRush edited a comment on issue #537:
URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705932393
We only need to ensure that the data structure is the same as that of admin API, not the response code.
Using response codes to check the result is not a good way,this will increase the complexity of the front-end, and can not enumerate all situations
Is there any reason that we must keep same http status code with admin API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org