You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/06 13:53:21 UTC
[GitHub] [druid] freddief opened a new pull request #11557: add support for avro decimal/date logical types
freddief opened a new pull request #11557:
URL: https://github.com/apache/druid/pull/11557
Fixes https://github.com/apache/druid/issues/10663
Avro decimal logical types are deserialised and put into Druid as bytes. This PR parses the byte represenation and turns it into a double to be ingested into Druid
##### Key changed/added classes in this PR
* `org.apache.druid.data.input.avro.AvroFlattenerMaker`
* `org.apache.druid.data.input.avro.AvroLogicalTypeConverter`
This PR has:
- [X] been self-reviewed.
- [X] added documentation for new or modified features or behaviors.
- [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zachjsh commented on pull request #11557: add support for avro decimal/date logical types
Posted by GitBox <gi...@apache.org>.
zachjsh commented on pull request #11557:
URL: https://github.com/apache/druid/pull/11557#issuecomment-1016649839
@freddief , thank you for your contribution! Have you run any manual verification of this change? If so, would you provide details of the steps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org