You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stefan Bodewig <bo...@apache.org> on 2021/07/03 09:50:50 UTC
[compress] poor test coverage of harmony code
Hi
our current pack200 tests don't seem to cover much of the pack200 code
imported from harmony and the overall test coverage of Compress as a
whole has dropped significantly (from 86% to 61%) as the new package
contains quite a bit of code.
I assume the code originates from
https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
and I'd look into porting the tests from
https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
unless anybody else has also started to look into it.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] poor test coverage of harmony code
Posted by Gary Gregory <ga...@gmail.com>.
Nice!
Gary
On Sat, Jul 3, 2021, 10:15 Stefan Bodewig <bo...@apache.org> wrote:
> On 2021-07-03, Stefan Bodewig wrote:
>
> > I assume the code originates from
> >
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
> > and I'd look into porting the tests from
> >
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
> > unless anybody else has also started to look into it.
>
> Back at 86% coverage.
>
> The tests are JUnit 3.x style and I have left them at that. I basically
> only changed the package names and removed a test that asserted a given
> class was compiled for Java 1.4.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [compress] poor test coverage of harmony code
Posted by PeterLee <pe...@apache.org>.
This is great work. Thanks.
cheers,
Lee
On Sat, Jul 3, 2021 at 10:15 PM Stefan Bodewig <bo...@apache.org> wrote:
> On 2021-07-03, Stefan Bodewig wrote:
>
> > I assume the code originates from
> >
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
> > and I'd look into porting the tests from
> >
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
> > unless anybody else has also started to look into it.
>
> Back at 86% coverage.
>
> The tests are JUnit 3.x style and I have left them at that. I basically
> only changed the package names and removed a test that asserted a given
> class was compiled for Java 1.4.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [compress] poor test coverage of harmony code
Posted by Stefan Bodewig <bo...@apache.org>.
On 2021-07-03, Stefan Bodewig wrote:
> I assume the code originates from
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
> and I'd look into porting the tests from
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
> unless anybody else has also started to look into it.
Back at 86% coverage.
The tests are JUnit 3.x style and I have left them at that. I basically
only changed the package names and removed a test that asserted a given
class was compiled for Java 1.4.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [compress] poor test coverage of harmony code
Posted by Gary Gregory <ga...@gmail.com>.
Good idea, I mistakenly thought our coverage was better.
Gary
On Sat, Jul 3, 2021, 05:50 Stefan Bodewig <bo...@apache.org> wrote:
> Hi
>
> our current pack200 tests don't seem to cover much of the pack200 code
> imported from harmony and the overall test coverage of Compress as a
> whole has dropped significantly (from 86% to 61%) as the new package
> contains quite a bit of code.
>
> I assume the code originates from
>
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/
> and I'd look into porting the tests from
>
> https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/test/
> unless anybody else has also started to look into it.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>