You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/11 04:55:28 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #10035: Minor changes for code format
terrymanu opened a new pull request #10035:
URL: https://github.com/apache/shardingsphere/pull/10035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #10035: Minor changes for code format with Authority module
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #10035:
URL: https://github.com/apache/shardingsphere/pull/10035#discussion_r611130723
##########
File path: shardingsphere-features/shardingsphere-authority/shardingsphere-authority-common/src/main/java/org/apache/shardingsphere/authority/provider/natived/loader/StoragePrivilegeLoader.java
##########
@@ -32,11 +32,11 @@
public interface StoragePrivilegeLoader extends TypedSPI {
/**
- * Load privilege.
+ * Load privilege from storage.
*
- * @param users users
- * @param dataSource data source
- * @return ShardingSphere privileges
+ * @param users users to be loaded
Review comment:
users users ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10035: Minor changes for code format with Authority module
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10035:
URL: https://github.com/apache/shardingsphere/pull/10035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org