[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7475: GEODE-10119: Do not log SSLHandshakeException as fatal

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #7475:
URL: https://github.com/apache/geode/pull/7475#discussion_r833500632



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##########
@@ -599,10 +598,6 @@ void configureClientSSLSocket(Socket socket, HostAndPort addr, int timeout) thro
         } else {
           throw ex;
         }
-      } catch (SSLHandshakeException ex) {

Review comment:
       This removal seems like too much to me. The old code treated every SSLHandshakeException as a serious problem by always logging it at the fatal level. I think this may be too much (I'd guess that all the exception handling logging here should be "warn" instead of "fatal") but I don't think you should completely get rid of the logging.
   Consider changing this not to log if the exception's message contains "Remote host terminated the handshake" like you do at the higher level.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org