You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vogievetsky (via GitHub)" <gi...@apache.org> on 2024/02/13 20:09:11 UTC
[PR] Web console: fix typos in Kinesis suggestions (druid)
vogievetsky opened a new pull request, #15900:
URL: https://github.com/apache/druid/pull/15900
Possibly the simplest PR ever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: fix typos in Kinesis suggestions, add regions and groups (druid)
Posted by "asdf2014 (via GitHub)" <gi...@apache.org>.
asdf2014 commented on code in PR #15900:
URL: https://github.com/apache/druid/pull/15900#discussion_r1489307337
##########
web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx:
##########
@@ -1107,28 +1107,85 @@ export function getIoConfigFormFields(ingestionComboType: IngestionComboType): F
type: 'string',
defaultValue: 'kinesis.us-east-1.amazonaws.com',
suggestions: [
- 'kinesis.us-east-2.amazonaws.com',
- 'kinesis.us-east-1.amazonaws.com',
- 'kinesis.us-west-1.amazonaws.com',
- 'kinesis.us-west-2.amazonaws.com',
- 'kinesis.ap-east-1.amazonaws.com',
- 'kinesis.ap-south-1.amazonaws.com',
- 'kinesis.ap-northeast-3.amazonaws.com',
- 'kinesis.ap-northeast-2.amazonaws.com',
- 'kinesis.ap-southeast-1.amazonaws.com',
- 'kinesis.ap-southeast-2.amazonaws.com',
- 'kinesis.ap-northeast-1.amazonaws.com',
- 'kinesis.ca-central-1.amazonaws.com',
- 'kinesis.cn-north-1.amazonaws.com.com',
- 'kinesis.cn-northwest-1.amazonaws.com.com',
- 'kinesis.eu-central-1.amazonaws.com',
- 'kinesis.eu-west-1.amazonaws.com',
- 'kinesis.eu-west-2.amazonaws.com',
- 'kinesis.eu-west-3.amazonaws.com',
- 'kinesis.eu-north-1.amazonaws.com',
- 'kinesis.sa-east-1.amazonaws.com',
- 'kinesis.us-gov-east-1.amazonaws.com',
- 'kinesis.us-gov-west-1.amazonaws.com',
+ {
+ group: 'US East',
+ suggestions: [
+ 'kinesis.us-east-1.amazonaws.com',
+ 'kinesis-fips.us-east-1.amazonaws.com',
+ 'kinesis.us-east-2.amazonaws.com',
+ 'kinesis-fips.us-east-2.amazonaws.com',
+ ],
+ },
+ {
+ group: 'US Gameday Northeast',
+ suggestions: ['kinesis.us-northeast-1.amazonaws.com'],
+ },
+ {
+ group: 'US West',
+ suggestions: [
+ 'kinesis.us-west-1.amazonaws.com',
+ 'kinesis-fips.us-west-1.amazonaws.com',
+ 'kinesis.us-west-2.amazonaws.com',
+ 'kinesis-fips.us-west-2.amazonaws.com',
+ ],
+ },
+ { group: 'Africa', suggestions: ['kinesis.af-south-1.amazonaws.com'] },
+ {
+ group: 'Asia Pacific',
+ suggestions: [
+ 'kinesis.ap-east-1.amazonaws.com',
+ 'kinesis.ap-south-2.amazonaws.com',
+ 'kinesis.ap-southeast-3.amazonaws.com',
+ 'kinesis.ap-southeast-5.amazonaws.com',
+ 'kinesis.ap-southeast-4.amazonaws.com',
+ 'kinesis.ap-south-1.amazonaws.com',
+ 'kinesis.ap-northeast-3.amazonaws.com',
+ 'kinesis.ap-northeast-2.amazonaws.com',
+ 'kinesis.ap-southeast-1.amazonaws.com',
+ 'kinesis.ap-southeast-2.amazonaws.com',
+ 'kinesis.ap-northeast-1.amazonaws.com',
+ ],
+ },
+ {
+ group: 'Canada',
+ suggestions: [
+ 'kinesis.ca-central-1.amazonaws.com',
+ 'kinesis.ca-west-1.amazonaws.com',
+ ],
+ },
+ {
+ group: 'China',
+ suggestions: ['kinesis.cn-north-1.amazonaws.com.cn'],
Review Comment:
```suggestion
suggestions: [
'kinesis.cn-north-1.amazonaws.com.cn',
'kinesis.cn-northwest-1.amazonaws.com.cn'
],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: fix typos in Kinesis suggestions, add regions and groups (druid)
Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 merged PR #15900:
URL: https://github.com/apache/druid/pull/15900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org